* [PATCH] kernel-devsrc: improve reproducibility for arm64
@ 2020-10-29 11:40 Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-10-29 11:44 ` [OE-core] " Bruce Ashfield
0 siblings, 1 reply; 7+ messages in thread
From: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) @ 2020-10-29 11:40 UTC (permalink / raw)
To: openembedded-core
.vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
It breaks reproducibility because it has an absolute path in it. There is no
any value to package such files so it can be dropped.
Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
---
meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
index aa8e162f4f..f8c750beaa 100644
--- a/meta/recipes-kernel/linux/kernel-devsrc.bb
+++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
@@ -113,6 +113,10 @@ do_install() {
# but without this file, we get a forced syncconfig run in v5.8+, which prompts and
# breaks workflows.
cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
+
+ if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
+ rm $kerneldir/include/generated/.vdso-offsets.h.cmd
+ fi
)
# now grab the chunks from the source tree that we need
--
2.19.0.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
2020-10-29 11:40 [PATCH] kernel-devsrc: improve reproducibility for arm64 Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
@ 2020-10-29 11:44 ` Bruce Ashfield
2020-10-30 12:30 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1642C502B17F26A6.28917@lists.openembedded.org>
0 siblings, 2 replies; 7+ messages in thread
From: Bruce Ashfield @ 2020-10-29 11:44 UTC (permalink / raw)
To: dzagorui; +Cc: Patches and discussions about the oe-core layer
On Thu, Oct 29, 2020 at 7:41 AM Denys Zagorui -X (dzagorui -
GLOBALLOGIC INC@Cisco) via lists.openembedded.org
<dzagorui=cisco.com@lists.openembedded.org> wrote:
>
> .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> It breaks reproducibility because it has an absolute path in it. There is no
> any value to package such files so it can be dropped.
>
Have you confirmed that an on-target 'make scripts prepare' property
regenerates the file without triggering and oldconfig ?
Otherwise, the change looks fine to me.
Bruce
> Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
> ---
> meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> index aa8e162f4f..f8c750beaa 100644
> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> @@ -113,6 +113,10 @@ do_install() {
> # but without this file, we get a forced syncconfig run in v5.8+, which prompts and
> # breaks workflows.
> cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
> +
> + if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
> + rm $kerneldir/include/generated/.vdso-offsets.h.cmd
> + fi
> )
>
> # now grab the chunks from the source tree that we need
> --
> 2.19.0.dirty
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
2020-10-29 11:44 ` [OE-core] " Bruce Ashfield
@ 2020-10-30 12:30 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1642C502B17F26A6.28917@lists.openembedded.org>
1 sibling, 0 replies; 7+ messages in thread
From: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) @ 2020-10-30 12:30 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
> > .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> > It breaks reproducibility because it has an absolute path in it. There is no
> > any value to package such files so it can be dropped.
> >
>
> Have you confirmed that an on-target 'make scripts prepare' property
> regenerates the file without triggering and oldconfig ?
>
> Otherwise, the change looks fine to me.
>
> Bruce
Yes, confirmed that oldconfig wont be triggered.
Thanks,
Denys
>
> > Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
> > ---
> > meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > index aa8e162f4f..f8c750beaa 100644
> > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > @@ -113,6 +113,10 @@ do_install() {
> > # but without this file, we get a forced syncconfig run in v5.8+, which prompts and
> > # breaks workflows.
> > cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
> > +
> > + if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
> > + rm $kerneldir/include/generated/.vdso-offsets.h.cmd
> > + fi
> > )
> >
> > # now grab the chunks from the source tree that we need
> > --
> > 2.19.0.dirty
> >
> >
> >
> >
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
[not found] ` <1642C502B17F26A6.28917@lists.openembedded.org>
@ 2020-11-09 9:53 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1645CE4049F0E4CD.31324@lists.openembedded.org>
1 sibling, 0 replies; 7+ messages in thread
From: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) @ 2020-11-09 9:53 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
> > > .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> > > It breaks reproducibility because it has an absolute path in it. There is no
> > > any value to package such files so it can be dropped.
> > >
> >
> > Have you confirmed that an on-target 'make scripts prepare' property
> > regenerates the file without triggering and oldconfig ?
> >
> > Otherwise, the change looks fine to me.
> >
> > Bruce
>
> Yes, confirmed that oldconfig wont be triggered.
>
> Thanks,
> Denys
ping
>
> >
> > > Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
> > > ---
> > > meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > > index aa8e162f4f..f8c750beaa 100644
> > > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > > @@ -113,6 +113,10 @@ do_install() {
> > > # but without this file, we get a forced syncconfig run in v5.8+, which prompts and
> > > # breaks workflows.
> > > cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
> > > +
> > > + if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
> > > + rm $kerneldir/include/generated/.vdso-offsets.h.cmd
> > > + fi
> > > )
> > >
> > > # now grab the chunks from the source tree that we need
> > > --
> > > 2.19.0.dirty
> > >
> > >
> > >
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
[not found] ` <1645CE4049F0E4CD.31324@lists.openembedded.org>
@ 2020-11-16 15:14 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-11-16 15:23 ` Bruce Ashfield
0 siblings, 1 reply; 7+ messages in thread
From: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) @ 2020-11-16 15:14 UTC (permalink / raw)
To: Bruce Ashfield, Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
Cc: Patches and discussions about the oe-core layer
> > > .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> > > It breaks reproducibility because it has an absolute path in it. There is no
> > > any value to package such files so it can be dropped.
> > >
> >
> > Have you confirmed that an on-target 'make scripts prepare' property
> > regenerates the file without triggering and oldconfig ?
> >
> > Otherwise, the change looks fine to me.
> >
> > Bruce
>
> Yes, confirmed that oldconfig wont be triggered.
>
> Thanks,
> Denys
ping
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
2020-11-16 15:14 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
@ 2020-11-16 15:23 ` Bruce Ashfield
2020-11-16 15:29 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Ashfield @ 2020-11-16 15:23 UTC (permalink / raw)
To: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Mon, Nov 16, 2020 at 10:14 AM Denys Zagorui -X (dzagorui - GLOBALLOGIC
INC at Cisco) <dzagorui@cisco.com> wrote:
>
> > > > .vdso-offsets.h.cmd contains command that was used to produce
> vdso-offsets.h.
> > > > It breaks reproducibility because it has an absolute path in it.
> There is no
> > > > any value to package such files so it can be dropped.
> > > >
> > >
> > > Have you confirmed that an on-target 'make scripts prepare' property
> > > regenerates the file without triggering and oldconfig ?
> > >
> > > Otherwise, the change looks fine to me.
> > >
> > > Bruce
> >
> > Yes, confirmed that oldconfig wont be triggered.
> >
> > Thanks,
> > Denys
>
> ping
>
I expected that this would have been picked up after I acked it, but there
was a release to do in the middle of it being submitted and now .. so
things have been a bit slower.
I'll put it in my local queue, that way if it doesn't get picked up, I'll
send it with my next pull request.
Bruce
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
[-- Attachment #2: Type: text/html, Size: 2089 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
2020-11-16 15:23 ` Bruce Ashfield
@ 2020-11-16 15:29 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
0 siblings, 0 replies; 7+ messages in thread
From: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) @ 2020-11-16 15:29 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
> I expected that this would have been picked up after I acked it, but there was a release to do in the middle of it being submitted and now .. so things have been a bit slower.
>
> I'll put it in my local queue, that way if it doesn't get picked up, I'll send it with my next pull request.
>
> Bruce
I see
Thanks,
Denys
[-- Attachment #2: Type: text/html, Size: 1204 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-16 15:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 11:40 [PATCH] kernel-devsrc: improve reproducibility for arm64 Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-10-29 11:44 ` [OE-core] " Bruce Ashfield
2020-10-30 12:30 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1642C502B17F26A6.28917@lists.openembedded.org>
2020-11-09 9:53 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1645CE4049F0E4CD.31324@lists.openembedded.org>
2020-11-16 15:14 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-11-16 15:23 ` Bruce Ashfield
2020-11-16 15:29 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.