From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
SELinux <selinux@tycho.nsa.gov>, Paul Moore <paul@paul-moore.com>
Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label
Date: Thu, 18 Jun 2015 17:42:20 +0100 [thread overview]
Message-ID: <1605.1434645740@warthog.procyon.org.uk> (raw)
In-Reply-To: <5582F307.6030005@tycho.nsa.gov>
Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > + rc = selinux_determine_inode_label(d_inode(dentry), name,
>
> Hmmm...previously we were using d_backing_inode(dentry->d_parent) here.
I also think this should probably be d_inode() not d_backing_inode() since
we're being called by the filesystem that owns the dentry being contemplated.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
dhowells@redhat.com, linux-security-module@vger.kernel.org,
SELinux <selinux@tycho.nsa.gov>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] SELinux: Create a common helper to determine an inode label
Date: Thu, 18 Jun 2015 17:42:20 +0100 [thread overview]
Message-ID: <1605.1434645740@warthog.procyon.org.uk> (raw)
In-Reply-To: <5582F307.6030005@tycho.nsa.gov>
Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > + rc = selinux_determine_inode_label(d_inode(dentry), name,
>
> Hmmm...previously we were using d_backing_inode(dentry->d_parent) here.
I also think this should probably be d_inode() not d_backing_inode() since
we're being called by the filesystem that owns the dentry being contemplated.
David
next prev parent reply other threads:[~2015-06-18 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:19 [PATCH] SELinux: Create a common helper to determine an inode label David Howells
2015-06-18 16:19 ` David Howells
2015-06-18 16:34 ` Stephen Smalley
2015-06-18 16:34 ` Stephen Smalley
2015-06-18 16:39 ` David Howells
2015-06-18 16:39 ` David Howells
2015-06-18 16:42 ` David Howells [this message]
2015-06-18 16:42 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605.1434645740@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.