* [PATCH bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test
@ 2020-11-11 23:12 Andrii Nakryiko
2020-11-12 17:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Andrii Nakryiko @ 2020-11-11 23:12 UTC (permalink / raw)
To: bpf, netdev, ast, daniel; +Cc: andrii, kernel-team
Correct attribute name is "unused". maybe_unused is a C++17 addition.
This patch fixes compilation warning during selftests compilation.
Fixes: 197afc631413 ("libbpf: Don't attempt to load unused subprog as an entry-point BPF program")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
tools/testing/selftests/bpf/progs/test_subprogs_unused.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/test_subprogs_unused.c b/tools/testing/selftests/bpf/progs/test_subprogs_unused.c
index 75d975f8cf90..bc49e050d342 100644
--- a/tools/testing/selftests/bpf/progs/test_subprogs_unused.c
+++ b/tools/testing/selftests/bpf/progs/test_subprogs_unused.c
@@ -4,12 +4,12 @@
const char LICENSE[] SEC("license") = "GPL";
-__attribute__((maybe_unused)) __noinline int unused1(int x)
+__attribute__((unused)) __noinline int unused1(int x)
{
return x + 1;
}
-static __attribute__((maybe_unused)) __noinline int unused2(int x)
+static __attribute__((unused)) __noinline int unused2(int x)
{
return x + 2;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test
2020-11-11 23:12 [PATCH bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test Andrii Nakryiko
@ 2020-11-12 17:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-12 17:20 UTC (permalink / raw)
To: Andrii Nakryiko; +Cc: bpf, netdev, ast, daniel, kernel-team
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 11 Nov 2020 15:12:15 -0800 you wrote:
> Correct attribute name is "unused". maybe_unused is a C++17 addition.
> This patch fixes compilation warning during selftests compilation.
>
> Fixes: 197afc631413 ("libbpf: Don't attempt to load unused subprog as an entry-point BPF program")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
> tools/testing/selftests/bpf/progs/test_subprogs_unused.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test
https://git.kernel.org/bpf/bpf/c/fd63729cc0a6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 23:12 [PATCH bpf] selftests/bpf: fix unused attribute usage in subprogs_unused test Andrii Nakryiko
2020-11-12 17:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.