* [PATCH] rtlwifi: rtl8192de: remove the useless value assignment
@ 2020-11-14 5:45 xiakaixu1987
2020-11-24 15:02 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-11-14 5:45 UTC (permalink / raw)
To: pkshih; +Cc: linux-wireless, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The variable u4tmp is overwritten by the following call and the assignment
is useless, so remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index e34d33e73e52..68ec009ea157 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -2566,7 +2566,7 @@ static void _rtl92d_phy_lc_calibrate_sw(struct ieee80211_hw *hw, bool is2t)
}
RTPRINT(rtlpriv, FINIT, INIT_IQK,
"PHY_LCK finish delay for %d ms=2\n", timecount);
- u4tmp = rtl_get_rfreg(hw, index, RF_SYN_G4, RFREG_OFFSET_MASK);
+ rtl_get_rfreg(hw, index, RF_SYN_G4, RFREG_OFFSET_MASK);
if (index == 0 && rtlhal->interfaceindex == 0) {
RTPRINT(rtlpriv, FINIT, INIT_IQK,
"path-A / 5G LCK\n");
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: remove the useless value assignment
2020-11-14 5:45 [PATCH] rtlwifi: rtl8192de: remove the useless value assignment xiakaixu1987
@ 2020-11-24 15:02 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-11-24 15:02 UTC (permalink / raw)
To: xiakaixu1987; +Cc: pkshih, linux-wireless, linux-kernel, Kaixu Xia
xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The variable u4tmp is overwritten by the following call and the assignment
> is useless, so remove it.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Patch applied to wireless-drivers-next.git, thanks.
0409d504aa6c rtlwifi: rtl8192de: remove the useless value assignment
--
https://patchwork.kernel.org/project/linux-wireless/patch/1605332735-9648-1-git-send-email-kaixuxia@tencent.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-24 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-14 5:45 [PATCH] rtlwifi: rtl8192de: remove the useless value assignment xiakaixu1987
2020-11-24 15:02 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.