* [PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test()
@ 2020-11-16 10:16 Wang Hai
2020-11-16 21:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-11-16 10:16 UTC (permalink / raw)
To: shuah, ast, daniel, kafai, songliubraving, yhs, andrii,
john.fastabend, kpsingh, sdf
Cc: linux-kselftest, netdev, bpf, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 65b4414a05eb ("selftests/bpf: add sockopt test that exercises BPF_F_ALLOW_MULTI")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
tools/testing/selftests/bpf/prog_tests/sockopt_multi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_multi.c b/tools/testing/selftests/bpf/prog_tests/sockopt_multi.c
index 29188d6f5c8d..51fac975b316 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_multi.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_multi.c
@@ -138,7 +138,8 @@ static int run_getsockopt_test(struct bpf_object *obj, int cg_parent,
*/
buf = 0x40;
- if (setsockopt(sock_fd, SOL_IP, IP_TOS, &buf, 1) < 0) {
+ err = setsockopt(sock_fd, SOL_IP, IP_TOS, &buf, 1);
+ if (err < 0) {
log_err("Failed to call setsockopt(IP_TOS)");
goto detach;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test()
2020-11-16 10:16 [PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test() Wang Hai
@ 2020-11-16 21:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-16 21:30 UTC (permalink / raw)
To: Wang Hai
Cc: shuah, ast, daniel, kafai, songliubraving, yhs, andrii,
john.fastabend, kpsingh, sdf, linux-kselftest, netdev, bpf,
linux-kernel
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Mon, 16 Nov 2020 18:16:33 +0800 you wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 65b4414a05eb ("selftests/bpf: add sockopt test that exercises BPF_F_ALLOW_MULTI")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>
> [...]
Here is the summary with links:
- [bpf] selftests/bpf: fix error return code in run_getsockopt_test()
https://git.kernel.org/bpf/bpf/c/2acc3c1bc8e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 10:16 [PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test() Wang Hai
2020-11-16 21:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.