[PATCH 0/3] smartpqi updates

[PATCH 0/3] smartpqi updates

[Don Brace]

These patches are based on Linus's tree

This small set of changes consist of two minor bug fixes:
  * Remove an unbalanced call to pqi_ctrl_unbusy in the smp
    handler. There is not a call to pqi_ctrl_busy.
  * Correct driver rmmod hang when using HBA disks with
    write cache enabled. During removal, SCSI SYNCHRONIZE CACHE
    requests are blocked with SCSI_MLQUEUE_HOST_BUSY which cause
    the hang.
Also included is a version change.

---

Don Brace (3):
      smartpqi: correct driver removal with HBA disks
      smartpqi: correct pqi_sas_smp_handler busy condition
      smartpqi: update version to 1.2.16-012


 drivers/scsi/smartpqi/smartpqi_init.c          | 4 ++--
 drivers/scsi/smartpqi/smartpqi_sas_transport.c | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

--
Signature

[PATCH 1/3] smartpqi: correct driver removal with HBA disks

[Don Brace]

From: Don Brace <dbrace@redhat.com>

* Correct rmmod hangs when using HBA disks with
  write cache enabled.
  Do not set controller flag "in_shutdown" during rmmod.
    * SCSI SYNCHRONIZE CACHE(10) and SCSI SYNCHRONIZE CACHE(16)
      requests were blocked with SCSI_MLQUEUE_HOST_BUSY.

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 9d0229656681..531f10853f03 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -345,10 +345,9 @@ static inline void pqi_device_remove_start(struct pqi_scsi_dev *device)
 	device->in_remove = true;
 }
 
-static inline bool pqi_device_in_remove(struct pqi_ctrl_info *ctrl_info,
-					struct pqi_scsi_dev *device)
+static inline bool pqi_device_in_remove(struct pqi_scsi_dev *device)
 {
-	return device->in_remove && !ctrl_info->in_shutdown;
+	return device->in_remove;
 }
 
 static inline void pqi_ctrl_shutdown_start(struct pqi_ctrl_info *ctrl_info)
@@ -5347,8 +5346,7 @@ static int pqi_scsi_queue_command(struct Scsi_Host *shost,
 
 	atomic_inc(&device->scsi_cmds_outstanding);
 
-	if (pqi_ctrl_offline(ctrl_info) || pqi_device_in_remove(ctrl_info,
-								device)) {
+	if (pqi_ctrl_offline(ctrl_info) || pqi_device_in_remove(device)) {
 		set_host_byte(scmd, DID_NO_CONNECT);
 		pqi_scsi_done(scmd);
 		return 0;
@@ -8031,8 +8029,6 @@ static void pqi_pci_remove(struct pci_dev *pci_dev)
 	if (!ctrl_info)
 		return;
 
-	ctrl_info->in_shutdown = true;
-
 	pqi_remove_ctrl(ctrl_info);
 }
 

[PATCH 2/3] smartpqi: correct pqi_sas_smp_handler busy condition

[Don Brace]

* Remove unbalanced call to pqi_ctrl_unbusy.

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_sas_transport.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c b/drivers/scsi/smartpqi/smartpqi_sas_transport.c
index 999870eb9ed8..c9b00b3368d7 100644
--- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c
+++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c
@@ -549,7 +549,6 @@ void pqi_sas_smp_handler(struct bsg_job *job, struct Scsi_Host *shost,
 	reslen = pqi_build_sas_smp_handler_reply(smp_buf, job, &error_info);
 out:
 	bsg_job_done(job, rc, reslen);
-	pqi_ctrl_unbusy(ctrl_info);
 }
 struct sas_function_template pqi_sas_transport_functions = {
 	.get_linkerrors = pqi_sas_get_linkerrors,

[PATCH 3/3] smartpqi: update version to 1.2.16-012

[Don Brace]

Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Gerry Morong <gerry.morong@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
 drivers/scsi/smartpqi/smartpqi_init.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index 531f10853f03..c53f456fbd09 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -33,11 +33,11 @@
 #define BUILD_TIMESTAMP
 #endif
 
-#define DRIVER_VERSION		"1.2.16-010"
+#define DRIVER_VERSION		"1.2.16-012"
 #define DRIVER_MAJOR		1
 #define DRIVER_MINOR		2
 #define DRIVER_RELEASE		16
-#define DRIVER_REVISION		10
+#define DRIVER_REVISION		12
 
 #define DRIVER_NAME		"Microsemi PQI Driver (v" \
 				DRIVER_VERSION BUILD_TIMESTAMP ")"

Re: [PATCH 0/3] smartpqi updates

[Martin K. Petersen]

Don,

> This small set of changes consist of two minor bug fixes:
>   * Remove an unbalanced call to pqi_ctrl_unbusy in the smp
>     handler. There is not a call to pqi_ctrl_busy.
>   * Correct driver rmmod hang when using HBA disks with
>     write cache enabled. During removal, SCSI SYNCHRONIZE CACHE
>     requests are blocked with SCSI_MLQUEUE_HOST_BUSY which cause
>     the hang.

Applied to 5.11/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/3] smartpqi updates

[Martin K. Petersen]

On Wed, 11 Nov 2020 14:24:33 -0600, Don Brace wrote:

> These patches are based on Linus's tree
> 
> This small set of changes consist of two minor bug fixes:
>   * Remove an unbalanced call to pqi_ctrl_unbusy in the smp
>     handler. There is not a call to pqi_ctrl_busy.
>   * Correct driver rmmod hang when using HBA disks with
>     write cache enabled. During removal, SCSI SYNCHRONIZE CACHE
>     requests are blocked with SCSI_MLQUEUE_HOST_BUSY which cause
>     the hang.
> Also included is a version change.

Applied to 5.11/scsi-queue, thanks!

[1/3] scsi: smartpqi: Correct driver removal with HBA disks
      https://git.kernel.org/mkp/scsi/c/1bdf6e934387
[2/3] scsi: smartpqi: Correct pqi_sas_smp_handler busy condition
      https://git.kernel.org/mkp/scsi/c/408bdd7e5845
[3/3] scsi: smartpqi: Update version to 1.2.16-012
      https://git.kernel.org/mkp/scsi/c/5443bdc4cc77

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/3] smartpqi updates

[Martin K. Petersen]

Don,

> The only functional change to smartpqi is correction of a race
> condition during a scan/rescan operation. The device->rescan flag can
> be updated by multiple threads causing issues.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH 0/3] smartpqi updates

[Don Brace]

These patches are based on Martin Petersen's 6.8/scsi-queue tree
  https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
  6.8/scsi-queue

The only functional change to smartpqi is correction of a race condition
during a scan/rescan operation. The device->rescan flag can be updated
by multiple threads causing issues.

The other two patches add PCI-IDs for new controllers and change the
driver version.

This set of changes consists of:
* smartpqi-Add-new-controller-PCI-IDs
  No functional changes. Just adding in more device support.
* smartpqi: fix logical volume rescan race condition
  The driver has several threads that can contend for accessing
  a controller instance wide 'rescan' flag. In some rare cases
  a race condition can occur that bypasses a call to rescan for
  device changes. Some of these changes are; device removal, logical
  volume changes, and device adds. We basically added a spin-lock
  to protect the 'rescan' flag.
* smartpqi-change-driver-version-to-2.1.26-030
  No functional changes.

---

David Strahan (1):
  smartpqi: Add new controller PCI IDs

Don Brace (1):
  smartpqi: bump driver version to 2.1.26-030

Mahesh Rajashekhara (1):
  smartpqi: fix logical volume rescan race condition

 drivers/scsi/smartpqi/smartpqi.h      |  1 -
 drivers/scsi/smartpqi/smartpqi_init.c | 89 ++++++++++++++++++++++++---
 2 files changed, 79 insertions(+), 11 deletions(-)

-- 
2.43.0.76.g1a87c842ec

Re: [PATCH 0/3] smartpqi updates

[Martin K. Petersen]

Don,

> These patches are based on Linus's tree
>
> The changes are:
>  - update list of controllers
>  - cleanup warning message
>  - change driver version to 1.1.2-126

Applied to 4.15/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[PATCH 0/3] smartpqi updates

[Don Brace]

These patches are based on Linus's tree

The changes are:
 - update list of controllers
 - cleanup warning message
 - change driver version to 1.1.2-126
---

Don Brace (1):
      smartpqi: update driver version to 1.1.2-126

Kevin Barnett (2):
      smartpqi: update controller ids
      smartpqi: cleanup raid map warning message


 drivers/scsi/smartpqi/smartpqi_init.c |   18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

--
Signature