All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
@ 2020-11-14  0:47 Eric Biggers
  2020-11-17  4:37 ` Martin K. Petersen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Eric Biggers @ 2020-11-14  0:47 UTC (permalink / raw)
  To: linux-scsi; +Cc: linux-arm-msm, Satya Tangirala

From: Eric Biggers <ebiggers@google.com>

QCOM_SCM is only needed to make the qcom_scm_*() calls in
ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 drivers/scsi/ufs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index dcdb4eb1f90ba..3f6dfed4fe84b 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -99,7 +99,7 @@ config SCSI_UFS_DWC_TC_PLATFORM
 config SCSI_UFS_QCOM
 	tristate "QCOM specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
-	select QCOM_SCM
+	select QCOM_SCM if SCSI_UFS_CRYPTO
 	select RESET_CONTROLLER
 	help
 	  This selects the QCOM specific additions to UFSHCD platform driver.
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
  2020-11-14  0:47 [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO Eric Biggers
@ 2020-11-17  4:37 ` Martin K. Petersen
  2020-11-20  3:29 ` Martin K. Petersen
  2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-17  4:37 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-scsi, linux-arm-msm, Satya Tangirala


Eric,

> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So
> don't unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Applied to 5.11/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
  2020-11-14  0:47 [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO Eric Biggers
  2020-11-17  4:37 ` Martin K. Petersen
@ 2020-11-20  3:29 ` Martin K. Petersen
  2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-20  3:29 UTC (permalink / raw)
  To: Eric Biggers, linux-scsi
  Cc: Martin K . Petersen, linux-arm-msm, Satya Tangirala

On Fri, 13 Nov 2020 16:47:54 -0800, Eric Biggers wrote:

> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
> unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: ufs-qcom: Only select QCOM_SCM if SCSI_UFS_CRYPTO
      https://git.kernel.org/mkp/scsi/c/6ac63216a7af

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
  2020-11-14  0:47 [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO Eric Biggers
  2020-11-17  4:37 ` Martin K. Petersen
  2020-11-20  3:29 ` Martin K. Petersen
@ 2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2020-12-29 20:15 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-arm-msm

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Fri, 13 Nov 2020 16:47:54 -0800 you wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> QCOM_SCM is only needed to make the qcom_scm_*() calls in
> ufs-qcom-ice.c, which is only compiled when SCSI_UFS_CRYPTO=y.  So don't
> unnecessarily enable QCOM_SCM when SCSI_UFS_CRYPTO=n.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> [...]

Here is the summary with links:
  - scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO
    https://git.kernel.org/qcom/c/6ac63216a7af

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-29 20:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-14  0:47 [PATCH] scsi: ufs-qcom: only select QCOM_SCM if SCSI_UFS_CRYPTO Eric Biggers
2020-11-17  4:37 ` Martin K. Petersen
2020-11-20  3:29 ` Martin K. Petersen
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.