* [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled
@ 2020-11-20 19:57 José Roberto de Souza
2020-11-20 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: José Roberto de Souza @ 2020-11-20 19:57 UTC (permalink / raw)
To: intel-gfx
Right now we are only explicitly handling the backlight of types
INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE, INTEL_BACKLIGHT_DSI_DCS and
INTEL_BACKLIGHT_DISPLAY_DDI all others are being handled as
INTEL_BACKLIGHT_DISPLAY_DDI(south display engine PWM) but that
might not be the intended HW usage, so lets warn to identify those
systems and implement it properly if needed.
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_panel.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 9f23bac0d792..368722536462 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -2023,6 +2023,21 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
struct intel_connector *connector =
container_of(panel, struct intel_connector, panel);
struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+ enum intel_backlight_type type = dev_priv->vbt.backlight.type;
+
+ if (dev_priv->params.enable_dpcd_backlight)
+ type = INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE;
+
+ drm_dbg_kms(&dev_priv->drm,
+ "Connector %s backlight type %u controller %u\n",
+ connector->base.name, type,
+ dev_priv->vbt.backlight.controller);
+
+ if (type != INTEL_BACKLIGHT_DISPLAY_DDI &&
+ type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
+ type != INTEL_BACKLIGHT_DSI_DCS)
+ drm_warn(&dev_priv->drm, "Backlight type %i not properly handled\n",
+ type);
if (connector->base.connector_type == DRM_MODE_CONNECTOR_eDP &&
intel_dp_aux_init_backlight_funcs(connector) == 0)
--
2.29.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Warn about types of backlight not handled
2020-11-20 19:57 [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled José Roberto de Souza
@ 2020-11-20 20:56 ` Patchwork
2020-11-21 0:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-11-25 19:05 ` [Intel-gfx] [PATCH] " Imre Deak
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-11-20 20:56 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4089 bytes --]
== Series Details ==
Series: drm/i915/display: Warn about types of backlight not handled
URL : https://patchwork.freedesktop.org/series/84125/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9373 -> Patchwork_18953
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/index.html
New tests
---------
New tests have been introduced between CI_DRM_9373 and Patchwork_18953:
### New CI tests (1) ###
* boot:
- Statuses : 40 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18953 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([i915#2540])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-blb-e6850/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-blb-e6850/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-icl-u2/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-icl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-skl-lmem: [DMESG-WARN][7] ([i915#2605]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-bsw-kefka: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-bsw-kefka/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-bsw-kefka/igt@i915_module_load@reload.html
* igt@i915_selftest@live@execlists:
- fi-kbl-guc: [INCOMPLETE][11] ([i915#1037] / [i915#794]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/fi-kbl-guc/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/fi-kbl-guc/igt@i915_selftest@live@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2540]: https://gitlab.freedesktop.org/drm/intel/issues/2540
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
Participating hosts (45 -> 40)
------------------------------
Additional (1): fi-tgl-y
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9373 -> Patchwork_18953
CI-20190529: 20190529
CI_DRM_9373: 9cdf0261b50968252f7775f0de5d34ab8f8b4892 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5864: afc0e559615b791d229ba977f792d04de13a37f7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18953: 4f6b5a7cfc45ad8d923cbeba0e1ad7579ac7e47b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4f6b5a7cfc45 drm/i915/display: Warn about types of backlight not handled
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/index.html
[-- Attachment #1.2: Type: text/html, Size: 5015 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Warn about types of backlight not handled
2020-11-20 19:57 [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled José Roberto de Souza
2020-11-20 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-11-21 0:45 ` Patchwork
2020-11-25 19:05 ` [Intel-gfx] [PATCH] " Imre Deak
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-11-21 0:45 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18324 bytes --]
== Series Details ==
Series: drm/i915/display: Warn about types of backlight not handled
URL : https://patchwork.freedesktop.org/series/84125/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9373_full -> Patchwork_18953_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_9373_full and Patchwork_18953_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18953_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-tglb1/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb7/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_gttfill@engines@rcs0:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-glk7/igt@gem_exec_gttfill@engines@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-glk8/igt@gem_exec_gttfill@engines@rcs0.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([i915#1436] / [i915#716])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl7/igt@gen9_exec_parse@allowed-all.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl2/igt@gen9_exec_parse@allowed-all.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#54]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl1/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl3/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][11] -> [FAIL][12] ([i915#2370])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#198])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][19] -> [DMESG-FAIL][20] ([fdo#108145] / [i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-b:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#1635] / [i915#1982]) +5 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-apl2/igt@kms_universal_plane@universal-plane-gen9-features-pipe-b.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-apl7/igt@kms_universal_plane@universal-plane-gen9-features-pipe-b.html
* igt@kms_vblank@pipe-c-query-busy:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-kbl6/igt@kms_vblank@pipe-c-query-busy.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-kbl1/igt@kms_vblank@pipe-c-query-busy.html
- shard-iclb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb4/igt@kms_vblank@pipe-c-query-busy.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb5/igt@kms_vblank@pipe-c-query-busy.html
* igt@perf@blocking:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#1542]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl3/igt@perf@blocking.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl1/igt@perf@blocking.html
* igt@perf_pmu@module-unload:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#1635] / [i915#1982] / [i915#262])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-apl8/igt@perf_pmu@module-unload.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-apl4/igt@perf_pmu@module-unload.html
- shard-skl: [PASS][33] -> [DMESG-WARN][34] ([i915#1982] / [i915#262])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl1/igt@perf_pmu@module-unload.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl6/igt@perf_pmu@module-unload.html
* igt@prime_vgem@sync@rcs0:
- shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([i915#409])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-tglb8/igt@prime_vgem@sync@rcs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb7/igt@prime_vgem@sync@rcs0.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][37] ([i915#658]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb7/igt@feature_discovery@psr2.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][39] ([i915#2190]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb8/igt@gem_huc_copy@huc-copy.html
* igt@i915_module_load@reload:
- shard-skl: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl3/igt@i915_module_load@reload.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl7/igt@i915_module_load@reload.html
* {igt@kms_async_flips@test-time-stamp}:
- shard-tglb: [FAIL][43] ([i915#2597]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-tglb7/igt@kms_async_flips@test-time-stamp.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb7/igt@kms_async_flips@test-time-stamp.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [FAIL][45] ([i915#54]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge:
- shard-apl: [DMESG-WARN][47] ([i915#1635] / [i915#1982]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-apl7/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-apl1/igt@kms_cursor_edge_walk@pipe-b-256x256-top-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][49] ([i915#2346]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-glk: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-glk1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-glk9/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip@plain-flip-ts-check@a-dp1:
- shard-kbl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-kbl3/igt@kms_flip@plain-flip-ts-check@a-dp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-kbl3/igt@kms_flip@plain-flip-ts-check@a-dp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-iclb: [INCOMPLETE][57] ([i915#1185] / [i915#123]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][59] ([fdo#108145] / [i915#265]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: [INCOMPLETE][63] ([i915#155]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-query-busy:
- shard-hsw: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-hsw6/igt@kms_vblank@pipe-c-query-busy.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-hsw1/igt@kms_vblank@pipe-c-query-busy.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][67] ([i915#198] / [i915#2405]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][69] ([i915#588]) -> [SKIP][70] ([i915#658])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [DMESG-FAIL][72] ([i915#1982]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][73] ([fdo#109349]) -> [DMESG-WARN][74] ([i915#1226])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@runner@aborted:
- shard-tglb: [FAIL][75] ([i915#2295]) -> ([FAIL][76], [FAIL][77]) ([i915#2295] / [i915#2426] / [i915#409])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-tglb8/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb5/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-tglb7/igt@runner@aborted.html
- shard-skl: [FAIL][78] ([i915#2295]) -> ([FAIL][79], [FAIL][80]) ([i915#1436] / [i915#2295] / [i915#483])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9373/shard-skl1/igt@runner@aborted.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl2/igt@runner@aborted.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/shard-skl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9373 -> Patchwork_18953
CI-20190529: 20190529
CI_DRM_9373: 9cdf0261b50968252f7775f0de5d34ab8f8b4892 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5864: afc0e559615b791d229ba977f792d04de13a37f7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18953: 4f6b5a7cfc45ad8d923cbeba0e1ad7579ac7e47b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18953/index.html
[-- Attachment #1.2: Type: text/html, Size: 21690 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled
2020-11-20 19:57 [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled José Roberto de Souza
2020-11-20 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-21 0:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-11-25 19:05 ` Imre Deak
2020-11-26 14:09 ` Jani Nikula
2 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2020-11-25 19:05 UTC (permalink / raw)
To: José Roberto de Souza, Jani Nikula; +Cc: intel-gfx
On Fri, Nov 20, 2020 at 11:57:48AM -0800, José Roberto de Souza wrote:
> Right now we are only explicitly handling the backlight of types
> INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE, INTEL_BACKLIGHT_DSI_DCS and
> INTEL_BACKLIGHT_DISPLAY_DDI all others are being handled as
> INTEL_BACKLIGHT_DISPLAY_DDI(south display engine PWM) but that
> might not be the intended HW usage, so lets warn to identify those
> systems and implement it properly if needed.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index 9f23bac0d792..368722536462 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -2023,6 +2023,21 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
> struct intel_connector *connector =
> container_of(panel, struct intel_connector, panel);
> struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
> + enum intel_backlight_type type = dev_priv->vbt.backlight.type;
> +
> + if (dev_priv->params.enable_dpcd_backlight)
> + type = INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE;
> +
> + drm_dbg_kms(&dev_priv->drm,
> + "Connector %s backlight type %u controller %u\n",
> + connector->base.name, type,
> + dev_priv->vbt.backlight.controller);
> +
> + if (type != INTEL_BACKLIGHT_DISPLAY_DDI &&
> + type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
> + type != INTEL_BACKLIGHT_DSI_DCS)
> + drm_warn(&dev_priv->drm, "Backlight type %i not properly handled\n",
> + type);
Not sure about the history/current state of VBT errors wrt. the
backlight type and so this may generate a lot of bug reports without an
actual problem. A backlight problem would be anyway visible, so
we'd get a report and then we could just use the previous debug print
you added. It could be added to the relevant debug print in
intel_panel_setup_backlight().
+Jani.
>
> if (connector->base.connector_type == DRM_MODE_CONNECTOR_eDP &&
> intel_dp_aux_init_backlight_funcs(connector) == 0)
> --
> 2.29.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled
2020-11-25 19:05 ` [Intel-gfx] [PATCH] " Imre Deak
@ 2020-11-26 14:09 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2020-11-26 14:09 UTC (permalink / raw)
To: imre.deak, José Roberto de Souza; +Cc: intel-gfx
On Wed, 25 Nov 2020, Imre Deak <imre.deak@intel.com> wrote:
> On Fri, Nov 20, 2020 at 11:57:48AM -0800, José Roberto de Souza wrote:
>> Right now we are only explicitly handling the backlight of types
>> INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE, INTEL_BACKLIGHT_DSI_DCS and
>> INTEL_BACKLIGHT_DISPLAY_DDI all others are being handled as
>> INTEL_BACKLIGHT_DISPLAY_DDI(south display engine PWM) but that
>> might not be the intended HW usage, so lets warn to identify those
>> systems and implement it properly if needed.
>>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_panel.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
>> index 9f23bac0d792..368722536462 100644
>> --- a/drivers/gpu/drm/i915/display/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
>> @@ -2023,6 +2023,21 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
>> struct intel_connector *connector =
>> container_of(panel, struct intel_connector, panel);
>> struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
>> + enum intel_backlight_type type = dev_priv->vbt.backlight.type;
>> +
>> + if (dev_priv->params.enable_dpcd_backlight)
>> + type = INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE;
The default is -1, so this might screw up the init.
>> +
>> + drm_dbg_kms(&dev_priv->drm,
>> + "Connector %s backlight type %u controller %u\n",
>> + connector->base.name, type,
>> + dev_priv->vbt.backlight.controller);
>> +
>> + if (type != INTEL_BACKLIGHT_DISPLAY_DDI &&
>> + type != INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
>> + type != INTEL_BACKLIGHT_DSI_DCS)
>> + drm_warn(&dev_priv->drm, "Backlight type %i not properly handled\n",
>> + type);
>
> Not sure about the history/current state of VBT errors wrt. the
> backlight type and so this may generate a lot of bug reports without an
> actual problem. A backlight problem would be anyway visible, so
> we'd get a report and then we could just use the previous debug print
> you added. It could be added to the relevant debug print in
> intel_panel_setup_backlight().
I think I'd settle for a debug print too.
BR,
Jani.
>
> +Jani.
>
>>
>> if (connector->base.connector_type == DRM_MODE_CONNECTOR_eDP &&
>> intel_dp_aux_init_backlight_funcs(connector) == 0)
>> --
>> 2.29.2
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-26 14:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 19:57 [Intel-gfx] [PATCH] drm/i915/display: Warn about types of backlight not handled José Roberto de Souza
2020-11-20 20:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-21 0:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-11-25 19:05 ` [Intel-gfx] [PATCH] " Imre Deak
2020-11-26 14:09 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.