All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Huang, Sean Z" <sean.z.huang@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce Intel PXP component
Date: Sat, 21 Nov 2020 00:55:51 -0000	[thread overview]
Message-ID: <160592015191.8550.11862005583810649271@emeril.freedesktop.org> (raw)
In-Reply-To: <20201121003540.24980-1-sean.z.huang@intel.com>

== Series Details ==

Series: Introduce Intel PXP component
URL   : https://patchwork.freedesktop.org/series/84136/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
66b76da7fe5d drm/i915/pxp: Introduce Intel PXP component
-:78: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 82 lines checked
7df24529d3bb drm/i915/pxp: Enable PXP irq worker and callback stub
a901ec3e7f21 drm/i915/pxp: Add PXP context for logical hardware states.
-:103: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#103: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 162 lines checked
d4b812189d1a drm/i915/pxp: set KCR reg init during the boot time
-:67: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#67: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 100 lines checked
988e5cd6442d drm/i915/pxp: Implement ioctl action to set the user space context
-:108: WARNING:PREFER_PACKED: __packed is preferred over __attribute__((packed))
#108: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.h:40:
+} __attribute__((packed));

total: 0 errors, 1 warnings, 0 checks, 135 lines checked
0a0399386f35 drm/i915/pxp: Add PXP-related registers into allowlist
30b4635f97f3 drm/i915/pxp: Read register to check hardware session state
-:19: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects?
#19: FILE: drivers/gpu/drm/i915/pxp/intel_pxp.h:15:
+#define pxp_session_list(i915, session_type) (((session_type) == SESSION_TYPE_TYPE0) ? \
+	&(i915)->pxp.ctx->active_pxp_type0_sessions : &(i915)->pxp.ctx->active_pxp_type1_sessions)

total: 0 errors, 0 warnings, 1 checks, 255 lines checked
73fd2ab098a8 drm/i915/pxp: Implement funcs to get/set PXP tag
51b583b84185 drm/i915/pxp: Implement ioctl action to reserve session slot
815493587215 drm/i915/pxp: Implement ioctl action to set session in play
494076c52cd8 drm/i915/pxp: Func to send hardware session termination
9f49e0a6312c drm/i915/pxp: Implement ioctl action to terminate the session
8e1b6914f853 drm/i915/pxp: Enable ioctl action to query PXP tag
118c80a692a7 drm/i915/pxp: Destroy all type0 sessions upon teardown
8080d375bd2a drm/i915/pxp: Termiante the session upon app crash
9f5a2c10293e drm/i915/pxp: Enable PXP power management
-:69: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 129 lines checked
e12ec2580683 drm/i915/pxp: Implement funcs to create the TEE channel
-:85: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 242 lines checked
8fd3a79e52de drm/i915/pxp: Implement ioctl action to send TEE commands
cf85826129cb drm/i915/pxp: Create the arbitrary session after boot
328cdbf8a20f drm/i915/pxp: Add i915 trace logs for PXP operations
-:11: WARNING:TYPO_SPELLING: 'trun' may be misspelled - perhaps 'turn'?
#11: 
To trun on this feature, we need to set

-:29: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#29: FILE: drivers/gpu/drm/i915/i915_trace.h:1038:
+	    TP_STRUCT__entry(

-:36: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#36: FILE: drivers/gpu/drm/i915/i915_trace.h:1045:
+	    TP_fast_assign(

total: 0 errors, 1 warnings, 2 checks, 80 lines checked
a0f54901f637 drm/i915/pxp: Expose session state for display protection flip
dd4a59bc3c5e mei: pxp: export pavp client to me client bus
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 277 lines checked
2c36a9443162 drm/i915/uapi: introduce drm_i915_gem_create_ext
-:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Joonas Lahtinen joonas.lahtinen@linux.intel.com'
#12: 
Cc: Joonas Lahtinen joonas.lahtinen@linux.intel.com

-:13: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Matthew Auld matthew.auld@intel.com'
#13: 
Cc: Matthew Auld matthew.auld@intel.com

-:46: ERROR:CODE_INDENT: code indent should use tabs where possible
#46: FILE: drivers/gpu/drm/i915/i915_gem.c:265:
+        struct drm_i915_private *i915;$

-:46: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: drivers/gpu/drm/i915/i915_gem.c:265:
+        struct drm_i915_private *i915;$

-:50: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#50: FILE: drivers/gpu/drm/i915/i915_gem.c:269:
+static int __create_setparam(struct drm_i915_gem_object_param *args,
+							struct create_ext *ext_data)

-:95: CHECK:LINE_SPACING: Please don't use multiple blank lines
#95: FILE: drivers/gpu/drm/i915/i915_gem.c:317:
+
+

-:107: WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#107: FILE: include/uapi/drm/i915_drm.h:394:
+#define DRM_IOCTL_I915_GEM_CREATE_EXT   DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_CREATE, struct drm_i915_gem_create_ext)

-:155: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#155: FILE: include/uapi/drm/i915_drm.h:1735:
+#define I915_OBJECT_PARAM  (1ull<<32)
                                 ^

total: 3 errors, 2 warnings, 3 checks, 136 lines checked
d74f6677492c drm/i915/pxp: User interface for Protected buffer
d9c9356b3f53 drm/i915/pxp: Add plane decryption support
14de94bae551 drm/i915/pxp: Enable the PXP ioctl for protected session
-:9: WARNING:TYPO_SPELLING: 'destory' may be misspelled - perhaps 'destroy'?
#9: 
destory the protected session via this ioctl.

-:100: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#100: FILE: include/uapi/drm/i915_drm.h:427:
+#define DRM_IOCTL_I915_PXP_OPS		DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_PXP_OPS, struct drm_i915_pxp_ops)

total: 0 errors, 2 warnings, 0 checks, 154 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-11-21  0:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21  0:35 [Intel-gfx] [RFC-v2 00/26] Introduce Intel PXP component Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 01/26] drm/i915/pxp: " Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 02/26] drm/i915/pxp: Enable PXP irq worker and callback stub Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 03/26] drm/i915/pxp: Add PXP context for logical hardware states Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 04/26] drm/i915/pxp: set KCR reg init during the boot time Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 05/26] drm/i915/pxp: Implement ioctl action to set the user space context Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 06/26] drm/i915/pxp: Add PXP-related registers into allowlist Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 07/26] drm/i915/pxp: Read register to check hardware session state Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 08/26] drm/i915/pxp: Implement funcs to get/set PXP tag Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 09/26] drm/i915/pxp: Implement ioctl action to reserve session slot Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 10/26] drm/i915/pxp: Implement ioctl action to set session in play Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 11/26] drm/i915/pxp: Func to send hardware session termination Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 12/26] drm/i915/pxp: Implement ioctl action to terminate the session Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 13/26] drm/i915/pxp: Enable ioctl action to query PXP tag Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 14/26] drm/i915/pxp: Destroy all type0 sessions upon teardown Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 15/26] drm/i915/pxp: Termiante the session upon app crash Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 16/26] drm/i915/pxp: Enable PXP power management Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 17/26] drm/i915/pxp: Implement funcs to create the TEE channel Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 18/26] drm/i915/pxp: Implement ioctl action to send TEE commands Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 19/26] drm/i915/pxp: Create the arbitrary session after boot Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 20/26] drm/i915/pxp: Add i915 trace logs for PXP operations Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 21/26] drm/i915/pxp: Expose session state for display protection flip Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 22/26] mei: pxp: export pavp client to me client bus Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 23/26] drm/i915/uapi: introduce drm_i915_gem_create_ext Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 24/26] drm/i915/pxp: User interface for Protected buffer Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 25/26] drm/i915/pxp: Add plane decryption support Huang, Sean Z
2020-11-21  0:35 ` [Intel-gfx] [RFC-v2 26/26] drm/i915/pxp: Enable the PXP ioctl for protected session Huang, Sean Z
2020-11-21  0:55 ` Patchwork [this message]
2020-11-21  1:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce Intel PXP component Patchwork
2020-11-23 16:20 ` [Intel-gfx] [RFC-v2 00/26] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160592015191.8550.11862005583810649271@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sean.z.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.