* [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer
@ 2020-11-21 14:32 Chris Wilson
2020-11-21 14:46 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2020-11-21 14:32 UTC (permalink / raw)
To: igt-dev; +Cc: Chris Wilson
Hunting:
Received signal SIGSEGV.
Stack trace:
#0 [fatal_sig_handler+0xd6]
#1 [killpg+0x40]
#2 [intel_bb_add_object+0x105]
#3 [__real_main666+0xe83]
#4 [main+0x27]
#5 [__libc_start_main+0xe7]
#6 [_start+0x2a]
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/intel_batchbuffer.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 8dd8a5027..2f4e36a2f 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1190,19 +1190,18 @@ static bool intel_bb_debug_tree = false;
*/
static void __reallocate_objects(struct intel_bb *ibb)
{
- uint32_t num;
+ const uint32_t inc = 4096 / sizeof(*ibb->objects);
if (ibb->num_objects == ibb->allocated_objects) {
- num = 4096 / sizeof(*ibb->objects);
ibb->objects = realloc(ibb->objects,
sizeof(*ibb->objects) *
- (num + ibb->allocated_objects));
+ (inc + ibb->allocated_objects));
igt_assert(ibb->objects);
- ibb->allocated_objects += num;
+ ibb->allocated_objects += inc;
memset(&ibb->objects[ibb->num_objects], 0,
- num * sizeof(*ibb->objects));
+ inc * sizeof(*ibb->objects));
}
}
@@ -1592,6 +1591,8 @@ __add_to_cache(struct intel_bb *ibb, uint32_t handle)
struct drm_i915_gem_exec_object2 **found, *object;
object = malloc(sizeof(*object));
+ igt_assert(obj);
+
object->handle = handle;
found = tsearch((void *) object, &ibb->root, __compare_objects);
@@ -1615,16 +1616,18 @@ static int __compare_handles(const void *p1, const void *p2)
static void __add_to_objects(struct intel_bb *ibb,
struct drm_i915_gem_exec_object2 *object)
{
- uint32_t i, **found, *handle;
+ uint32_t **found, *handle;
handle = malloc(sizeof(*handle));
+ igt_assert(handle);
+
*handle = object->handle;
found = tsearch((void *) handle, &ibb->current, __compare_handles);
if (*found == handle) {
__reallocate_objects(ibb);
- i = ibb->num_objects++;
- ibb->objects[i] = object;
+ igt_assert(ibb->num_objects < ibb->allocated_objects);
+ ibb->objects[ibb->num_objects++] = object;
} else {
free(handle);
}
@@ -2118,7 +2121,7 @@ static int __intel_bb_exec(struct intel_bb *ibb, uint32_t end_offset,
memset(&execbuf, 0, sizeof(execbuf));
objects = create_objects_array(ibb);
- execbuf.buffers_ptr = (uintptr_t) objects;
+ execbuf.buffers_ptr = to_user_pointer(objects);
execbuf.buffer_count = ibb->num_objects;
execbuf.batch_len = end_offset;
execbuf.rsvd1 = ibb->ctx;
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for lib: Assert potential malloc failures in intel_batchbuffer
2020-11-21 14:32 [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer Chris Wilson
@ 2020-11-21 14:46 ` Patchwork
2020-11-21 14:50 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-11-21 14:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Assert potential malloc failures in intel_batchbuffer
URL : https://patchwork.freedesktop.org/series/84146/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
76b7d1ecf6a3c0a5a538146bb055d0eb5fe232d0 i915/gem_set_tiling_vs_blt: Undo accidental context insertion
ninja: Entering directory `build'
[1/422] Generating version.h with a custom command.
[2/418] Compiling C object 'lib/lib@@igt-intel_batchbuffer_c@sta/intel_batchbuffer.c.o'.
FAILED: lib/lib@@igt-intel_batchbuffer_c@sta/intel_batchbuffer.c.o
ccache cc -Ilib/lib@@igt-intel_batchbuffer_c@sta -Ilib -I../lib -I../include/drm-uapi -I../lib/stubs/syscalls -I. -I../ -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdrm -I/usr/include/x86_64-linux-gnu -I/usr/include/alsa -I/usr/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -pthread '-DIGT_DATADIR="/opt/igt/share/igt-gpu-tools"' '-DIGT_SRCDIR="/home/cidrm/igt-gpu-tools/tests"' '-DIGT_LOG_DOMAIN="intel_batchbuffer"' -MD -MQ 'lib/lib@@igt-intel_batchbuffer_c@sta/intel_batchbuffer.c.o' -MF 'lib/lib@@igt-intel_batchbuffer_c@sta/intel_batchbuffer.c.o.d' -o 'lib/lib@@igt-intel_batchbuffer_c@sta/intel_batchbuffer.c.o' -c ../lib/intel_batchbuffer.c
In file included from ../lib/drmtest.h:39,
from ../lib/intel_batchbuffer.c:37:
../lib/intel_batchbuffer.c: In function ‘__add_to_cache’:
../lib/intel_batchbuffer.c:1594:13: error: ‘obj’ undeclared (first use in this function)
igt_assert(obj);
^~~
../lib/igt_core.h:656:13: note: in definition of macro ‘igt_assert’
do { if (!(expr)) \
^~~~
../lib/intel_batchbuffer.c:1594:13: note: each undeclared identifier is reported only once for each function it appears in
igt_assert(obj);
^~~
../lib/igt_core.h:656:13: note: in definition of macro ‘igt_assert’
do { if (!(expr)) \
^~~~
ninja: build stopped: subcommand failed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer
2020-11-21 14:32 [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer Chris Wilson
2020-11-21 14:46 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2020-11-21 14:50 ` Chris Wilson
2020-11-23 5:32 ` Zbigniew Kempczyński
2020-11-21 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Assert potential malloc failures in intel_batchbuffer (rev2) Patchwork
2020-11-21 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2020-11-21 14:50 UTC (permalink / raw)
To: igt-dev; +Cc: Chris Wilson
Hunting:
Received signal SIGSEGV.
Stack trace:
#0 [fatal_sig_handler+0xd6]
#1 [killpg+0x40]
#2 [intel_bb_add_object+0x105]
#3 [__real_main666+0xe83]
#4 [main+0x27]
#5 [__libc_start_main+0xe7]
#6 [_start+0x2a]
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/intel_batchbuffer.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 8dd8a5027..48cca852f 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1190,19 +1190,18 @@ static bool intel_bb_debug_tree = false;
*/
static void __reallocate_objects(struct intel_bb *ibb)
{
- uint32_t num;
+ const uint32_t inc = 4096 / sizeof(*ibb->objects);
if (ibb->num_objects == ibb->allocated_objects) {
- num = 4096 / sizeof(*ibb->objects);
ibb->objects = realloc(ibb->objects,
sizeof(*ibb->objects) *
- (num + ibb->allocated_objects));
+ (inc + ibb->allocated_objects));
igt_assert(ibb->objects);
- ibb->allocated_objects += num;
+ ibb->allocated_objects += inc;
memset(&ibb->objects[ibb->num_objects], 0,
- num * sizeof(*ibb->objects));
+ inc * sizeof(*ibb->objects));
}
}
@@ -1592,6 +1591,8 @@ __add_to_cache(struct intel_bb *ibb, uint32_t handle)
struct drm_i915_gem_exec_object2 **found, *object;
object = malloc(sizeof(*object));
+ igt_assert(object);
+
object->handle = handle;
found = tsearch((void *) object, &ibb->root, __compare_objects);
@@ -1615,16 +1616,18 @@ static int __compare_handles(const void *p1, const void *p2)
static void __add_to_objects(struct intel_bb *ibb,
struct drm_i915_gem_exec_object2 *object)
{
- uint32_t i, **found, *handle;
+ uint32_t **found, *handle;
handle = malloc(sizeof(*handle));
+ igt_assert(handle);
+
*handle = object->handle;
found = tsearch((void *) handle, &ibb->current, __compare_handles);
if (*found == handle) {
__reallocate_objects(ibb);
- i = ibb->num_objects++;
- ibb->objects[i] = object;
+ igt_assert(ibb->num_objects < ibb->allocated_objects);
+ ibb->objects[ibb->num_objects++] = object;
} else {
free(handle);
}
@@ -2118,7 +2121,7 @@ static int __intel_bb_exec(struct intel_bb *ibb, uint32_t end_offset,
memset(&execbuf, 0, sizeof(execbuf));
objects = create_objects_array(ibb);
- execbuf.buffers_ptr = (uintptr_t) objects;
+ execbuf.buffers_ptr = to_user_pointer(objects);
execbuf.buffer_count = ibb->num_objects;
execbuf.batch_len = end_offset;
execbuf.rsvd1 = ibb->ctx;
--
2.29.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Assert potential malloc failures in intel_batchbuffer (rev2)
2020-11-21 14:32 [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer Chris Wilson
2020-11-21 14:46 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-11-21 14:50 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2020-11-21 15:46 ` Patchwork
2020-11-21 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-11-21 15:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 6206 bytes --]
== Series Details ==
Series: lib: Assert potential malloc failures in intel_batchbuffer (rev2)
URL : https://patchwork.freedesktop.org/series/84146/
State : success
== Summary ==
CI Bug Log - changes from IGT_5865 -> IGTPW_5206
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
Known issues
------------
Here are the changes found in IGTPW_5206 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] ([i915#2605])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
- fi-icl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-icl-y/igt@core_hotunplug@unbind-rebind.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-icl-y/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_suspend@basic-s3:
- fi-bsw-n3050: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3.html
* igt@gem_sync@basic-all:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-tgl-y/igt@gem_sync@basic-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-tgl-y/igt@gem_sync@basic-all.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [PASS][9] -> [DMESG-WARN][10] ([i915#203])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-u2: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
- fi-tgl-y: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-tgl-y/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-tgl-y/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-icl-u2/igt@i915_module_load@reload.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-icl-u2/igt@i915_module_load@reload.html
- fi-tgl-u2: [DMESG-WARN][19] ([i915#1982] / [k.org#205379]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-tgl-u2/igt@i915_module_load@reload.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][21] ([i915#541]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-tgl-y: [DMESG-WARN][25] ([i915#1982]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/fi-tgl-y/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/fi-tgl-y/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (46 -> 41)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5865 -> IGTPW_5206
CI-20190529: 20190529
CI_DRM_9373: 9cdf0261b50968252f7775f0de5d34ab8f8b4892 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5206: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
IGT_5865: 76b7d1ecf6a3c0a5a538146bb055d0eb5fe232d0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
[-- Attachment #1.2: Type: text/html, Size: 7657 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Assert potential malloc failures in intel_batchbuffer (rev2)
2020-11-21 14:32 [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer Chris Wilson
` (2 preceding siblings ...)
2020-11-21 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Assert potential malloc failures in intel_batchbuffer (rev2) Patchwork
@ 2020-11-21 16:54 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-11-21 16:54 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 20096 bytes --]
== Series Details ==
Series: lib: Assert potential malloc failures in intel_batchbuffer (rev2)
URL : https://patchwork.freedesktop.org/series/84146/
State : success
== Summary ==
CI Bug Log - changes from IGT_5865_full -> IGTPW_5206_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_5206_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5206_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5206_full:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- shard-hsw: [FAIL][1] ([fdo#109271] / [i915#2295]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-hsw2/igt@runner@aborted.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-hsw2/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_5206_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@i915_pm_rpm@drm-resources-equal:
- shard-kbl: [PASS][5] -> [SKIP][6] ([fdo#109271]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl3/igt@i915_pm_rpm@drm-resources-equal.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl2/igt@i915_pm_rpm@drm-resources-equal.html
- shard-hsw: [PASS][7] -> [SKIP][8] ([fdo#109271]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-hsw7/igt@i915_pm_rpm@drm-resources-equal.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-hsw2/igt@i915_pm_rpm@drm-resources-equal.html
- shard-iclb: [PASS][9] -> [SKIP][10] ([i915#579]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb6/igt@i915_pm_rpm@drm-resources-equal.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb5/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_rpm@gem-execbuf-stress:
- shard-glk: [PASS][11] -> [SKIP][12] ([fdo#109271]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk4/igt@i915_pm_rpm@gem-execbuf-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk4/igt@i915_pm_rpm@gem-execbuf-stress.html
- shard-apl: [PASS][13] -> [SKIP][14] ([fdo#109271] / [i915#1635]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl2/igt@i915_pm_rpm@gem-execbuf-stress.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl1/igt@i915_pm_rpm@gem-execbuf-stress.html
* igt@i915_suspend@forcewake:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([i915#1185]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb2/igt@i915_suspend@forcewake.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb5/igt@i915_suspend@forcewake.html
- shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([i915#155] / [i915#636])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl7/igt@i915_suspend@forcewake.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl2/igt@i915_suspend@forcewake.html
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([i915#2055] / [i915#2637])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-hsw2/igt@i915_suspend@forcewake.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-hsw2/igt@i915_suspend@forcewake.html
- shard-glk: [PASS][21] -> [INCOMPLETE][22] ([i915#2635])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk8/igt@i915_suspend@forcewake.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk1/igt@i915_suspend@forcewake.html
- shard-apl: [PASS][23] -> [INCOMPLETE][24] ([i915#1635] / [i915#2635])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl2/igt@i915_suspend@forcewake.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl2/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +7 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl1/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl6/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
* igt@kms_concurrent@pipe-b:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#78])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl2/igt@kms_concurrent@pipe-b.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl2/igt@kms_concurrent@pipe-b.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-tglb: [PASS][29] -> [FAIL][30] ([i915#2346])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#1635] / [i915#1982]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl4/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][35] -> [FAIL][36] ([i915#2598])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1:
- shard-apl: [PASS][37] -> [FAIL][38] ([i915#1635] / [i915#79])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-glk: [PASS][39] -> [FAIL][40] ([i915#49])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-iclb: [PASS][41] -> [DMESG-WARN][42] ([i915#1982]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-tiling-y.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-tiling-y.html
* igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
- shard-tglb: [PASS][43] -> [DMESG-WARN][44] ([i915#1982]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-glk: [PASS][45] -> [DMESG-WARN][46] ([i915#1982]) +6 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109642] / [fdo#111068])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb2/igt@kms_psr2_su@page_flip.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb5/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109441]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_workarounds@suspend-resume:
- shard-glk: [DMESG-WARN][51] ([i915#2635]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk7/igt@gem_workarounds@suspend-resume.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk5/igt@gem_workarounds@suspend-resume.html
- shard-iclb: [INCOMPLETE][53] ([i915#1185]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb3/igt@gem_workarounds@suspend-resume.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb2/igt@gem_workarounds@suspend-resume.html
- shard-apl: [DMESG-WARN][55] ([i915#1635] / [i915#2635]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl7/igt@gem_workarounds@suspend-resume.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl3/igt@gem_workarounds@suspend-resume.html
- shard-kbl: [INCOMPLETE][57] ([i915#155]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl4/igt@gem_workarounds@suspend-resume.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl2/igt@gem_workarounds@suspend-resume.html
- shard-hsw: [INCOMPLETE][59] ([i915#2637]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-hsw2/igt@gem_workarounds@suspend-resume.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-hsw2/igt@gem_workarounds@suspend-resume.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [INCOMPLETE][61] ([i915#1635] / [i915#2405]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl3/igt@gem_workarounds@suspend-resume-fd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl4/igt@gem_workarounds@suspend-resume-fd.html
* {igt@kms_async_flips@alternate-sync-async-flip}:
- shard-tglb: [FAIL][63] ([i915#2521]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb8/igt@kms_async_flips@alternate-sync-async-flip.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb7/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-kbl: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-kbl4/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-kbl2/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [FAIL][67] ([i915#1635] / [i915#79]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl4/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
* igt@kms_lease@page_flip_implicit_plane:
- shard-apl: [DMESG-WARN][69] ([i915#1635] / [i915#1982]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl6/igt@kms_lease@page_flip_implicit_plane.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl6/igt@kms_lease@page_flip_implicit_plane.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_rmfb@rmfb-ioctl:
- shard-glk: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk1/igt@kms_rmfb@rmfb-ioctl.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk6/igt@kms_rmfb@rmfb-ioctl.html
* igt@vgem_basic@unload:
- shard-hsw: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-hsw6/igt@vgem_basic@unload.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-hsw4/igt@vgem_basic@unload.html
#### Warnings ####
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][77] ([i915#1436] / [i915#1602] / [i915#1887] / [i915#2411] / [i915#456]) -> [DMESG-WARN][78] ([i915#2411])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb6/igt@gem_workarounds@suspend-resume.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb3/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_rpm@gem-execbuf-stress:
- shard-tglb: [DMESG-WARN][79] ([i915#2411]) -> [SKIP][80] ([i915#579]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb7/igt@i915_pm_rpm@gem-execbuf-stress.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb7/igt@i915_pm_rpm@gem-execbuf-stress.html
* igt@i915_suspend@forcewake:
- shard-tglb: [DMESG-WARN][81] ([i915#2411]) -> [DMESG-WARN][82] ([i915#1436] / [i915#1602] / [i915#1887] / [i915#2411])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-tglb6/igt@i915_suspend@forcewake.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-tglb6/igt@i915_suspend@forcewake.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [FAIL][83] ([fdo#108145] / [i915#1635] / [i915#265]) -> [DMESG-FAIL][84] ([fdo#108145] / [i915#1635] / [i915#1982])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: [DMESG-FAIL][85] ([fdo#108145] / [i915#1635] / [i915#1982]) -> [FAIL][86] ([fdo#108145] / [i915#1635] / [i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@runner@aborted:
- shard-apl: ([FAIL][87], [FAIL][88]) ([fdo#109271] / [i915#1635] / [i915#2295]) -> ([FAIL][89], [FAIL][90]) ([i915#1635] / [i915#2295])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl1/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-apl7/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl6/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-apl2/igt@runner@aborted.html
- shard-glk: ([FAIL][91], [FAIL][92]) ([i915#2295] / [i915#483] / [k.org#202321]) -> ([FAIL][93], [FAIL][94]) ([i915#2295] / [k.org#202321])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk7/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5865/shard-glk4/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk1/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/shard-glk1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#2641]: https://gitlab.freedesktop.org/drm/intel/issues/2641
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#636]: https://gitlab.freedesktop.org/drm/intel/issues/636
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5865 -> IGTPW_5206
CI-20190529: 20190529
CI_DRM_9373: 9cdf0261b50968252f7775f0de5d34ab8f8b4892 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5206: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
IGT_5865: 76b7d1ecf6a3c0a5a538146bb055d0eb5fe232d0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5206/index.html
[-- Attachment #1.2: Type: text/html, Size: 25166 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer
2020-11-21 14:50 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2020-11-23 5:32 ` Zbigniew Kempczyński
0 siblings, 0 replies; 6+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-23 5:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
On Sat, Nov 21, 2020 at 02:50:32PM +0000, Chris Wilson wrote:
> Hunting:
>
> Received signal SIGSEGV.
> Stack trace:
> #0 [fatal_sig_handler+0xd6]
> #1 [killpg+0x40]
> #2 [intel_bb_add_object+0x105]
> #3 [__real_main666+0xe83]
> #4 [main+0x27]
> #5 [__libc_start_main+0xe7]
> #6 [_start+0x2a]
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> lib/intel_batchbuffer.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 8dd8a5027..48cca852f 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -1190,19 +1190,18 @@ static bool intel_bb_debug_tree = false;
> */
> static void __reallocate_objects(struct intel_bb *ibb)
> {
> - uint32_t num;
> + const uint32_t inc = 4096 / sizeof(*ibb->objects);
>
> if (ibb->num_objects == ibb->allocated_objects) {
> - num = 4096 / sizeof(*ibb->objects);
> ibb->objects = realloc(ibb->objects,
> sizeof(*ibb->objects) *
> - (num + ibb->allocated_objects));
> + (inc + ibb->allocated_objects));
>
> igt_assert(ibb->objects);
> - ibb->allocated_objects += num;
> + ibb->allocated_objects += inc;
>
> memset(&ibb->objects[ibb->num_objects], 0,
> - num * sizeof(*ibb->objects));
> + inc * sizeof(*ibb->objects));
> }
> }
>
> @@ -1592,6 +1591,8 @@ __add_to_cache(struct intel_bb *ibb, uint32_t handle)
> struct drm_i915_gem_exec_object2 **found, *object;
>
> object = malloc(sizeof(*object));
> + igt_assert(object);
> +
> object->handle = handle;
> found = tsearch((void *) object, &ibb->root, __compare_objects);
>
> @@ -1615,16 +1616,18 @@ static int __compare_handles(const void *p1, const void *p2)
> static void __add_to_objects(struct intel_bb *ibb,
> struct drm_i915_gem_exec_object2 *object)
> {
> - uint32_t i, **found, *handle;
> + uint32_t **found, *handle;
>
> handle = malloc(sizeof(*handle));
> + igt_assert(handle);
> +
> *handle = object->handle;
> found = tsearch((void *) handle, &ibb->current, __compare_handles);
>
> if (*found == handle) {
> __reallocate_objects(ibb);
> - i = ibb->num_objects++;
> - ibb->objects[i] = object;
> + igt_assert(ibb->num_objects < ibb->allocated_objects);
> + ibb->objects[ibb->num_objects++] = object;
> } else {
> free(handle);
> }
> @@ -2118,7 +2121,7 @@ static int __intel_bb_exec(struct intel_bb *ibb, uint32_t end_offset,
>
> memset(&execbuf, 0, sizeof(execbuf));
> objects = create_objects_array(ibb);
> - execbuf.buffers_ptr = (uintptr_t) objects;
> + execbuf.buffers_ptr = to_user_pointer(objects);
> execbuf.buffer_count = ibb->num_objects;
> execbuf.batch_len = end_offset;
> execbuf.rsvd1 = ibb->ctx;
> --
> 2.29.2
Ok, maybe these asserts will answer why sometimes we got SIGSEGV.
This would be real cornercase with malloc() so lets find out is it
properly handled.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-23 5:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-21 14:32 [igt-dev] [PATCH i-g-t] lib: Assert potential malloc failures in intel_batchbuffer Chris Wilson
2020-11-21 14:46 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-11-21 14:50 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2020-11-23 5:32 ` Zbigniew Kempczyński
2020-11-21 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for lib: Assert potential malloc failures in intel_batchbuffer (rev2) Patchwork
2020-11-21 16:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.