From: Hans de Goede <hdegoede@redhat.com> To: Lucas tanure <tanureal@opensource.cirrus.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Mark Gross <markgross@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, Kailang Yang <kailang@realtek.com>, Shuming Fan <shumingf@realtek.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, David Rhodes <david.rhodes@cirrus.com>, Vitaly Rodionov <vitalyr@opensource.cirrus.com> Cc: Jeremy Szu <jeremy.szu@canonical.com>, Hui Wang <hui.wang@canonical.com>, Werner Sembach <wse@tuxedocomputers.com>, Chris Chiu <chris.chiu@canonical.com>, Cameron Berkenpas <cam@neo-zeon.de>, Sami Loone <sami@loone.fi>, Elia Devito <eliadevito@gmail.com>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Jack Yu <jack.yu@realtek.com>, Arnd Bergmann <arnd@arndb.de>, Lars-Peter Clausen <lars@metafoo.de>, Alexandre Belloni <alexandre.belloni@bootlin.com>, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, patches@opensource.cirrus.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100 ACPI nodes Date: Tue, 23 Nov 2021 19:35:55 +0100 [thread overview] Message-ID: <1605be8d-0913-4b52-32e2-8076fff01d30@redhat.com> (raw) In-Reply-To: <756f813c-cc3e-7ddf-e5db-cf6c874f907e@opensource.cirrus.com> Hi, On 11/23/21 18:11, Lucas tanure wrote: > On 11/23/21 17:05, Hans de Goede wrote: >> Hi Lucas, >> >> On 11/23/21 17:31, Lucas Tanure wrote: >>> The ACPI device with CLSA0100 is a sound card with multiple >>> instances of CS35L41. >>> >>> We add an ID to the I2C multi instantiate list to enumerate >>> all I2C slaves correctly. >>> >>> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com> >>> --- >>> drivers/acpi/scan.c | 1 + >>> drivers/platform/x86/i2c-multi-instantiate.c | 7 +++++++ >>> 2 files changed, 8 insertions(+) >>> >>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c >>> index 2c80765670bc..16827a33e93b 100644 >>> --- a/drivers/acpi/scan.c >>> +++ b/drivers/acpi/scan.c >>> @@ -1708,6 +1708,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) >>> {"BSG2150", }, >>> {"INT33FE", }, >>> {"INT3515", }, >>> + {"CLSA0100", }, >>> {} >>> }; >>> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c >>> index 4956a1df5b90..ed25a0adc656 100644 >>> --- a/drivers/platform/x86/i2c-multi-instantiate.c >>> +++ b/drivers/platform/x86/i2c-multi-instantiate.c >>> @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[] = { >>> {} >>> }; >>> +static const struct i2c_inst_data clsa0100_data[] = { >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >> >> This suggests that both amplifiers are using the same GPIO pin as shared >> IRQ, is that correct ? Can you share an acpidump of the laptop's DSDT tables ? >> >> Regards, >> >> Hans >> > > DSDT attached. > Yes, both amps share the same IRQ gpio. Thanks, this patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > >> >> >> >>> + {} >>> +}; >>> + >>> /* >>> * Note new device-ids must also be added to i2c_multi_instantiate_ids in >>> * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). >>> @@ -155,6 +161,7 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { >>> { "BSG1160", (unsigned long)bsg1160_data }, >>> { "BSG2150", (unsigned long)bsg2150_data }, >>> { "INT3515", (unsigned long)int3515_data }, >>> + { "CLSA0100", (unsigned long)clsa0100_data }, >>> { } >>> }; >>> MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); >>> >>
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Lucas tanure <tanureal@opensource.cirrus.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Mark Gross <markgross@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, Kailang Yang <kailang@realtek.com>, Shuming Fan <shumingf@realtek.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, David Rhodes <david.rhodes@cirrus.com>, Vitaly Rodionov <vitalyr@opensource.cirrus.com> Cc: Chris Chiu <chris.chiu@canonical.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Jack Yu <jack.yu@realtek.com>, Arnd Bergmann <arnd@arndb.de>, Jeremy Szu <jeremy.szu@canonical.com>, patches@opensource.cirrus.com, Elia Devito <eliadevito@gmail.com>, alsa-devel@alsa-project.org, Werner Sembach <wse@tuxedocomputers.com>, platform-driver-x86@vger.kernel.org, Hui Wang <hui.wang@canonical.com>, linux-acpi@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Sami Loone <sami@loone.fi>, Cameron Berkenpas <cam@neo-zeon.de>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100 ACPI nodes Date: Tue, 23 Nov 2021 19:35:55 +0100 [thread overview] Message-ID: <1605be8d-0913-4b52-32e2-8076fff01d30@redhat.com> (raw) In-Reply-To: <756f813c-cc3e-7ddf-e5db-cf6c874f907e@opensource.cirrus.com> Hi, On 11/23/21 18:11, Lucas tanure wrote: > On 11/23/21 17:05, Hans de Goede wrote: >> Hi Lucas, >> >> On 11/23/21 17:31, Lucas Tanure wrote: >>> The ACPI device with CLSA0100 is a sound card with multiple >>> instances of CS35L41. >>> >>> We add an ID to the I2C multi instantiate list to enumerate >>> all I2C slaves correctly. >>> >>> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com> >>> --- >>> drivers/acpi/scan.c | 1 + >>> drivers/platform/x86/i2c-multi-instantiate.c | 7 +++++++ >>> 2 files changed, 8 insertions(+) >>> >>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c >>> index 2c80765670bc..16827a33e93b 100644 >>> --- a/drivers/acpi/scan.c >>> +++ b/drivers/acpi/scan.c >>> @@ -1708,6 +1708,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) >>> {"BSG2150", }, >>> {"INT33FE", }, >>> {"INT3515", }, >>> + {"CLSA0100", }, >>> {} >>> }; >>> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c >>> index 4956a1df5b90..ed25a0adc656 100644 >>> --- a/drivers/platform/x86/i2c-multi-instantiate.c >>> +++ b/drivers/platform/x86/i2c-multi-instantiate.c >>> @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[] = { >>> {} >>> }; >>> +static const struct i2c_inst_data clsa0100_data[] = { >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >> >> This suggests that both amplifiers are using the same GPIO pin as shared >> IRQ, is that correct ? Can you share an acpidump of the laptop's DSDT tables ? >> >> Regards, >> >> Hans >> > > DSDT attached. > Yes, both amps share the same IRQ gpio. Thanks, this patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > >> >> >> >>> + {} >>> +}; >>> + >>> /* >>> * Note new device-ids must also be added to i2c_multi_instantiate_ids in >>> * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). >>> @@ -155,6 +161,7 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { >>> { "BSG1160", (unsigned long)bsg1160_data }, >>> { "BSG2150", (unsigned long)bsg2150_data }, >>> { "INT3515", (unsigned long)int3515_data }, >>> + { "CLSA0100", (unsigned long)clsa0100_data }, >>> { } >>> }; >>> MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); >>> >>
next prev parent reply other threads:[~2021-11-23 18:36 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-23 16:31 [PATCH v3 00/11] Add support for Legion 7 16ACHg6 laptop Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole device Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 18:02 ` Charles Keepax 2021-11-23 18:02 ` Charles Keepax 2021-11-23 16:31 ` [PATCH 02/11] ASoC: cs35l41: Convert tables to shared source code Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 17:53 ` Mark Brown 2021-11-23 17:53 ` Mark Brown 2021-11-23 18:05 ` Charles Keepax 2021-11-23 18:05 ` Charles Keepax 2021-11-24 1:34 ` kernel test robot 2021-11-24 1:34 ` kernel test robot 2021-11-23 16:31 ` [PATCH 03/11] ASoC: cs35l41: Move regmap config struct to shared code Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 17:20 ` Mark Brown 2021-11-23 17:20 ` Mark Brown 2021-11-23 16:31 ` [PATCH 04/11] ASoC: cs35l41: Create function for init array of Supplies Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 17:58 ` Mark Brown 2021-11-23 17:58 ` Mark Brown 2021-11-24 13:31 ` Mark Brown 2021-11-23 16:31 ` [PATCH 05/11] ASoC: cs35l41: Move cs35l41_otp_unpack to shared code Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 06/11] ASoC: cs35l41: Move power initializations to reg_sequence Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 07/11] ASoC: cs35l41: Create shared function for errata patches Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 08/11] ASoC: cs35l41: Create shared function for setting channels Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 09/11] ASoC: cs35l41: Create shared function for boost configuration Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:31 ` [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 16:52 ` Takashi Iwai 2021-11-23 16:52 ` Takashi Iwai 2021-11-23 16:59 ` Pierre-Louis Bossart 2021-11-23 16:59 ` Pierre-Louis Bossart 2021-11-23 17:06 ` tanureal 2021-11-23 17:16 ` Pierre-Louis Bossart 2021-11-23 17:15 ` Mark Brown 2021-11-23 17:15 ` Mark Brown 2021-11-24 3:18 ` kernel test robot 2021-11-23 16:31 ` [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100 ACPI nodes Lucas Tanure 2021-11-23 16:31 ` Lucas Tanure 2021-11-23 17:05 ` Hans de Goede 2021-11-23 17:05 ` Hans de Goede 2021-11-23 17:11 ` Lucas tanure 2021-11-23 17:11 ` Lucas tanure 2021-11-23 18:35 ` Hans de Goede [this message] 2021-11-23 18:35 ` Hans de Goede 2021-11-23 23:01 ` Andy Shevchenko 2021-11-23 23:01 ` Andy Shevchenko 2021-11-24 17:36 ` (subset) [PATCH v3 00/11] Add support for Legion 7 16ACHg6 laptop Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1605be8d-0913-4b52-32e2-8076fff01d30@redhat.com \ --to=hdegoede@redhat.com \ --cc=alexandre.belloni@bootlin.com \ --cc=alsa-devel@alsa-project.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=cam@neo-zeon.de \ --cc=chris.chiu@canonical.com \ --cc=david.rhodes@cirrus.com \ --cc=eliadevito@gmail.com \ --cc=hui.wang@canonical.com \ --cc=jack.yu@realtek.com \ --cc=jeremy.szu@canonical.com \ --cc=kailang@realtek.com \ --cc=lars@metafoo.de \ --cc=lenb@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=markgross@kernel.org \ --cc=patches@opensource.cirrus.com \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=sami@loone.fi \ --cc=shumingf@realtek.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tanureal@opensource.cirrus.com \ --cc=tiwai@suse.com \ --cc=vitalyr@opensource.cirrus.com \ --cc=wse@tuxedocomputers.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.