* [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler
@ 2020-11-22 23:45 Rikard Falkeborn
2020-11-24 4:20 ` patchwork-bot+linux-remoteproc
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Rikard Falkeborn @ 2020-11-22 23:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen
Cc: linux-arm-msm, linux-remoteproc, linux-kernel, Rikard Falkeborn
The only usage of qmi_indication_handler[] is to pass its address to
qmi_handle_init() which accepts a const pointer. Make it const to allow
the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/remoteproc/qcom_sysmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
index 9eb2f6bccea6..6c3275b58c36 100644
--- a/drivers/remoteproc/qcom_sysmon.c
+++ b/drivers/remoteproc/qcom_sysmon.c
@@ -283,7 +283,7 @@ static void sysmon_ind_cb(struct qmi_handle *qmi, struct sockaddr_qrtr *sq,
complete(&sysmon->ind_comp);
}
-static struct qmi_msg_handler qmi_indication_handler[] = {
+static const struct qmi_msg_handler qmi_indication_handler[] = {
{
.type = QMI_INDICATION,
.msg_id = SSCTL_SHUTDOWN_READY_IND,
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler
2020-11-22 23:45 [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler Rikard Falkeborn
@ 2020-11-24 4:20 ` patchwork-bot+linux-remoteproc
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2020-11-24 4:20 UTC (permalink / raw)
To: Rikard Falkeborn; +Cc: linux-remoteproc
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
On Mon, 23 Nov 2020 00:45:40 +0100 you wrote:
> The only usage of qmi_indication_handler[] is to pass its address to
> qmi_handle_init() which accepts a const pointer. Make it const to allow
> the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/remoteproc/qcom_sysmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- remoteproc: qcom_sysmon: Constify qmi_indication_handler
https://git.kernel.org/andersson/remoteproc/c/dd8f52660cb1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler
2020-11-22 23:45 [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler Rikard Falkeborn
2020-11-24 4:20 ` patchwork-bot+linux-remoteproc
@ 2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2020-12-29 20:15 UTC (permalink / raw)
To: Rikard Falkeborn; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Mon, 23 Nov 2020 00:45:40 +0100 you wrote:
> The only usage of qmi_indication_handler[] is to pass its address to
> qmi_handle_init() which accepts a const pointer. Make it const to allow
> the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/remoteproc/qcom_sysmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- remoteproc: qcom_sysmon: Constify qmi_indication_handler
https://git.kernel.org/qcom/c/dd8f52660cb1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-29 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 23:45 [PATCH] remoteproc: qcom_sysmon: Constify qmi_indication_handler Rikard Falkeborn
2020-11-24 4:20 ` patchwork-bot+linux-remoteproc
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.