* [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
@ 2020-11-27 21:00 Chris Wilson
2020-11-27 21:04 ` Souza, Jose
2020-11-27 23:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2020-11-27 21:00 UTC (permalink / raw)
To: intel-gfx; +Cc: José Roberto de Souza, Chris Wilson
We know a problem exists in the ifwi shipped with the early
pre-production Tigerlake and DG1 prototypes, later revisions are fine.
However, CI still relies on the earlier ifwi and we grow tired of
the volume of warnings as we wait for replacements.
Since the warning is a bug, we do not want to lose the warning in its
entirety, so only suppress the warning for the platforms currently
exhibiting the issue.
Suggested-by: José Roberto de Souza <gitlab@gitlab.freedesktop.org>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2411
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: José Roberto de Souza <jose.souza@intel.com>
---
.../gpu/drm/i915/display/intel_combo_phy.c | 20 +++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index d5ad61e4083e..996ae0608a62 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -427,10 +427,22 @@ static void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
u32 val;
if (phy == PHY_A &&
- !icl_combo_phy_verify_state(dev_priv, phy))
- drm_warn(&dev_priv->drm,
- "Combo PHY %c HW state changed unexpectedly\n",
- phy_name(phy));
+ !icl_combo_phy_verify_state(dev_priv, phy)) {
+ if (IS_TIGERLAKE(dev_priv) || IS_DG1(dev_priv)) {
+ /*
+ * A known problem with old ifwi:
+ * https://gitlab.freedesktop.org/drm/intel/-/issues/2411
+ * Suppress the warning for CI. Remove ASAP!
+ */
+ drm_dbg_kms(&dev_priv->drm,
+ "Combo PHY %c HW state changed unexpectedly\n",
+ phy_name(phy));
+ } else {
+ drm_warn(&dev_priv->drm,
+ "Combo PHY %c HW state changed unexpectedly\n",
+ phy_name(phy));
+ }
+ }
if (!has_phy_misc(dev_priv, phy))
goto skip_phy_misc;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
2020-11-27 21:00 [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly" Chris Wilson
@ 2020-11-27 21:04 ` Souza, Jose
2020-11-27 23:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Souza, Jose @ 2020-11-27 21:04 UTC (permalink / raw)
To: intel-gfx, chris; +Cc: gitlab
On Fri, 2020-11-27 at 21:00 +0000, Chris Wilson wrote:
> We know a problem exists in the ifwi shipped with the early
> pre-production Tigerlake and DG1 prototypes, later revisions are fine.
> However, CI still relies on the earlier ifwi and we grow tired of
> the volume of warnings as we wait for replacements.
>
> Since the warning is a bug, we do not want to lose the warning in its
> entirety, so only suppress the warning for the platforms currently
> exhibiting the issue.
>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Suggested-by: José Roberto de Souza <gitlab@gitlab.freedesktop.org>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2411
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> ---
> .../gpu/drm/i915/display/intel_combo_phy.c | 20 +++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index d5ad61e4083e..996ae0608a62 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -427,10 +427,22 @@ static void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
> u32 val;
>
>
>
>
> if (phy == PHY_A &&
> - !icl_combo_phy_verify_state(dev_priv, phy))
> - drm_warn(&dev_priv->drm,
> - "Combo PHY %c HW state changed unexpectedly\n",
> - phy_name(phy));
> + !icl_combo_phy_verify_state(dev_priv, phy)) {
> + if (IS_TIGERLAKE(dev_priv) || IS_DG1(dev_priv)) {
> + /*
> + * A known problem with old ifwi:
> + * https://gitlab.freedesktop.org/drm/intel/-/issues/2411
> + * Suppress the warning for CI. Remove ASAP!
> + */
> + drm_dbg_kms(&dev_priv->drm,
> + "Combo PHY %c HW state changed unexpectedly\n",
> + phy_name(phy));
> + } else {
> + drm_warn(&dev_priv->drm,
> + "Combo PHY %c HW state changed unexpectedly\n",
> + phy_name(phy));
> + }
> + }
>
>
>
>
> if (!has_phy_misc(dev_priv, phy))
> goto skip_phy_misc;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
2020-11-27 21:00 [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly" Chris Wilson
2020-11-27 21:04 ` Souza, Jose
@ 2020-11-27 23:47 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-11-27 23:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5066 bytes --]
== Series Details ==
Series: drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
URL : https://patchwork.freedesktop.org/series/84368/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9401 -> Patchwork_19007
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19007 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19007, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19007:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_timelines:
- fi-apl-guc: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-apl-guc/igt@i915_selftest@live@gt_timelines.html
New tests
---------
New tests have been introduced between CI_DRM_9401 and Patchwork_19007:
### New CI tests (1) ###
* boot:
- Statuses : 41 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_19007 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-kbl-soraka/igt@kms_busy@basic@flip.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-icl-u2/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-icl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-y: [DMESG-WARN][11] ([i915#2411]) -> [PASS][12] +5 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-tgl-y/igt@i915_pm_rpm@module-reload.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][13] ([i915#1161] / [i915#262]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9401/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (46 -> 41)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9401 -> Patchwork_19007
CI-20190529: 20190529
CI_DRM_9401: a88f54b9c003dd8ee5442caa8212cf507e0172c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5873: b6321b58dcaa41ba1d28aced42d6b15dc3d49ca2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19007: 54db25f2ae038484f4883c80da95e688b19df42a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
54db25f2ae03 drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19007/index.html
[-- Attachment #1.2: Type: text/html, Size: 6116 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 21:00 [Intel-gfx] [PATCH] drm/i915/display: Suppress "Combo PHY A HW state changed unexpectedly" Chris Wilson
2020-11-27 21:04 ` Souza, Jose
2020-11-27 23:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.