* [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
@ 2020-12-02 15:51 Chris Wilson
2020-12-02 15:51 ` [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G" Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Chris Wilson @ 2020-12-02 15:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, Chris Wilson
Adhere to the i915_sg_max_segment() limit on the lengths of individual
scatterlist elements, and in doing so split up very large chunks of lmem
into managable pieces for the dma-mapping backend.
Reported-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_region.c | 42 +++++++++++--------
.../drm/i915/selftests/intel_memory_region.c | 27 +++++++++---
2 files changed, 45 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_region.c b/drivers/gpu/drm/i915/gem/i915_gem_region.c
index e72d78074c9e..edb84072f979 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_region.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_region.c
@@ -22,6 +22,7 @@ i915_gem_object_put_pages_buddy(struct drm_i915_gem_object *obj,
int
i915_gem_object_get_pages_buddy(struct drm_i915_gem_object *obj)
{
+ const u64 max_segment = i915_sg_segment_size();
struct intel_memory_region *mem = obj->mm.region;
struct list_head *blocks = &obj->mm.blocks;
resource_size_t size = obj->base.size;
@@ -37,7 +38,7 @@ i915_gem_object_get_pages_buddy(struct drm_i915_gem_object *obj)
if (!st)
return -ENOMEM;
- if (sg_alloc_table(st, size >> ilog2(mem->mm.chunk_size), GFP_KERNEL)) {
+ if (sg_alloc_table(st, size >> PAGE_SHIFT, GFP_KERNEL)) {
kfree(st);
return -ENOMEM;
}
@@ -58,33 +59,38 @@ i915_gem_object_get_pages_buddy(struct drm_i915_gem_object *obj)
prev_end = (resource_size_t)-1;
list_for_each_entry(block, blocks, link) {
- u64 block_size, offset;
+ u64 block_size, offset, len;
block_size = min_t(u64, size,
i915_buddy_block_size(&mem->mm, block));
offset = i915_buddy_block_offset(block);
- GEM_BUG_ON(overflows_type(block_size, sg->length));
+ while (block_size) {
+ if (offset != prev_end || sg->length >= max_segment) {
+ if (st->nents) {
+ sg_page_sizes |= sg->length;
+ sg = __sg_next(sg);
+ }
- if (offset != prev_end ||
- add_overflows_t(typeof(sg->length), sg->length, block_size)) {
- if (st->nents) {
- sg_page_sizes |= sg->length;
- sg = __sg_next(sg);
- }
+ len = min(block_size, max_segment);
- sg_dma_address(sg) = mem->region.start + offset;
- sg_dma_len(sg) = block_size;
+ sg_dma_address(sg) = mem->region.start + offset;
+ sg_dma_len(sg) = len;
- sg->length = block_size;
+ sg->length = len;
- st->nents++;
- } else {
- sg->length += block_size;
- sg_dma_len(sg) += block_size;
- }
+ st->nents++;
+ } else {
+ len = min(block_size, max_segment - sg->length);
+ sg->length += len;
+ sg_dma_len(sg) += len;
+ }
- prev_end = offset + block_size;
+ offset += len;
+ block_size -= len;
+
+ prev_end = offset;
+ }
}
sg_page_sizes |= sg->length;
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
index 55ccd957a009..7c02a0c16fc1 100644
--- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
@@ -129,6 +129,21 @@ static void igt_object_release(struct drm_i915_gem_object *obj)
i915_gem_object_put(obj);
}
+static bool is_contiguous(struct drm_i915_gem_object *obj)
+{
+ struct scatterlist *sg;
+ dma_addr_t addr = -1;
+
+ for (sg = obj->mm.pages->sgl; sg; sg = sg_next(sg)) {
+ if (addr != -1 && sg_dma_address(sg) != addr)
+ return false;
+
+ addr = sg_dma_address(sg) + sg_dma_len(sg);
+ }
+
+ return true;
+}
+
static int igt_mock_contiguous(void *arg)
{
struct intel_memory_region *mem = arg;
@@ -150,8 +165,8 @@ static int igt_mock_contiguous(void *arg)
if (IS_ERR(obj))
return PTR_ERR(obj);
- if (obj->mm.pages->nents != 1) {
- pr_err("%s min object spans multiple sg entries\n", __func__);
+ if (!is_contiguous(obj)) {
+ pr_err("%s min object spans disjoint sg entries\n", __func__);
err = -EINVAL;
goto err_close_objects;
}
@@ -163,8 +178,8 @@ static int igt_mock_contiguous(void *arg)
if (IS_ERR(obj))
return PTR_ERR(obj);
- if (obj->mm.pages->nents != 1) {
- pr_err("%s max object spans multiple sg entries\n", __func__);
+ if (!is_contiguous(obj)) {
+ pr_err("%s max object spans disjoint sg entries\n", __func__);
err = -EINVAL;
goto err_close_objects;
}
@@ -189,8 +204,8 @@ static int igt_mock_contiguous(void *arg)
goto err_close_objects;
}
- if (obj->mm.pages->nents != 1) {
- pr_err("%s object spans multiple sg entries\n", __func__);
+ if (!is_contiguous(obj)) {
+ pr_err("%s object spans disjoint sg entries\n", __func__);
err = -EINVAL;
goto err_close_objects;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
@ 2020-12-02 15:51 ` Chris Wilson
2020-12-02 16:40 ` Matthew Auld
2020-12-02 16:29 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Matthew Auld
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2020-12-02 15:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld, Chris Wilson
Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared
badly. The two directives conflict, with the contiguous request setting
the min_order to the full size of the object, and the max-segment-size
setting the max_order to the limit of the DMA mapper, resulting in a
situation where max_order < min_order, causing our sanity checks to
fail.
Instead of limiting the buddy block size, in the previous patch we split
the oversized buddy into multiple scatterlist elements.
Fixes: d2cf0125d4a1 ("drm/i915/lmem: Limit block size to 4G")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_region.c | 2 +-
drivers/gpu/drm/i915/intel_memory_region.c | 18 +---------
drivers/gpu/drm/i915/intel_memory_region.h | 5 ++-
.../drm/i915/selftests/intel_memory_region.c | 34 ++++++++++++-------
4 files changed, 26 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_region.c b/drivers/gpu/drm/i915/gem/i915_gem_region.c
index edb84072f979..e605cccd52f4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_region.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_region.c
@@ -43,7 +43,7 @@ i915_gem_object_get_pages_buddy(struct drm_i915_gem_object *obj)
return -ENOMEM;
}
- flags = I915_ALLOC_MIN_PAGE_SIZE | I915_ALLOC_MAX_SEGMENT_SIZE;
+ flags = I915_ALLOC_MIN_PAGE_SIZE;
if (obj->flags & I915_BO_ALLOC_CONTIGUOUS)
flags |= I915_ALLOC_CONTIGUOUS;
diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
index ae36e2f6d6e3..b326993a1026 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/intel_memory_region.c
@@ -72,7 +72,6 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem,
struct list_head *blocks)
{
unsigned int min_order = 0;
- unsigned int max_order;
unsigned long n_pages;
GEM_BUG_ON(!IS_ALIGNED(size, mem->mm.chunk_size));
@@ -93,28 +92,13 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem,
n_pages = size >> ilog2(mem->mm.chunk_size);
- /*
- * If we going to feed this into an sg list we should limit the block
- * sizes such that we don't exceed the i915_sg_segment_size().
- */
- if (flags & I915_ALLOC_MAX_SEGMENT_SIZE) {
- unsigned int max_segment = i915_sg_segment_size();
-
- if (GEM_WARN_ON(max_segment < mem->mm.chunk_size))
- max_order = 0;
- else
- max_order = ilog2(max_segment) - ilog2(mem->mm.chunk_size);
- } else {
- max_order = mem->mm.max_order;
- }
-
mutex_lock(&mem->mm_lock);
do {
struct i915_buddy_block *block;
unsigned int order;
- order = min_t(u32, fls(n_pages) - 1, max_order);
+ order = fls(n_pages) - 1;
GEM_BUG_ON(order > mem->mm.max_order);
GEM_BUG_ON(order < min_order);
diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h
index 5fb9bcf86b97..232490d89a83 100644
--- a/drivers/gpu/drm/i915/intel_memory_region.h
+++ b/drivers/gpu/drm/i915/intel_memory_region.h
@@ -44,9 +44,8 @@ enum intel_region_id {
#define MEMORY_TYPE_FROM_REGION(r) (ilog2((r) >> INTEL_MEMORY_TYPE_SHIFT))
#define MEMORY_INSTANCE_FROM_REGION(r) (ilog2((r) & 0xffff))
-#define I915_ALLOC_MIN_PAGE_SIZE BIT(0)
-#define I915_ALLOC_CONTIGUOUS BIT(1)
-#define I915_ALLOC_MAX_SEGMENT_SIZE BIT(2)
+#define I915_ALLOC_MIN_PAGE_SIZE BIT(0)
+#define I915_ALLOC_CONTIGUOUS BIT(1)
#define for_each_memory_region(mr, i915, id) \
for (id = 0; id < ARRAY_SIZE((i915)->mm.regions); id++) \
diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
index 7c02a0c16fc1..1650f8d9c026 100644
--- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
+++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
@@ -356,21 +356,21 @@ static int igt_mock_splintered_region(void *arg)
static int igt_mock_max_segment(void *arg)
{
+ const unsigned int max_segment = i915_sg_segment_size();
struct intel_memory_region *mem = arg;
struct drm_i915_private *i915 = mem->i915;
struct drm_i915_gem_object *obj;
struct i915_buddy_block *block;
+ struct scatterlist *sg;
LIST_HEAD(objects);
u64 size;
int err = 0;
/*
- * The size of block are only limited by the largest power-of-two that
- * will fit in the region size, but to construct an object we also
- * require feeding it into an sg list, where the upper limit of the sg
- * entry is at most UINT_MAX, therefore when allocating with
- * I915_ALLOC_MAX_SEGMENT_SIZE we shouldn't see blocks larger than
- * i915_sg_segment_size().
+ * While we may create very large contiguous blocks, we may need
+ * to break those down for consumption elsewhere. In particular,
+ * dma-mapping with scatterlist elements have an implicit limit of
+ * UINT_MAX on each element.
*/
size = SZ_8G;
@@ -384,13 +384,23 @@ static int igt_mock_max_segment(void *arg)
goto out_put;
}
+ err = -EINVAL;
list_for_each_entry(block, &obj->mm.blocks, link) {
- if (i915_buddy_block_size(&mem->mm, block) > i915_sg_segment_size()) {
- pr_err("%s found block size(%llu) larger than max sg_segment_size(%u)",
- __func__,
- i915_buddy_block_size(&mem->mm, block),
- i915_sg_segment_size());
- err = -EINVAL;
+ if (i915_buddy_block_size(&mem->mm, block) > max_segment) {
+ err = 0;
+ break;
+ }
+ }
+ if (err) {
+ pr_err("%s: Failed to create a huge contiguous block\n",
+ __func__);
+ goto out_close;
+ }
+
+ for (sg = obj->mm.pages->sgl; sg; sg = sg_next(sg)) {
+ if (sg->length > max_segment) {
+ pr_err("%s: Created an oversized scatterlist entry, %u > %u\n",
+ __func__, sg->length, max_segment);
goto out_close;
}
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
2020-12-02 15:51 ` [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G" Chris Wilson
@ 2020-12-02 16:29 ` Matthew Auld
2020-12-02 17:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Matthew Auld @ 2020-12-02 16:29 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld
On Wed, 2 Dec 2020 at 15:51, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Adhere to the i915_sg_max_segment() limit on the lengths of individual
> scatterlist elements, and in doing so split up very large chunks of lmem
> into managable pieces for the dma-mapping backend.
>
> Reported-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"
2020-12-02 15:51 ` [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G" Chris Wilson
@ 2020-12-02 16:40 ` Matthew Auld
2020-12-02 16:56 ` Chris Wilson
0 siblings, 1 reply; 8+ messages in thread
From: Matthew Auld @ 2020-12-02 16:40 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development, Matthew Auld
On Wed, 2 Dec 2020 at 15:51, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared
> badly. The two directives conflict, with the contiguous request setting
> the min_order to the full size of the object, and the max-segment-size
> setting the max_order to the limit of the DMA mapper, resulting in a
> situation where max_order < min_order, causing our sanity checks to
> fail.
>
> Instead of limiting the buddy block size, in the previous patch we split
> the oversized buddy into multiple scatterlist elements.
>
> Fixes: d2cf0125d4a1 ("drm/i915/lmem: Limit block size to 4G")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_region.c | 2 +-
> drivers/gpu/drm/i915/intel_memory_region.c | 18 +---------
> drivers/gpu/drm/i915/intel_memory_region.h | 5 ++-
> .../drm/i915/selftests/intel_memory_region.c | 34 ++++++++++++-------
> 4 files changed, 26 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_region.c b/drivers/gpu/drm/i915/gem/i915_gem_region.c
> index edb84072f979..e605cccd52f4 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_region.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_region.c
> @@ -43,7 +43,7 @@ i915_gem_object_get_pages_buddy(struct drm_i915_gem_object *obj)
> return -ENOMEM;
> }
>
> - flags = I915_ALLOC_MIN_PAGE_SIZE | I915_ALLOC_MAX_SEGMENT_SIZE;
> + flags = I915_ALLOC_MIN_PAGE_SIZE;
> if (obj->flags & I915_BO_ALLOC_CONTIGUOUS)
> flags |= I915_ALLOC_CONTIGUOUS;
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c
> index ae36e2f6d6e3..b326993a1026 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.c
> +++ b/drivers/gpu/drm/i915/intel_memory_region.c
> @@ -72,7 +72,6 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem,
> struct list_head *blocks)
> {
> unsigned int min_order = 0;
> - unsigned int max_order;
> unsigned long n_pages;
>
> GEM_BUG_ON(!IS_ALIGNED(size, mem->mm.chunk_size));
> @@ -93,28 +92,13 @@ __intel_memory_region_get_pages_buddy(struct intel_memory_region *mem,
>
> n_pages = size >> ilog2(mem->mm.chunk_size);
>
> - /*
> - * If we going to feed this into an sg list we should limit the block
> - * sizes such that we don't exceed the i915_sg_segment_size().
> - */
> - if (flags & I915_ALLOC_MAX_SEGMENT_SIZE) {
> - unsigned int max_segment = i915_sg_segment_size();
> -
> - if (GEM_WARN_ON(max_segment < mem->mm.chunk_size))
> - max_order = 0;
> - else
> - max_order = ilog2(max_segment) - ilog2(mem->mm.chunk_size);
> - } else {
> - max_order = mem->mm.max_order;
> - }
> -
> mutex_lock(&mem->mm_lock);
>
> do {
> struct i915_buddy_block *block;
> unsigned int order;
>
> - order = min_t(u32, fls(n_pages) - 1, max_order);
> + order = fls(n_pages) - 1;
> GEM_BUG_ON(order > mem->mm.max_order);
> GEM_BUG_ON(order < min_order);
>
> diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h
> index 5fb9bcf86b97..232490d89a83 100644
> --- a/drivers/gpu/drm/i915/intel_memory_region.h
> +++ b/drivers/gpu/drm/i915/intel_memory_region.h
> @@ -44,9 +44,8 @@ enum intel_region_id {
> #define MEMORY_TYPE_FROM_REGION(r) (ilog2((r) >> INTEL_MEMORY_TYPE_SHIFT))
> #define MEMORY_INSTANCE_FROM_REGION(r) (ilog2((r) & 0xffff))
>
> -#define I915_ALLOC_MIN_PAGE_SIZE BIT(0)
> -#define I915_ALLOC_CONTIGUOUS BIT(1)
> -#define I915_ALLOC_MAX_SEGMENT_SIZE BIT(2)
> +#define I915_ALLOC_MIN_PAGE_SIZE BIT(0)
> +#define I915_ALLOC_CONTIGUOUS BIT(1)
>
> #define for_each_memory_region(mr, i915, id) \
> for (id = 0; id < ARRAY_SIZE((i915)->mm.regions); id++) \
> diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
> index 7c02a0c16fc1..1650f8d9c026 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c
> @@ -356,21 +356,21 @@ static int igt_mock_splintered_region(void *arg)
>
> static int igt_mock_max_segment(void *arg)
> {
> + const unsigned int max_segment = i915_sg_segment_size();
> struct intel_memory_region *mem = arg;
> struct drm_i915_private *i915 = mem->i915;
> struct drm_i915_gem_object *obj;
> struct i915_buddy_block *block;
> + struct scatterlist *sg;
> LIST_HEAD(objects);
> u64 size;
> int err = 0;
>
> /*
> - * The size of block are only limited by the largest power-of-two that
> - * will fit in the region size, but to construct an object we also
> - * require feeding it into an sg list, where the upper limit of the sg
> - * entry is at most UINT_MAX, therefore when allocating with
> - * I915_ALLOC_MAX_SEGMENT_SIZE we shouldn't see blocks larger than
> - * i915_sg_segment_size().
> + * While we may create very large contiguous blocks, we may need
> + * to break those down for consumption elsewhere. In particular,
> + * dma-mapping with scatterlist elements have an implicit limit of
> + * UINT_MAX on each element.
> */
>
> size = SZ_8G;
> @@ -384,13 +384,23 @@ static int igt_mock_max_segment(void *arg)
> goto out_put;
> }
>
> + err = -EINVAL;
> list_for_each_entry(block, &obj->mm.blocks, link) {
> - if (i915_buddy_block_size(&mem->mm, block) > i915_sg_segment_size()) {
> - pr_err("%s found block size(%llu) larger than max sg_segment_size(%u)",
> - __func__,
> - i915_buddy_block_size(&mem->mm, block),
> - i915_sg_segment_size());
> - err = -EINVAL;
> + if (i915_buddy_block_size(&mem->mm, block) > max_segment) {
> + err = 0;
> + break;
> + }
> + }
> + if (err) {
> + pr_err("%s: Failed to create a huge contiguous block\n",
> + __func__);
> + goto out_close;
> + }
> +
> + for (sg = obj->mm.pages->sgl; sg; sg = sg_next(sg)) {
> + if (sg->length > max_segment) {
> + pr_err("%s: Created an oversized scatterlist entry, %u > %u\n",
> + __func__, sg->length, max_segment);
err = -EINVAL;
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> goto out_close;
> }
> }
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G"
2020-12-02 16:40 ` Matthew Auld
@ 2020-12-02 16:56 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2020-12-02 16:56 UTC (permalink / raw)
To: Matthew Auld; +Cc: Intel Graphics Development, Matthew Auld
Quoting Matthew Auld (2020-12-02 16:40:36)
> On Wed, 2 Dec 2020 at 15:51, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Mixing I915_ALLOC_CONTIGUOUS and I915_ALLOC_MAX_SEGMENT_SIZE fared
> > badly. The two directives conflict, with the contiguous request setting
> > the min_order to the full size of the object, and the max-segment-size
> > setting the max_order to the limit of the DMA mapper, resulting in a
> > situation where max_order < min_order, causing our sanity checks to
> > fail.
> >
> > Instead of limiting the buddy block size, in the previous patch we split
> > the oversized buddy into multiple scatterlist elements.
> >
> > Fixes: d2cf0125d4a1 ("drm/i915/lmem: Limit block size to 4G")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > ---
> > + for (sg = obj->mm.pages->sgl; sg; sg = sg_next(sg)) {
> > + if (sg->length > max_segment) {
> > + pr_err("%s: Created an oversized scatterlist entry, %u > %u\n",
> > + __func__, sg->length, max_segment);
>
> err = -EINVAL;
Indeed. Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
2020-12-02 15:51 ` [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G" Chris Wilson
2020-12-02 16:29 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Matthew Auld
@ 2020-12-02 17:26 ` Patchwork
2020-12-02 17:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-02 22:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-02 17:26 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
URL : https://patchwork.freedesktop.org/series/84501/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a38d86f0fa1f drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
-:8: WARNING:TYPO_SPELLING: 'managable' may be misspelled - perhaps 'manageable'?
#8:
into managable pieces for the dma-mapping backend.
total: 0 errors, 1 warnings, 0 checks, 121 lines checked
9f373e51c9a9 Revert "drm/i915/lmem: Limit block size to 4G"
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
` (2 preceding siblings ...)
2020-12-02 17:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] " Patchwork
@ 2020-12-02 17:57 ` Patchwork
2020-12-02 22:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-02 17:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6492 bytes --]
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
URL : https://patchwork.freedesktop.org/series/84501/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9424 -> Patchwork_19042
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/index.html
New tests
---------
New tests have been introduced between CI_DRM_9424 and Patchwork_19042:
### New CI tests (1) ###
* boot:
- Statuses : 1 fail(s) 40 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_19042 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@i915_module_load@reload:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-icl-u2/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-icl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][5] -> [FAIL][6] ([i915#138])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-kbl-soraka/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-tgl-y/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][13] -> [DMESG-WARN][14] ([i915#402]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][17] ([i915#2291] / [i915#541]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-tgl-y: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-tgl-y/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-tgl-y/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][23] ([i915#402]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (45 -> 41)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9424 -> Patchwork_19042
CI-20190529: 20190529
CI_DRM_9424: 52e59b0a3839bde394be8b5d48b2c1a309b564e3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5878: e96c0d8e6952d892bcbbcdf004999880a4dfb42e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19042: 9f373e51c9a903cd707fec43e06600c6bb6f59b4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9f373e51c9a9 Revert "drm/i915/lmem: Limit block size to 4G"
a38d86f0fa1f drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/index.html
[-- Attachment #1.2: Type: text/html, Size: 7977 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
` (3 preceding siblings ...)
2020-12-02 17:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-12-02 22:02 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-12-02 22:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 22808 bytes --]
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX
URL : https://patchwork.freedesktop.org/series/84501/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9424_full -> Patchwork_19042_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19042_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19042_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19042_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html
New tests
---------
New tests have been introduced between CI_DRM_9424_full and Patchwork_19042_full:
### New CI tests (1) ###
* boot:
- Statuses : 175 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_19042_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][2] -> [DMESG-WARN][3] ([i915#118] / [i915#95])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk9/igt@gem_exec_whisper@basic-queues-forked.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_mmap_wc@copy:
- shard-iclb: [PASS][4] -> [DMESG-WARN][5] ([i915#1982])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb8/igt@gem_mmap_wc@copy.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb2/igt@gem_mmap_wc@copy.html
* igt@i915_pm_rpm@fences-dpms:
- shard-glk: [PASS][6] -> [DMESG-WARN][7] ([i915#1982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk3/igt@i915_pm_rpm@fences-dpms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk2/igt@i915_pm_rpm@fences-dpms.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl8/igt@kms_big_fb@linear-64bpp-rotate-180.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl6/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
- shard-skl: [PASS][10] -> [FAIL][11] ([i915#54]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][12] -> [FAIL][13] ([i915#79])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][14] -> [INCOMPLETE][15] ([i915#155] / [i915#180])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-snb: [PASS][16] -> [SKIP][17] ([fdo#109271]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- shard-tglb: [PASS][18] -> [DMESG-WARN][19] ([i915#1982]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#265]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_cursor@pipe-b-overlay-size-256:
- shard-skl: [PASS][22] -> [DMESG-WARN][23] ([i915#1982]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl1/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl1/igt@kms_plane_cursor@pipe-b-overlay-size-256.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][24] -> [SKIP][25] ([fdo#109441]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-skl: [PASS][26] -> [FAIL][27] ([i915#2060])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl1/igt@sysfs_preempt_timeout@timeout@vecs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl1/igt@sysfs_preempt_timeout@timeout@vecs0.html
#### Possible fixes ####
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [DMESG-WARN][28] ([i915#118] / [i915#95]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk3/igt@gem_exec_whisper@basic-forked-all.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk6/igt@gem_exec_whisper@basic-forked-all.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][30] ([i915#454]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live@hangcheck:
- shard-iclb: [INCOMPLETE][32] ([i915#1580] / [i915#926]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb7/igt@i915_selftest@live@hangcheck.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb3/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@mock@memory_region:
- shard-skl: [INCOMPLETE][34] ([i915#2753]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl3/igt@i915_selftest@mock@memory_region.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl8/igt@i915_selftest@mock@memory_region.html
- shard-tglb: [INCOMPLETE][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb1/igt@i915_selftest@mock@memory_region.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-tglb3/igt@i915_selftest@mock@memory_region.html
- shard-glk: [INCOMPLETE][38] ([i915#2753]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk8/igt@i915_selftest@mock@memory_region.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk6/igt@i915_selftest@mock@memory_region.html
- shard-apl: [INCOMPLETE][40] ([i915#2753]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl4/igt@i915_selftest@mock@memory_region.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl6/igt@i915_selftest@mock@memory_region.html
- shard-iclb: [INCOMPLETE][42] ([i915#2753]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb2/igt@i915_selftest@mock@memory_region.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb4/igt@i915_selftest@mock@memory_region.html
- shard-kbl: [INCOMPLETE][44] ([i915#2753]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-kbl7/igt@i915_selftest@mock@memory_region.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-kbl3/igt@i915_selftest@mock@memory_region.html
- shard-snb: [INCOMPLETE][46] ([i915#2753]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-snb6/igt@i915_selftest@mock@memory_region.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-snb7/igt@i915_selftest@mock@memory_region.html
* igt@kms_atomic_transition@plane-all-transition-nonblocking@hdmi-a-1-pipe-a:
- shard-glk: [DMESG-WARN][48] ([i915#1982]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk5/igt@kms_atomic_transition@plane-all-transition-nonblocking@hdmi-a-1-pipe-a.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk1/igt@kms_atomic_transition@plane-all-transition-nonblocking@hdmi-a-1-pipe-a.html
* igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
- shard-skl: [FAIL][50] ([i915#54]) -> [PASS][51] +7 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-64x64-random.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-kbl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-kbl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-kbl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1:
- shard-apl: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl6/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl8/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
* igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1:
- shard-skl: [DMESG-WARN][56] ([i915#1982]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl3/igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl8/igt@kms_flip@absolute-wf_vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][58] ([i915#79]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][60] ([i915#49]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
- shard-tglb: [DMESG-WARN][62] ([i915#1982]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][64] ([i915#123]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl2/igt@kms_frontbuffer_tracking@psr-suspend.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][66] ([i915#1188]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][68] ([fdo#108145] / [i915#265]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][70] ([fdo#109441]) -> [PASS][71] +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb6/igt@kms_psr@psr2_basic.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb2/igt@kms_psr@psr2_basic.html
* igt@perf@polling:
- shard-skl: [FAIL][72] ([i915#1542]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl7/igt@perf@polling.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl9/igt@perf@polling.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][74] ([i915#1982] / [i915#262]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl3/igt@perf_pmu@module-unload.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl8/igt@perf_pmu@module-unload.html
* igt@testdisplay:
- shard-iclb: [DMESG-WARN][76] ([i915#1982]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb2/igt@testdisplay.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb6/igt@testdisplay.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][78] ([i915#2684]) -> [WARN][79] ([i915#1804] / [i915#2684])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: [DMESG-FAIL][80] ([fdo#108145] / [i915#1982]) -> [FAIL][81] ([fdo#108145] / [i915#265])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][82], [FAIL][83]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#2722]) -> ([FAIL][84], [FAIL][85]) ([i915#2295] / [i915#2722] / [i915#483])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-kbl7/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-kbl7/igt@runner@aborted.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-kbl1/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-kbl6/igt@runner@aborted.html
- shard-iclb: ([FAIL][86], [FAIL][87], [FAIL][88]) ([i915#1580] / [i915#2295] / [i915#2722] / [i915#483]) -> ([FAIL][89], [FAIL][90]) ([i915#2295] / [i915#2722])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb3/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb4/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-iclb7/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb3/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-iclb2/igt@runner@aborted.html
- shard-apl: ([FAIL][91], [FAIL][92], [FAIL][93]) ([i915#2295] / [i915#2426] / [i915#2722]) -> ([FAIL][94], [FAIL][95]) ([i915#2295] / [i915#2722])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl4/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl3/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-apl7/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl2/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-apl2/igt@runner@aborted.html
- shard-glk: ([FAIL][96], [FAIL][97], [FAIL][98]) ([i915#2295] / [i915#2426] / [i915#2722] / [i915#483] / [k.org#202321]) -> ([FAIL][99], [FAIL][100]) ([i915#2295] / [i915#2722] / [i915#483] / [k.org#202321])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk8/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk7/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-glk9/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk3/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-glk9/igt@runner@aborted.html
- shard-tglb: ([FAIL][101], [FAIL][102], [FAIL][103]) ([i915#1602] / [i915#2295] / [i915#2426] / [i915#2722]) -> ([FAIL][104], [FAIL][105]) ([i915#1602] / [i915#2295] / [i915#2722])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb3/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb8/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-tglb1/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-tglb5/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-tglb8/igt@runner@aborted.html
- shard-skl: [FAIL][106] ([i915#2295] / [i915#2722]) -> ([FAIL][107], [FAIL][108]) ([i915#1814] / [i915#2029] / [i915#2295] / [i915#2722])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9424/shard-skl8/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl1/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/shard-skl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2060]: https://gitlab.freedesktop.org/drm/intel/issues/2060
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2753]: https://gitlab.freedesktop.org/drm/intel/issues/2753
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9424 -> Patchwork_19042
CI-20190529: 20190529
CI_DRM_9424: 52e59b0a3839bde394be8b5d48b2c1a309b564e3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5878: e96c0d8e6952d892bcbbcdf004999880a4dfb42e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19042: 9f373e51c9a903cd707fec43e06600c6bb6f59b4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19042/index.html
[-- Attachment #1.2: Type: text/html, Size: 28567 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-02 22:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 15:51 [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Chris Wilson
2020-12-02 15:51 ` [Intel-gfx] [PATCH v2 2/2] Revert "drm/i915/lmem: Limit block size to 4G" Chris Wilson
2020-12-02 16:40 ` Matthew Auld
2020-12-02 16:56 ` Chris Wilson
2020-12-02 16:29 ` [Intel-gfx] [PATCH v2 1/2] drm/i915/gem: Limit lmem scatterlist elements to UINT_MAX Matthew Auld
2020-12-02 17:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] " Patchwork
2020-12-02 17:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-02 22:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.