From: Tian Tao <tiantao6@hisilicon.com> To: <airlied@linux.ie>, <daniel@ffwll.ch>, <tzimmermann@suse.de>, <kraxel@redhat.com>, <alexander.deucher@amd.com>, <tglx@linutronix.de>, <dri-devel@lists.freedesktop.org>, <xinliang.liu@linaro.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH] drm/nouveau: Use vmemdup_user() Date: Fri, 4 Dec 2020 09:23:12 +0800 [thread overview] Message-ID: <1607044999-47666-7-git-send-email-tiantao6@hisilicon.com> (raw) In-Reply-To: <1607044999-47666-1-git-send-email-tiantao6@hisilicon.com> Replace alloc and copy with vmemdup_user() Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 787d05e..df986d9 100644 --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -591,14 +591,9 @@ u_memcpya(uint64_t user, unsigned nmemb, unsigned size) size *= nmemb; - mem = kvmalloc(size, GFP_KERNEL); - if (!mem) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(mem, userptr, size)) { - u_free(mem); - return ERR_PTR(-EFAULT); - } + mem = vmemdup_user(userptr, size); + if (IS_ERR(mem)) + return ERR_CAST(mem); return mem; } -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Tian Tao <tiantao6@hisilicon.com> To: <airlied@linux.ie>, <daniel@ffwll.ch>, <tzimmermann@suse.de>, <kraxel@redhat.com>, <alexander.deucher@amd.com>, <tglx@linutronix.de>, <dri-devel@lists.freedesktop.org>, <xinliang.liu@linaro.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH] drm/nouveau: Use vmemdup_user() Date: Fri, 4 Dec 2020 09:23:12 +0800 [thread overview] Message-ID: <1607044999-47666-7-git-send-email-tiantao6@hisilicon.com> (raw) In-Reply-To: <1607044999-47666-1-git-send-email-tiantao6@hisilicon.com> Replace alloc and copy with vmemdup_user() Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 787d05e..df986d9 100644 --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -591,14 +591,9 @@ u_memcpya(uint64_t user, unsigned nmemb, unsigned size) size *= nmemb; - mem = kvmalloc(size, GFP_KERNEL); - if (!mem) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(mem, userptr, size)) { - u_free(mem); - return ERR_PTR(-EFAULT); - } + mem = vmemdup_user(userptr, size); + if (IS_ERR(mem)) + return ERR_CAST(mem); return mem; } -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-04 1:24 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 1:23 [PATCH drm/hisilicon 0/3] support reading resolutions from EDID Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/fsl-dcu: remove redundant platform_get_irq error message Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH 1/2] drm/hisilicon: Use managed mode-config init Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/msm/dp: remove duplicate include statement Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/nouveau/fb/gp102-: use flexible-array member instead of zero-length array Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` Tian Tao [this message] 2020-12-04 1:23 ` [PATCH] drm/nouveau: Use vmemdup_user() Tian Tao 2020-12-04 1:23 ` [PATCH] drm/tilcdc: Remove unnecessary THIS_MODULE Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/ttm: remove unused varibles Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] drm/vc4: Deleted the drm_device declaration Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH] gpu: ipu-v3: replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH 2/2] drm/hisilicon: Deletted unused local parameters Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH v2] drm/hisilicon: Delete the entire file hibmc_ttm.c Tian Tao 2020-12-04 1:23 ` Tian Tao 2020-12-04 1:23 ` [PATCH drm/hisilicon v3 0/2] support reading resolutions from EDID Tian Tao 2020-12-04 1:23 ` Tian Tao -- strict thread matches above, loose matches on Subject: below -- 2020-11-12 1:36 [PATCH] drm/nouveau: Use vmemdup_user() Tian Tao 2020-11-12 1:36 ` Tian Tao 2020-11-12 1:36 ` Tian Tao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1607044999-47666-7-git-send-email-tiantao6@hisilicon.com \ --to=tiantao6@hisilicon.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kraxel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=tzimmermann@suse.de \ --cc=xinliang.liu@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.