* [PATCH] irqchip/loongson-htpic: Fix build warnings
@ 2020-12-05 9:15 Huacai Chen
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Huacai Chen
2020-12-11 15:01 ` Marc Zyngier
0 siblings, 2 replies; 5+ messages in thread
From: Huacai Chen @ 2020-12-05 9:15 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-mips, Jiaxun Yang, Huacai Chen
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
>> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~
drivers/irqchip/irq-loongson-htpic.c: At top level:
>> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
Fixes: a93f1d903fa34fc2c5d9fa450bd ("irqchip: Add driver for Loongson-3 HyperTransport PIC controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
---
drivers/irqchip/irq-loongson-htpic.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c
index 63f7280..1b801c4 100644
--- a/drivers/irqchip/irq-loongson-htpic.c
+++ b/drivers/irqchip/irq-loongson-htpic.c
@@ -59,11 +59,10 @@ static void htpic_reg_init(void)
int i;
for (i = 0; i < HTINT_NUM_VECTORS; i++) {
- uint32_t val;
-
/* Disable all HT Vectors */
writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4);
- val = readl(htpic->base + i * 0x4);
+ /* Read back to force write */
+ (void) readl(htpic->base + i * 0x4);
/* Ack all possible pending IRQs */
writel(GENMASK(31, 0), htpic->base + i * 0x4);
}
@@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = {
.resume = htpic_resume,
};
-int __init htpic_of_init(struct device_node *node, struct device_node *parent)
+static int __init htpic_of_init(struct device_node *node, struct device_node *parent)
{
unsigned int parent_irq[4];
int i, err;
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/loongson-htpic: Fix build warnings
2020-12-05 9:15 [PATCH] irqchip/loongson-htpic: Fix build warnings Huacai Chen
@ 2020-12-11 14:58 ` irqchip-bot for Huacai Chen
2020-12-11 15:01 ` Marc Zyngier
1 sibling, 0 replies; 5+ messages in thread
From: irqchip-bot for Huacai Chen @ 2020-12-11 14:58 UTC (permalink / raw)
To: linux-kernel; +Cc: kernel test robot, Huacai Chen, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 3ee36352e26935c7e8145eb4e7ed38b536ca01fc
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3ee36352e26935c7e8145eb4e7ed38b536ca01fc
Author: Huacai Chen <chenhuacai@kernel.org>
AuthorDate: Sat, 05 Dec 2020 17:15:44 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 11 Dec 2020 14:40:17
irqchip/loongson-htpic: Fix build warnings
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
>> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~
drivers/irqchip/irq-loongson-htpic.c: At top level:
>> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
Fixes: a93f1d903fa34fc2c5d9fa450bd ("irqchip: Add driver for Loongson-3 HyperTransport PIC controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1607159744-995-1-git-send-email-chenhuacai@kernel.org
---
drivers/irqchip/irq-loongson-htpic.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c
index 63f7280..1b801c4 100644
--- a/drivers/irqchip/irq-loongson-htpic.c
+++ b/drivers/irqchip/irq-loongson-htpic.c
@@ -59,11 +59,10 @@ static void htpic_reg_init(void)
int i;
for (i = 0; i < HTINT_NUM_VECTORS; i++) {
- uint32_t val;
-
/* Disable all HT Vectors */
writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4);
- val = readl(htpic->base + i * 0x4);
+ /* Read back to force write */
+ (void) readl(htpic->base + i * 0x4);
/* Ack all possible pending IRQs */
writel(GENMASK(31, 0), htpic->base + i * 0x4);
}
@@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = {
.resume = htpic_resume,
};
-int __init htpic_of_init(struct device_node *node, struct device_node *parent)
+static int __init htpic_of_init(struct device_node *node, struct device_node *parent)
{
unsigned int parent_irq[4];
int i, err;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/loongson-htpic: Fix build warnings
2020-12-05 9:15 [PATCH] irqchip/loongson-htpic: Fix build warnings Huacai Chen
@ 2020-12-11 15:01 ` Marc Zyngier
2020-12-11 15:01 ` Marc Zyngier
1 sibling, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2020-12-11 15:01 UTC (permalink / raw)
To: shawnguo, linux, leoyang.li, mark.rutland, zhiqiang.hou,
Biwen Li, robh+dt, tglx, Huacai Chen, Thomas Bogendoerfer
Cc: xiaobo.xie, Hou Zhiqiang, devicetree, linux-arm-kernel, Biwen Li,
linux-kernel, jiafei.pan, linux-mips, Jiaxun Yang
On Sat, 5 Dec 2020 17:15:44 +0800, Huacai Chen wrote:
> Fix build warnings as below:
>
> drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
> >> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> 62 | uint32_t val;
> | ^~~
> drivers/irqchip/irq-loongson-htpic.c: At top level:
> >> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
> 84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
> | ^~~~~~~~~~~~~
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/loongson-htpic: Fix build warnings
commit: 3ee36352e26935c7e8145eb4e7ed38b536ca01fc
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/loongson-htpic: Fix build warnings
@ 2020-12-11 15:01 ` Marc Zyngier
0 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2020-12-11 15:01 UTC (permalink / raw)
To: shawnguo, linux, leoyang.li, mark.rutland, zhiqiang.hou,
Biwen Li, robh+dt, tglx, Huacai Chen, Thomas Bogendoerfer
Cc: devicetree, Biwen Li, Hou Zhiqiang, linux-kernel, Jiaxun Yang,
xiaobo.xie, jiafei.pan, linux-mips, linux-arm-kernel
On Sat, 5 Dec 2020 17:15:44 +0800, Huacai Chen wrote:
> Fix build warnings as below:
>
> drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
> >> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> 62 | uint32_t val;
> | ^~~
> drivers/irqchip/irq-loongson-htpic.c: At top level:
> >> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
> 84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
> | ^~~~~~~~~~~~~
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/loongson-htpic: Fix build warnings
commit: 3ee36352e26935c7e8145eb4e7ed38b536ca01fc
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] irqchip/loongson-htpic: Fix build warnings
@ 2020-12-05 9:05 Huacai Chen
0 siblings, 0 replies; 5+ messages in thread
From: Huacai Chen @ 2020-12-05 9:05 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-mips, Jiaxun Yang, Huacai Chen
Fix build warnings as below:
drivers/irqchip/irq-loongson-htpic.c: In function 'htpic_reg_init':
>> drivers/irqchip/irq-loongson-htpic.c:62:12: warning: variable 'val' set but not used [-Wunused-but-set-variable]
62 | uint32_t val;
| ^~~
drivers/irqchip/irq-loongson-htpic.c: At top level:
>> drivers/irqchip/irq-loongson-htpic.c:84:12: warning: no previous prototype for 'htpic_of_init' [-Wmissing-prototypes]
84 | int __init htpic_of_init(struct device_node *node, struct device_node *parent)
| ^~~~~~~~~~~~~
Fixes: a93f1d903fa34fc2c5d9fa450bd ("irqchip: Add driver for Loongson-3 HyperTransport PIC controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhuacai@kernel.org>
---
drivers/irqchip/irq-loongson-htpic.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c
index 63f7280..1b801c4 100644
--- a/drivers/irqchip/irq-loongson-htpic.c
+++ b/drivers/irqchip/irq-loongson-htpic.c
@@ -59,11 +59,10 @@ static void htpic_reg_init(void)
int i;
for (i = 0; i < HTINT_NUM_VECTORS; i++) {
- uint32_t val;
-
/* Disable all HT Vectors */
writel(0x0, htpic->base + HTINT_EN_OFF + i * 0x4);
- val = readl(htpic->base + i * 0x4);
+ /* Read back to force write */
+ (void) readl(htpic->base + i * 0x4);
/* Ack all possible pending IRQs */
writel(GENMASK(31, 0), htpic->base + i * 0x4);
}
@@ -81,7 +80,7 @@ struct syscore_ops htpic_syscore_ops = {
.resume = htpic_resume,
};
-int __init htpic_of_init(struct device_node *node, struct device_node *parent)
+static int __init htpic_of_init(struct device_node *node, struct device_node *parent)
{
unsigned int parent_irq[4];
int i, err;
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-11 15:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-05 9:15 [PATCH] irqchip/loongson-htpic: Fix build warnings Huacai Chen
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Huacai Chen
2020-12-11 15:01 ` [PATCH] " Marc Zyngier
2020-12-11 15:01 ` Marc Zyngier
-- strict thread matches above, loose matches on Subject: below --
2020-12-05 9:05 Huacai Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.