* [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> @ 2020-12-07 12:14 Zou Wei 2020-12-08 19:22 ` Jakub Kicinski 0 siblings, 1 reply; 6+ messages in thread From: Zou Wei @ 2020-12-07 12:14 UTC (permalink / raw) To: saeedm, leon, davem, kuba; +Cc: netdev, linux-rdma, linux-kernel, Zou Wei Remove including <generated/utsrelease.h> that don't need it. Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 989c70c..82ecc161 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -30,7 +30,6 @@ * SOFTWARE. */ -#include <generated/utsrelease.h> #include <linux/mlx5/fs.h> #include <net/switchdev.h> #include <net/pkt_cls.h> -- 2.6.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> 2020-12-07 12:14 [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> Zou Wei @ 2020-12-08 19:22 ` Jakub Kicinski 2020-12-09 6:21 ` Leon Romanovsky 0 siblings, 1 reply; 6+ messages in thread From: Jakub Kicinski @ 2020-12-08 19:22 UTC (permalink / raw) To: Zou Wei; +Cc: saeedm, leon, davem, netdev, linux-rdma, linux-kernel On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > Remove including <generated/utsrelease.h> that don't need it. > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > index 989c70c..82ecc161 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > @@ -30,7 +30,6 @@ > * SOFTWARE. > */ > > -#include <generated/utsrelease.h> > #include <linux/mlx5/fs.h> > #include <net/switchdev.h> > #include <net/pkt_cls.h> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’? 66 | strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); | ^~~~~~~~~~~ | CSS_RELEASED drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each undeclared identifier is reported only once for each function it appears in make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error 1 make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2 make[4]: *** [drivers/net/ethernet/mellanox] Error 2 make[3]: *** [drivers/net/ethernet] Error 2 make[2]: *** [drivers/net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers] Error 2 make: *** [__sub-make] Error 2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> 2020-12-08 19:22 ` Jakub Kicinski @ 2020-12-09 6:21 ` Leon Romanovsky 2020-12-09 6:42 ` 答复: " Zouwei (Samuel) 2020-12-09 17:04 ` Jakub Kicinski 0 siblings, 2 replies; 6+ messages in thread From: Leon Romanovsky @ 2020-12-09 6:21 UTC (permalink / raw) To: Jakub Kicinski; +Cc: Zou Wei, saeedm, davem, netdev, linux-rdma, linux-kernel On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > Remove including <generated/utsrelease.h> that don't need it. > > > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > index 989c70c..82ecc161 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > @@ -30,7 +30,6 @@ > > * SOFTWARE. > > */ > > > > -#include <generated/utsrelease.h> > > #include <linux/mlx5/fs.h> > > #include <net/switchdev.h> > > #include <net/pkt_cls.h> Jakub, You probably doesn't have latest net-next. In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));" line. The patch is ok, but should have Fixes line. Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") Thanks > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’: > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’? > 66 | strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); > | ^~~~~~~~~~~ > | CSS_RELEASED > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each undeclared identifier is reported only once for each function it appears in > make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error 1 > make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2 > make[4]: *** [drivers/net/ethernet/mellanox] Error 2 > make[3]: *** [drivers/net/ethernet] Error 2 > make[2]: *** [drivers/net] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [drivers] Error 2 > make: *** [__sub-make] Error 2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* 答复: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> 2020-12-09 6:21 ` Leon Romanovsky @ 2020-12-09 6:42 ` Zouwei (Samuel) 2020-12-09 17:04 ` Jakub Kicinski 1 sibling, 0 replies; 6+ messages in thread From: Zouwei (Samuel) @ 2020-12-09 6:42 UTC (permalink / raw) To: Leon Romanovsky, Jakub Kicinski Cc: saeedm, davem, netdev, linux-rdma, linux-kernel ok, I will add the Fixes line and send the v2 soon. -----邮件原件----- 发件人: Leon Romanovsky [mailto:leon@kernel.org] 发送时间: 2020年12月9日 14:21 收件人: Jakub Kicinski <kuba@kernel.org> 抄送: Zouwei (Samuel) <zou_wei@huawei.com>; saeedm@nvidia.com; davem@davemloft.net; netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > Remove including <generated/utsrelease.h> that don't need it. > > > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > index 989c70c..82ecc161 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > @@ -30,7 +30,6 @@ > > * SOFTWARE. > > */ > > > > -#include <generated/utsrelease.h> > > #include <linux/mlx5/fs.h> > > #include <net/switchdev.h> > > #include <net/pkt_cls.h> Jakub, You probably doesn't have latest net-next. In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));" line. The patch is ok, but should have Fixes line. Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") Thanks > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_rep_get_drvinfo’: > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: error: ‘UTS_RELEASE’ undeclared (first use in this function); did you mean ‘CSS_RELEASED’? > 66 | strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); > | ^~~~~~~~~~~ > | CSS_RELEASED > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:66:28: note: each > undeclared identifier is reported only once for each function it > appears in > make[6]: *** [drivers/net/ethernet/mellanox/mlx5/core/en_rep.o] Error > 1 > make[5]: *** [drivers/net/ethernet/mellanox/mlx5/core] Error 2 > make[4]: *** [drivers/net/ethernet/mellanox] Error 2 > make[3]: *** [drivers/net/ethernet] Error 2 > make[2]: *** [drivers/net] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [drivers] Error 2 > make: *** [__sub-make] Error 2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> 2020-12-09 6:21 ` Leon Romanovsky 2020-12-09 6:42 ` 答复: " Zouwei (Samuel) @ 2020-12-09 17:04 ` Jakub Kicinski 2020-12-09 21:01 ` Jason Gunthorpe 1 sibling, 1 reply; 6+ messages in thread From: Jakub Kicinski @ 2020-12-09 17:04 UTC (permalink / raw) To: Leon Romanovsky; +Cc: Zou Wei, saeedm, davem, netdev, linux-rdma, linux-kernel On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote: > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > > Remove including <generated/utsrelease.h> that don't need it. > > > > > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > > > --- > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > index 989c70c..82ecc161 100644 > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > @@ -30,7 +30,6 @@ > > > * SOFTWARE. > > > */ > > > > > > -#include <generated/utsrelease.h> > > > #include <linux/mlx5/fs.h> > > > #include <net/switchdev.h> > > > #include <net/pkt_cls.h> > > Jakub, > > You probably doesn't have latest net-next. > > In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and > name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, > sizeof(drvinfo->version));" line. > > The patch is ok, but should have Fixes line. > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") Hm. Pretty sure our build bot gets a fresh copy before testing. Must had been some timing issue, perhaps? Looks like the commit came in with the auxbus merge. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> 2020-12-09 17:04 ` Jakub Kicinski @ 2020-12-09 21:01 ` Jason Gunthorpe 0 siblings, 0 replies; 6+ messages in thread From: Jason Gunthorpe @ 2020-12-09 21:01 UTC (permalink / raw) To: Jakub Kicinski Cc: Leon Romanovsky, Zou Wei, saeedm, davem, netdev, linux-rdma, linux-kernel On Wed, Dec 09, 2020 at 09:04:46AM -0800, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote: > > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > > > Remove including <generated/utsrelease.h> that don't need it. > > > > > > > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > > index 989c70c..82ecc161 100644 > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > > @@ -30,7 +30,6 @@ > > > > * SOFTWARE. > > > > */ > > > > > > > > -#include <generated/utsrelease.h> > > > > #include <linux/mlx5/fs.h> > > > > #include <net/switchdev.h> > > > > #include <net/pkt_cls.h> > > > > Jakub, > > > > You probably doesn't have latest net-next. > > > > In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and > > name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, > > sizeof(drvinfo->version));" line. > > > > The patch is ok, but should have Fixes line. > > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") > > Hm. Pretty sure our build bot gets a fresh copy before testing. > Must had been some timing issue, perhaps? Looks like the commit > came in with the auxbus merge. mlx5-next is in linux-next independently so people will be sending fixes against stuff in linux-next before it hits net-next. Jason ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-09 21:02 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-07 12:14 [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h> Zou Wei 2020-12-08 19:22 ` Jakub Kicinski 2020-12-09 6:21 ` Leon Romanovsky 2020-12-09 6:42 ` 答复: " Zouwei (Samuel) 2020-12-09 17:04 ` Jakub Kicinski 2020-12-09 21:01 ` Jason Gunthorpe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.