[PATCH v5 0/2] dm: core: drivers: add function uclass_probe_all()

[PATCH v5 0/2] dm: core: drivers: add function uclass_probe_all()

[Vabhav Sharma]

From: Vabhav Sharma <vabhav.sharma@nxp.com>

- Add common method to probe devices belonging to same uclass 
- Add config in serial uclass to support optional inclusion of uclass_probe_all
- Enable support for available serial devices probe

Changes for v5:
Incorporated review comments from Sean Anderson
  - Added error check
  - Replaced for() loop with while() loop 
  - Updated macro description
  - Modified function description
  
Changes for v4:
Incorporated review comments from Simon  
  - Removed if (dev)..  conditional check in function uclass_probe_all()

Changes for v3:
  Incorporated Simon and Stephan review comment
  - Define generic function uclass_probe_all(enum uclass_id)
    in drivers/core/uclass.c
  - Added the function in caller of serial_find_console_or_panic()
  - Removed repeated sequence with generic function call uclass_probe_all()

Changes for v2:
  Incorporated Stefan review comment,Update #ifdef with macro if (IS_ENABLED).

Vabhav Sharma (2):
  dm: core: add function uclass_probe_all() to probe all devices
  drivers: serial: probe all uart devices

 drivers/core/uclass.c          | 19 +++++++++++++++++++
 drivers/serial/Kconfig         | 16 ++++++++++++++++
 drivers/serial/serial-uclass.c |  9 +++++++++
 include/dm/uclass.h            | 11 +++++++++++
 4 files changed, 55 insertions(+)

-- 
2.7.4

[PATCH v5 1/2] dm: core: add function uclass_probe_all() to probe all devices

[Vabhav Sharma]

From: Vabhav Sharma <vabhav.sharma@nxp.com>

Support a common method to probe all devices associated with uclass.

This includes data structures and code for finding the first device and
looping for remaining devices associated with uclasses (groups of devices
with the same purpose, e.g. all SERIAL ports will be in the same uclass).

An example is SBSA compliant PL011 UART IP, where firmware does the serial
port initialization and prepare uart device to let the kernel use it for
sending and reveiving the characters.SERIAL uclass will use this function
to initialize PL011 UART ports.

The feature is enabled with CONFIG_DM.

Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
--
  v5:
  Incorporated review comments of Sean Anderson
  Replace for loop with while loop
  Error check added
  Function description updated

  v4:
  Incorporated review comments of Simon
  Removed if (dev)..  conditional check

  v3:
  Incorporated review comments of Stephan,Simon
  Related discussion https://patchwork.ozlabs.org/project/uboot/patch/1601400
385-11854-1-git-send-email-vabhav.sharma at oss.nxp.com/
---
 drivers/core/uclass.c | 19 +++++++++++++++++++
 include/dm/uclass.h   | 11 +++++++++++
 2 files changed, 30 insertions(+)

diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
index c3f1b73..27972ef 100644
--- a/drivers/core/uclass.c
+++ b/drivers/core/uclass.c
@@ -792,6 +792,25 @@ int uclass_pre_remove_device(struct udevice *dev)
 }
 #endif
 
+int uclass_probe_all(enum uclass_id id)
+{
+	struct udevice *dev;
+	int ret;
+
+	ret = uclass_first_device(id, &dev);
+	if (ret || !dev)
+		return ret;
+
+	/* Scanning uclass to probe all devices */
+	while (dev) {
+		ret = uclass_next_device(&dev);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+
 UCLASS_DRIVER(nop) = {
 	.id		= UCLASS_NOP,
 	.name		= "nop",
diff --git a/include/dm/uclass.h b/include/dm/uclass.h
index 7188304..6bd33d4 100644
--- a/include/dm/uclass.h
+++ b/include/dm/uclass.h
@@ -381,6 +381,17 @@ int uclass_first_device_drvdata(enum uclass_id id, ulong driver_data,
 int uclass_resolve_seq(struct udevice *dev);
 
 /**
+ * uclass_probe_all() - Probe all devices based on an uclass ID
+ *
+ * This function probes all devices associated with a uclass by
+ * looking for its ID.
+ *
+ * @id: uclass ID to look up
+ * @return 0 if OK, other -ve on error
+ */
+int uclass_probe_all(enum uclass_id id);
+
+/**
  * uclass_id_foreach_dev() - Helper function to iteration through devices
  *
  * This creates a for() loop which works through the available devices in
-- 
2.7.4

[PATCH v5 2/2] drivers: serial: probe all uart devices

[Vabhav Sharma]

From: Vabhav Sharma <vabhav.sharma@nxp.com>

U-Boot DM model probe only single device at a time
which is enabled and configured using device tree
or platform data method.

PL011 UART IP is SBSA compliant and firmware does the
serial port set-up, initialization and let the kernel use
UART port for sending and receiving characters.

Normally software talk to one serial port time but some
LayerScape platform require all the UART devices enabled
in Linux for various use case.

Adding support to probe all enabled serial devices like SBSA
compliant PL011 UART ports probe and initialization by firmware.

Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
--
v5:
  Incorporated review comments from Sean Anderson
  - Modified the macro description
  - Added error check

v3:
  Incorporated Simon and Stephan review comment
  - Define generic function uclass_probe_all(enum uclass_id)
    in drivers/core/uclass.c
  - Added the function in caller of serial_find_console_or_panic()
  - Removed repeated sequence with generic function call uclass_probe_all()
  - Dependent on other patch [PATCH] dm: core: add function uclass_probe_all()
    to probe all devices

v2:
  Incorporated Stefan review comment, Update #ifdef with macro
  if (IS_ENABLED)..
---
 drivers/serial/Kconfig         | 16 ++++++++++++++++
 drivers/serial/serial-uclass.c |  9 +++++++++
 2 files changed, 25 insertions(+)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index b4805a2..1294943 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -134,6 +134,22 @@ config SERIAL_SEARCH_ALL
 
 	  If unsure, say N.
 
+config SERIAL_PROBE_ALL
+	bool "Probe all available serial devices"
+	depends on DM_SERIAL
+	default n
+	help
+	  The serial subsystem only probes for a single serial device,
+	  but does not probe for other remaining serial devices.
+	  With this option set, we make probing and searching for
+	  all available devices optional.
+	  Normally, U-Boot talks to one serial port at a time, but SBSA
+	  compliant UART devices like PL011 require initialization
+	  by firmware and to let the kernel use serial port for sending
+	  and receiving the characters.
+
+	  If unsure, say N.
+
 config SPL_DM_SERIAL
 	bool "Enable Driver Model for serial drivers in SPL"
 	depends on DM_SERIAL && SPL_DM
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index f3c25d4..48e0080 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -172,6 +172,15 @@ int serial_init(void)
 /* Called after relocation */
 int serial_initialize(void)
 {
+	/* Scanning uclass to probe devices */
+	if (IS_ENABLED(CONFIG_SERIAL_PROBE_ALL)) {
+		int ret;
+
+		ret  = uclass_probe_all(UCLASS_SERIAL);
+		if (ret)
+			return ret;
+	}
+
 	return serial_init();
 }
 
-- 
2.7.4

[PATCH v5 0/2] dm: core: drivers: add function uclass_probe_all()

[Vabhav Sharma]

Dear Sean Anderson,
I have incorporated all your review comments and request your review/ack to merge the changes

Regards,
Vabhav

> -----Original Message-----
> From: Vabhav Sharma <vabhav.sharma@oss.nxp.com>
> Sent: Wednesday, December 9, 2020 10:42 AM
> To: sjg at chromium.org; sr at denx.de; seanga2 at gmail.com
> Cc: u-boot at lists.denx.de; Varun Sethi <V.Sethi@nxp.com>;
> andre.przywara at arm.com; Vabhav Sharma <vabhav.sharma@nxp.com>
> Subject: [PATCH v5 0/2] dm: core: drivers: add function uclass_probe_all()
> 
> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> 
> - Add common method to probe devices belonging to same uclass
> - Add config in serial uclass to support optional inclusion of uclass_probe_all
> - Enable support for available serial devices probe
> 
> Changes for v5:
> Incorporated review comments from Sean Anderson
>   - Added error check
>   - Replaced for() loop with while() loop
>   - Updated macro description
>   - Modified function description
> 
> Changes for v4:
> Incorporated review comments from Simon
>   - Removed if (dev)..  conditional check in function uclass_probe_all()
> 
> Changes for v3:
>   Incorporated Simon and Stephan review comment
>   - Define generic function uclass_probe_all(enum uclass_id)
>     in drivers/core/uclass.c
>   - Added the function in caller of serial_find_console_or_panic()
>   - Removed repeated sequence with generic function call uclass_probe_all()
> 
> Changes for v2:
>   Incorporated Stefan review comment,Update #ifdef with macro if
> (IS_ENABLED).
> 
> Vabhav Sharma (2):
>   dm: core: add function uclass_probe_all() to probe all devices
>   drivers: serial: probe all uart devices
> 
>  drivers/core/uclass.c          | 19 +++++++++++++++++++
>  drivers/serial/Kconfig         | 16 ++++++++++++++++
>  drivers/serial/serial-uclass.c |  9 +++++++++
>  include/dm/uclass.h            | 11 +++++++++++
>  4 files changed, 55 insertions(+)
> 
> --
> 2.7.4

[PATCH v5 1/2] dm: core: add function uclass_probe_all() to probe all devices

[Sean Anderson]

On 12/9/20 12:12 AM, Vabhav Sharma wrote:
> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> 
> Support a common method to probe all devices associated with uclass.
> 
> This includes data structures and code for finding the first device and
> looping for remaining devices associated with uclasses (groups of devices
> with the same purpose, e.g. all SERIAL ports will be in the same uclass).
> 
> An example is SBSA compliant PL011 UART IP, where firmware does the serial
> port initialization and prepare uart device to let the kernel use it for
> sending and reveiving the characters.SERIAL uclass will use this function
> to initialize PL011 UART ports.
> 
> The feature is enabled with CONFIG_DM.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> --
>    v5:
>    Incorporated review comments of Sean Anderson
>    Replace for loop with while loop
>    Error check added
>    Function description updated
> 
>    v4:
>    Incorporated review comments of Simon
>    Removed if (dev)..  conditional check
> 
>    v3:
>    Incorporated review comments of Stephan,Simon
>    Related discussion https://patchwork.ozlabs.org/project/uboot/patch/1601400
> 385-11854-1-git-send-email-vabhav.sharma at oss.nxp.com/
> ---
>   drivers/core/uclass.c | 19 +++++++++++++++++++
>   include/dm/uclass.h   | 11 +++++++++++
>   2 files changed, 30 insertions(+)
> 
> diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
> index c3f1b73..27972ef 100644
> --- a/drivers/core/uclass.c
> +++ b/drivers/core/uclass.c
> @@ -792,6 +792,25 @@ int uclass_pre_remove_device(struct udevice *dev)
>   }
>   #endif
>   
> +int uclass_probe_all(enum uclass_id id)
> +{
> +	struct udevice *dev;
> +	int ret;
> +
> +	ret = uclass_first_device(id, &dev);
> +	if (ret || !dev)
> +		return ret;
> +
> +	/* Scanning uclass to probe all devices */
> +	while (dev) {
> +		ret = uclass_next_device(&dev);
> +		if (ret)
> +			return ret;
> +	}
> +
> +	return 0;
> +}
> +
>   UCLASS_DRIVER(nop) = {
>   	.id		= UCLASS_NOP,
>   	.name		= "nop",
> diff --git a/include/dm/uclass.h b/include/dm/uclass.h
> index 7188304..6bd33d4 100644
> --- a/include/dm/uclass.h
> +++ b/include/dm/uclass.h
> @@ -381,6 +381,17 @@ int uclass_first_device_drvdata(enum uclass_id id, ulong driver_data,
>   int uclass_resolve_seq(struct udevice *dev);
>   
>   /**
> + * uclass_probe_all() - Probe all devices based on an uclass ID
> + *
> + * This function probes all devices associated with a uclass by
> + * looking for its ID.
> + *
> + * @id: uclass ID to look up
> + * @return 0 if OK, other -ve on error
> + */
> +int uclass_probe_all(enum uclass_id id);
> +
> +/**
>    * uclass_id_foreach_dev() - Helper function to iteration through devices
>    *
>    * This creates a for() loop which works through the available devices in
> 

Reviewed-by: Sean Anderson <seanga2@gmail.com>

[PATCH v5 2/2] drivers: serial: probe all uart devices

[Sean Anderson]

On 12/9/20 12:12 AM, Vabhav Sharma wrote:
> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> 
> U-Boot DM model probe only single device at a time
> which is enabled and configured using device tree
> or platform data method.
> 
> PL011 UART IP is SBSA compliant and firmware does the
> serial port set-up, initialization and let the kernel use
> UART port for sending and receiving characters.
> 
> Normally software talk to one serial port time but some
> LayerScape platform require all the UART devices enabled
> in Linux for various use case.
> 
> Adding support to probe all enabled serial devices like SBSA
> compliant PL011 UART ports probe and initialization by firmware.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> --
> v5:
>    Incorporated review comments from Sean Anderson
>    - Modified the macro description
>    - Added error check
> 
> v3:
>    Incorporated Simon and Stephan review comment
>    - Define generic function uclass_probe_all(enum uclass_id)
>      in drivers/core/uclass.c
>    - Added the function in caller of serial_find_console_or_panic()
>    - Removed repeated sequence with generic function call uclass_probe_all()
>    - Dependent on other patch [PATCH] dm: core: add function uclass_probe_all()
>      to probe all devices
> 
> v2:
>    Incorporated Stefan review comment, Update #ifdef with macro
>    if (IS_ENABLED)..
> ---
>   drivers/serial/Kconfig         | 16 ++++++++++++++++
>   drivers/serial/serial-uclass.c |  9 +++++++++
>   2 files changed, 25 insertions(+)
> 
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index b4805a2..1294943 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -134,6 +134,22 @@ config SERIAL_SEARCH_ALL
>   
>   	  If unsure, say N.
>   
> +config SERIAL_PROBE_ALL
> +	bool "Probe all available serial devices"
> +	depends on DM_SERIAL
> +	default n
> +	help
> +	  The serial subsystem only probes for a single serial device,
> +	  but does not probe for other remaining serial devices.
> +	  With this option set, we make probing and searching for
> +	  all available devices optional.
> +	  Normally, U-Boot talks to one serial port at a time, but SBSA
> +	  compliant UART devices like PL011 require initialization
> +	  by firmware and to let the kernel use serial port for sending

Nit: "and" or "to" but not both

> +	  and receiving the characters.
> +
> +	  If unsure, say N.
> +
>   config SPL_DM_SERIAL
>   	bool "Enable Driver Model for serial drivers in SPL"
>   	depends on DM_SERIAL && SPL_DM
> diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
> index f3c25d4..48e0080 100644
> --- a/drivers/serial/serial-uclass.c
> +++ b/drivers/serial/serial-uclass.c
> @@ -172,6 +172,15 @@ int serial_init(void)
>   /* Called after relocation */
>   int serial_initialize(void)
>   {
> +	/* Scanning uclass to probe devices */
> +	if (IS_ENABLED(CONFIG_SERIAL_PROBE_ALL)) {
> +		int ret;
> +
> +		ret  = uclass_probe_all(UCLASS_SERIAL);
> +		if (ret)
> +			return ret;
> +	}
> +
>   	return serial_init();
>   }
>  
Reviewed-by: Sean Anderson <seanga2@gmail.com>

[PATCH v5 1/2] dm: core: add function uclass_probe_all() to probe all devices

[Tom Rini]

On Wed, Dec 09, 2020 at 10:42:03AM +0530, Vabhav Sharma wrote:

> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> 
> Support a common method to probe all devices associated with uclass.
> 
> This includes data structures and code for finding the first device and
> looping for remaining devices associated with uclasses (groups of devices
> with the same purpose, e.g. all SERIAL ports will be in the same uclass).
> 
> An example is SBSA compliant PL011 UART IP, where firmware does the serial
> port initialization and prepare uart device to let the kernel use it for
> sending and reveiving the characters.SERIAL uclass will use this function
> to initialize PL011 UART ports.
> 
> The feature is enabled with CONFIG_DM.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/ee113752/attachment.sig>

[PATCH v5 2/2] drivers: serial: probe all uart devices

[Tom Rini]

On Wed, Dec 09, 2020 at 10:42:04AM +0530, Vabhav Sharma wrote:

> From: Vabhav Sharma <vabhav.sharma@nxp.com>
> 
> U-Boot DM model probe only single device at a time
> which is enabled and configured using device tree
> or platform data method.
> 
> PL011 UART IP is SBSA compliant and firmware does the
> serial port set-up, initialization and let the kernel use
> UART port for sending and receiving characters.
> 
> Normally software talk to one serial port time but some
> LayerScape platform require all the UART devices enabled
> in Linux for various use case.
> 
> Adding support to probe all enabled serial devices like SBSA
> compliant PL011 UART ports probe and initialization by firmware.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/116eb41b/attachment.sig>