From: Benjamin Marzinski <bmarzins@redhat.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Martin Wilck <Martin.Wilck@suse.com>
Subject: [dm-devel] [PATCH 5/6] multipathd: Fix multipathd stopping on shutdown
Date: Fri, 18 Dec 2020 17:06:41 -0600 [thread overview]
Message-ID: <1608332802-9720-6-git-send-email-bmarzins@redhat.com> (raw)
In-Reply-To: <1608332802-9720-1-git-send-email-bmarzins@redhat.com>
According to man "systemd.special"
"shutdown.target: ... Services that shall be terminated on system
shutdown shall add Conflicts= and Before= dependencies to this unit for
their service unit, which is implicitly done when
DefaultDependencies=yes is set (the default)."
multipathd.service sets DefaultDependencies=no and includes the
Conflits= dependency, but not the Before= one. This can cause multipathd
to continue running past when it is supposed to during shutdown.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
multipathd/multipathd.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index ba24983e..7d547fa7 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -2,7 +2,7 @@
Description=Device-Mapper Multipath Device Controller
Wants=systemd-udev-trigger.service systemd-udev-settle.service
Before=iscsi.service iscsid.service lvm2-activation-early.service
-Before=local-fs-pre.target blk-availability.service
+Before=local-fs-pre.target blk-availability.service shutdown.target
After=multipathd.socket systemd-udev-trigger.service systemd-udev-settle.service
DefaultDependencies=no
Conflicts=shutdown.target
--
2.17.2
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-12-18 23:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 23:06 [dm-devel] [PATCH 0/6] More misc multipath patches Benjamin Marzinski
2020-12-18 23:06 ` [dm-devel] [PATCH 1/6] mpathpersist: Fix Register and Ignore with 0x00 SARK Benjamin Marzinski
2020-12-18 23:18 ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 2/6] mpathpersist: update prkeys file on changing registrations Benjamin Marzinski
2020-12-18 23:23 ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 3/6] libmultipath: warn about missing braces at end of multipath.conf Benjamin Marzinski
2020-12-18 23:28 ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 4/6] libmultipath: ignore multipaths sections without wwid option Benjamin Marzinski
2020-12-18 23:30 ` Martin Wilck
2021-01-04 19:24 ` Benjamin Marzinski
2020-12-18 23:06 ` Benjamin Marzinski [this message]
2020-12-18 23:31 ` [dm-devel] [PATCH 5/6] multipathd: Fix multipathd stopping on shutdown Martin Wilck
2021-01-27 1:16 ` Benjamin Marzinski
2021-01-27 9:41 ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 6/6] multipath.conf.5: Improve checker_timeout description Benjamin Marzinski
2020-12-18 23:56 ` Martin Wilck
2021-01-05 0:33 ` Benjamin Marzinski
2021-01-05 10:55 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608332802-9720-6-git-send-email-bmarzins@redhat.com \
--to=bmarzins@redhat.com \
--cc=Martin.Wilck@suse.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.