All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 6/6] multipath.conf.5: Improve checker_timeout description
Date: Mon, 4 Jan 2021 18:33:42 -0600	[thread overview]
Message-ID: <20210105003342.GT3103@octiron.msp.redhat.com> (raw)
In-Reply-To: <28b07148b5249f05e6509d5a34ed145a23975be4.camel@suse.com>

On Fri, Dec 18, 2020 at 11:56:47PM +0000, Martin Wilck wrote:
> On Fri, 2020-12-18 at 17:06 -0600, Benjamin Marzinski wrote:
> > I was asked to explain how checker_timeout works for checkers like
> > directio, that don't issue scsi commands with an explicit timeout
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> > ---
> >  multipath/multipath.conf.5 | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
> > index ea66a01e..c7c4184b 100644
> > --- a/multipath/multipath.conf.5
> > +++ b/multipath/multipath.conf.5
> > @@ -639,8 +639,13 @@ The default is: \fBno\fR
> >  .
> >  .TP
> >  .B checker_timeout
> > -Specify the timeout to use for path checkers and prioritizers that
> > issue SCSI
> > -commands with an explicit timeout, in seconds.
> > +Specify the timeout to use for path checkers and prioritizers, in
> > seconds.
> > +Only prioritizers that issue scsi commands use checker_timeout. 
> > Checkers
> > +that support an asynchronous mode (\fItur\fR and \fIdirectio\fR),
> > will
> > +return shortly after being called by multipathd, regardless of
> > whether the
> > +storage array responds. If the storage array hasn't responded,
> > mulitpathd will
> 
> typo
> 
> > +check for a response every second, until \fIchecker_timeout\fR
> > seconds have
> > +elapsed.
> 
> This is a bit confusing IMHO. Most importantly, checkers will consider
> a path down if it doesn't respond to the checker command after the
> given timeout. The async behavior doesn't fit too well into this
> section. Maybe we should mention and explain the async property in the
> path_checkers section, and only refer to that here.

Sounds reasonable.

> (Btw is the directio checker still deprecated after all the work you
> recently put into it? The man page still says so).

No. I'll change that.  There are times when devices claim to be ready
with the tur checker, when in truth, IO to them will fail.  In these
cases, the directio checker is the best way to avoid having paths
bouncing up and down.

-Ben

> 
> Regards,
> Martin
> 
> -- 
> Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
> SUSE  Software Solutions Germany GmbH
> HRB 36809, AG Nürnberg GF: Felix
> Imendörffer
> 

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-01-05  0:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 23:06 [dm-devel] [PATCH 0/6] More misc multipath patches Benjamin Marzinski
2020-12-18 23:06 ` [dm-devel] [PATCH 1/6] mpathpersist: Fix Register and Ignore with 0x00 SARK Benjamin Marzinski
2020-12-18 23:18   ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 2/6] mpathpersist: update prkeys file on changing registrations Benjamin Marzinski
2020-12-18 23:23   ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 3/6] libmultipath: warn about missing braces at end of multipath.conf Benjamin Marzinski
2020-12-18 23:28   ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 4/6] libmultipath: ignore multipaths sections without wwid option Benjamin Marzinski
2020-12-18 23:30   ` Martin Wilck
2021-01-04 19:24     ` Benjamin Marzinski
2020-12-18 23:06 ` [dm-devel] [PATCH 5/6] multipathd: Fix multipathd stopping on shutdown Benjamin Marzinski
2020-12-18 23:31   ` Martin Wilck
2021-01-27  1:16     ` Benjamin Marzinski
2021-01-27  9:41       ` Martin Wilck
2020-12-18 23:06 ` [dm-devel] [PATCH 6/6] multipath.conf.5: Improve checker_timeout description Benjamin Marzinski
2020-12-18 23:56   ` Martin Wilck
2021-01-05  0:33     ` Benjamin Marzinski [this message]
2021-01-05 10:55       ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105003342.GT3103@octiron.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=martin.wilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.