* [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep
@ 2020-12-28 3:40 ` Huangzhaoyang
0 siblings, 0 replies; 4+ messages in thread
From: Huangzhaoyang @ 2020-12-28 3:40 UTC (permalink / raw)
To: Bob Peterson, Andreas Gruenbacher, cluster-devel, Zhaoyang Huang,
linux-kernel
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
As gfs2_quotad_cachep has registered the shrinker, amending
SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
make the slab acount to be presiced.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
fs/gfs2/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 136484e..db39de9 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
sizeof(struct gfs2_quota_data),
- 0, 0, NULL);
+ 0, SLAB_RECLAIM_ACCOUNT, NULL);
if (!gfs2_quotad_cachep)
goto fail_cachep6;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep
@ 2020-12-28 3:40 ` Huangzhaoyang
0 siblings, 0 replies; 4+ messages in thread
From: Huangzhaoyang @ 2020-12-28 3:40 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
As gfs2_quotad_cachep has registered the shrinker, amending
SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
make the slab acount to be presiced.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
---
fs/gfs2/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 136484e..db39de9 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
sizeof(struct gfs2_quota_data),
- 0, 0, NULL);
+ 0, SLAB_RECLAIM_ACCOUNT, NULL);
if (!gfs2_quotad_cachep)
goto fail_cachep6;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep
2020-12-28 3:40 ` [Cluster-devel] " Huangzhaoyang
@ 2021-01-04 17:36 ` Bob Peterson
-1 siblings, 0 replies; 4+ messages in thread
From: Bob Peterson @ 2021-01-04 17:36 UTC (permalink / raw)
To: Huangzhaoyang
Cc: Andreas Gruenbacher, cluster-devel, Zhaoyang Huang, linux-kernel
----- Original Message -----
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> As gfs2_quotad_cachep has registered the shrinker, amending
> SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
> make the slab acount to be presiced.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
> fs/gfs2/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 136484e..db39de9 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
>
> gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
> sizeof(struct gfs2_quota_data),
> - 0, 0, NULL);
> + 0, SLAB_RECLAIM_ACCOUNT, NULL);
> if (!gfs2_quotad_cachep)
> goto fail_cachep6;
>
> --
> 1.9.1
>
>
Hi,
Thanks for the patch.
We should also do this for gfs2_glock_cachep. Can you add that to your patch?
Regards,
Bob Peterson
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep
@ 2021-01-04 17:36 ` Bob Peterson
0 siblings, 0 replies; 4+ messages in thread
From: Bob Peterson @ 2021-01-04 17:36 UTC (permalink / raw)
To: cluster-devel.redhat.com
----- Original Message -----
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> As gfs2_quotad_cachep has registered the shrinker, amending
> SLAB_RECLAIM_ACCOUNT when create gfs2_quotad_cachep, which
> make the slab acount to be presiced.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
> fs/gfs2/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
> index 136484e..db39de9 100644
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -136,7 +136,7 @@ static int __init init_gfs2_fs(void)
>
> gfs2_quotad_cachep = kmem_cache_create("gfs2_quotad",
> sizeof(struct gfs2_quota_data),
> - 0, 0, NULL);
> + 0, SLAB_RECLAIM_ACCOUNT, NULL);
> if (!gfs2_quotad_cachep)
> goto fail_cachep6;
>
> --
> 1.9.1
>
>
Hi,
Thanks for the patch.
We should also do this for gfs2_glock_cachep. Can you add that to your patch?
Regards,
Bob Peterson
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-04 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 3:40 [PATCH] fs: amend SLAB_RECLAIM_ACCOUNT on gfs2_quotad_cachep Huangzhaoyang
2020-12-28 3:40 ` [Cluster-devel] " Huangzhaoyang
2021-01-04 17:36 ` Bob Peterson
2021-01-04 17:36 ` [Cluster-devel] " Bob Peterson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.