* [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
@ 2020-12-11 13:58 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2020-12-11 13:58 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Sudeep Holla, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches
Since at91_soc_init is called unconditionally from atmel_soc_device_init,
we get the following warning on all non AT91 SoCs:
" AT91: Could not find identification node"
Fix the same by filtering with allowed AT91 SoC list.
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/soc/atmel/soc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
v1->v2:
- Updated the allowed list as suggested by Alexandre
diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index 55a1f57a4d8c..2dc86728b132 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -265,8 +265,20 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
return soc_dev;
}
+static const struct of_device_id at91_soc_allowed_list[] __initconst = {
+ { .compatible = "atmel,at91rm9200", },
+ { .compatible = "atmel,at91sam9", },
+ { .compatible = "atmel,sama5", },
+ { .compatible = "atmel,samv7", }
+};
+
static int __init atmel_soc_device_init(void)
{
+ struct device_node *np = of_find_node_by_path("/");
+
+ if (!of_match_node(at91_soc_allowed_list, np))
+ return 0;
+
at91_soc_init(socs);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
@ 2020-12-11 13:58 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2020-12-11 13:58 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Alexandre Belloni, Ludovic Desroches, Sudeep Holla
Since at91_soc_init is called unconditionally from atmel_soc_device_init,
we get the following warning on all non AT91 SoCs:
" AT91: Could not find identification node"
Fix the same by filtering with allowed AT91 SoC list.
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/soc/atmel/soc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
v1->v2:
- Updated the allowed list as suggested by Alexandre
diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index 55a1f57a4d8c..2dc86728b132 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -265,8 +265,20 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
return soc_dev;
}
+static const struct of_device_id at91_soc_allowed_list[] __initconst = {
+ { .compatible = "atmel,at91rm9200", },
+ { .compatible = "atmel,at91sam9", },
+ { .compatible = "atmel,sama5", },
+ { .compatible = "atmel,samv7", }
+};
+
static int __init atmel_soc_device_init(void)
{
+ struct device_node *np = of_find_node_by_path("/");
+
+ if (!of_match_node(at91_soc_allowed_list, np))
+ return 0;
+
at91_soc_init(socs);
return 0;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
2020-12-11 13:58 ` Sudeep Holla
@ 2020-12-28 16:58 ` Alexandre Belloni
-1 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2020-12-28 16:58 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, Sudeep Holla
Cc: Alexandre Belloni, Ludovic Desroches
On Fri, 11 Dec 2020 13:58:46 +0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> " AT91: Could not find identification node"
>
> Fix the same by filtering with allowed AT91 SoC list.
Applied, thanks!
[1/1] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
commit: 960ddf70cc11024e6e9dac206316d0160e00a77d
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
@ 2020-12-28 16:58 ` Alexandre Belloni
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2020-12-28 16:58 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, Sudeep Holla
Cc: Alexandre Belloni, Ludovic Desroches
On Fri, 11 Dec 2020 13:58:46 +0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> " AT91: Could not find identification node"
>
> Fix the same by filtering with allowed AT91 SoC list.
Applied, thanks!
[1/1] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
commit: 960ddf70cc11024e6e9dac206316d0160e00a77d
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-28 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 13:58 [PATCH v2] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Sudeep Holla
2020-12-11 13:58 ` Sudeep Holla
2020-12-28 16:58 ` Alexandre Belloni
2020-12-28 16:58 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.