* i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2020-12-24 12:26 ` qii.wang
0 siblings, 0 replies; 15+ messages in thread
From: qii.wang @ 2020-12-24 12:26 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu, qii.wang
From: Qii Wang <qii.wang@mediatek.com>
With the apdma remove hand-shake signal, it requirs special
operation timing to reset i2c manually, otherwise the interrupt
will not be triggered, i2c transmission will be timeout.
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
base Message ID: 1605701861-30800-1-git-send-email-qii.wang@mediatek.com
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 6f61595..2ffd2f3 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -38,6 +38,7 @@
#define I2C_IO_CONFIG_OPEN_DRAIN 0x0003
#define I2C_IO_CONFIG_PUSH_PULL 0x0000
#define I2C_SOFT_RST 0x0001
+#define I2C_HANDSHAKE_RST 0x0020
#define I2C_FIFO_ADDR_CLR 0x0001
#define I2C_DELAY_LEN 0x0002
#define I2C_TIME_CLR_VALUE 0x0000
@@ -45,6 +46,7 @@
#define I2C_WRRD_TRANAC_VALUE 0x0002
#define I2C_RD_TRANAC_VALUE 0x0001
#define I2C_SCL_MIS_COMP_VALUE 0x0000
+#define I2C_CHN_CLR_FLAG 0x0000
#define I2C_DMA_CON_TX 0x0000
#define I2C_DMA_CON_RX 0x0001
@@ -54,7 +56,9 @@
#define I2C_DMA_START_EN 0x0001
#define I2C_DMA_INT_FLAG_NONE 0x0000
#define I2C_DMA_CLR_FLAG 0x0000
+#define I2C_DMA_WARM_RST 0x0001
#define I2C_DMA_HARD_RST 0x0002
+#define I2C_DMA_HANDSHAKE_RST 0x0004
#define MAX_SAMPLE_CNT_DIV 8
#define MAX_STEP_CNT_DIV 64
@@ -475,11 +479,24 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
{
u16 control_reg;
- writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
- udelay(50);
- writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
-
- mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ if (i2c->dev_comp->dma_sync) {
+ writel(I2C_DMA_WARM_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_HANDSHAKE_RST | I2C_DMA_HARD_RST,
+ i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_HANDSHAKE_RST | I2C_SOFT_RST,
+ OFFSET_SOFTRESET);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_CHN_CLR_FLAG, OFFSET_SOFTRESET);
+ } else {
+ writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(50);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ }
/* Set ioconfig */
if (i2c->use_push_pull)
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2020-12-24 12:26 ` qii.wang
0 siblings, 0 replies; 15+ messages in thread
From: qii.wang @ 2020-12-24 12:26 UTC (permalink / raw)
To: wsa
Cc: qii.wang, srv_heupstream, leilk.liu, linux-kernel,
linux-mediatek, linux-i2c, matthias.bgg, linux-arm-kernel
From: Qii Wang <qii.wang@mediatek.com>
With the apdma remove hand-shake signal, it requirs special
operation timing to reset i2c manually, otherwise the interrupt
will not be triggered, i2c transmission will be timeout.
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
base Message ID: 1605701861-30800-1-git-send-email-qii.wang@mediatek.com
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 6f61595..2ffd2f3 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -38,6 +38,7 @@
#define I2C_IO_CONFIG_OPEN_DRAIN 0x0003
#define I2C_IO_CONFIG_PUSH_PULL 0x0000
#define I2C_SOFT_RST 0x0001
+#define I2C_HANDSHAKE_RST 0x0020
#define I2C_FIFO_ADDR_CLR 0x0001
#define I2C_DELAY_LEN 0x0002
#define I2C_TIME_CLR_VALUE 0x0000
@@ -45,6 +46,7 @@
#define I2C_WRRD_TRANAC_VALUE 0x0002
#define I2C_RD_TRANAC_VALUE 0x0001
#define I2C_SCL_MIS_COMP_VALUE 0x0000
+#define I2C_CHN_CLR_FLAG 0x0000
#define I2C_DMA_CON_TX 0x0000
#define I2C_DMA_CON_RX 0x0001
@@ -54,7 +56,9 @@
#define I2C_DMA_START_EN 0x0001
#define I2C_DMA_INT_FLAG_NONE 0x0000
#define I2C_DMA_CLR_FLAG 0x0000
+#define I2C_DMA_WARM_RST 0x0001
#define I2C_DMA_HARD_RST 0x0002
+#define I2C_DMA_HANDSHAKE_RST 0x0004
#define MAX_SAMPLE_CNT_DIV 8
#define MAX_STEP_CNT_DIV 64
@@ -475,11 +479,24 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
{
u16 control_reg;
- writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
- udelay(50);
- writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
-
- mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ if (i2c->dev_comp->dma_sync) {
+ writel(I2C_DMA_WARM_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_HANDSHAKE_RST | I2C_DMA_HARD_RST,
+ i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_HANDSHAKE_RST | I2C_SOFT_RST,
+ OFFSET_SOFTRESET);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_CHN_CLR_FLAG, OFFSET_SOFTRESET);
+ } else {
+ writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(50);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ }
/* Set ioconfig */
if (i2c->use_push_pull)
--
1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 15+ messages in thread
* i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2020-12-24 12:26 ` qii.wang
0 siblings, 0 replies; 15+ messages in thread
From: qii.wang @ 2020-12-24 12:26 UTC (permalink / raw)
To: wsa
Cc: qii.wang, srv_heupstream, leilk.liu, linux-kernel,
linux-mediatek, linux-i2c, matthias.bgg, linux-arm-kernel
From: Qii Wang <qii.wang@mediatek.com>
With the apdma remove hand-shake signal, it requirs special
operation timing to reset i2c manually, otherwise the interrupt
will not be triggered, i2c transmission will be timeout.
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
base Message ID: 1605701861-30800-1-git-send-email-qii.wang@mediatek.com
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 6f61595..2ffd2f3 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -38,6 +38,7 @@
#define I2C_IO_CONFIG_OPEN_DRAIN 0x0003
#define I2C_IO_CONFIG_PUSH_PULL 0x0000
#define I2C_SOFT_RST 0x0001
+#define I2C_HANDSHAKE_RST 0x0020
#define I2C_FIFO_ADDR_CLR 0x0001
#define I2C_DELAY_LEN 0x0002
#define I2C_TIME_CLR_VALUE 0x0000
@@ -45,6 +46,7 @@
#define I2C_WRRD_TRANAC_VALUE 0x0002
#define I2C_RD_TRANAC_VALUE 0x0001
#define I2C_SCL_MIS_COMP_VALUE 0x0000
+#define I2C_CHN_CLR_FLAG 0x0000
#define I2C_DMA_CON_TX 0x0000
#define I2C_DMA_CON_RX 0x0001
@@ -54,7 +56,9 @@
#define I2C_DMA_START_EN 0x0001
#define I2C_DMA_INT_FLAG_NONE 0x0000
#define I2C_DMA_CLR_FLAG 0x0000
+#define I2C_DMA_WARM_RST 0x0001
#define I2C_DMA_HARD_RST 0x0002
+#define I2C_DMA_HANDSHAKE_RST 0x0004
#define MAX_SAMPLE_CNT_DIV 8
#define MAX_STEP_CNT_DIV 64
@@ -475,11 +479,24 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
{
u16 control_reg;
- writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
- udelay(50);
- writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
-
- mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ if (i2c->dev_comp->dma_sync) {
+ writel(I2C_DMA_WARM_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ udelay(10);
+ writel(I2C_DMA_HANDSHAKE_RST | I2C_DMA_HARD_RST,
+ i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_HANDSHAKE_RST | I2C_SOFT_RST,
+ OFFSET_SOFTRESET);
+ udelay(10);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_CHN_CLR_FLAG, OFFSET_SOFTRESET);
+ } else {
+ writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
+ udelay(50);
+ writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
+ mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
+ }
/* Set ioconfig */
if (i2c->use_push_pull)
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
2020-12-24 12:26 ` qii.wang
(?)
@ 2021-01-04 18:29 ` Wolfram Sang
-1 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:29 UTC (permalink / raw)
To: qii.wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> From: Qii Wang <qii.wang@mediatek.com>
>
> With the apdma remove hand-shake signal, it requirs special
> operation timing to reset i2c manually, otherwise the interrupt
> will not be triggered, i2c transmission will be timeout.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-04 18:29 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:29 UTC (permalink / raw)
To: qii.wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]
On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> From: Qii Wang <qii.wang@mediatek.com>
>
> With the apdma remove hand-shake signal, it requirs special
> operation timing to reset i2c manually, otherwise the interrupt
> will not be triggered, i2c transmission will be timeout.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-04 18:29 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:29 UTC (permalink / raw)
To: qii.wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 400 bytes --]
On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> From: Qii Wang <qii.wang@mediatek.com>
>
> With the apdma remove hand-shake signal, it requirs special
> operation timing to reset i2c manually, otherwise the interrupt
> will not be triggered, i2c transmission will be timeout.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
2021-01-04 18:29 ` Wolfram Sang
(?)
@ 2021-01-04 18:32 ` Wolfram Sang
-1 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:32 UTC (permalink / raw)
To: qii.wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> >
> > With the apdma remove hand-shake signal, it requirs special
> > operation timing to reset i2c manually, otherwise the interrupt
> > will not be triggered, i2c transmission will be timeout.
> >
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>
> Applied to for-current, thanks!
Any Fixes:-Tag we could add?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-04 18:32 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:32 UTC (permalink / raw)
To: qii.wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]
On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> >
> > With the apdma remove hand-shake signal, it requirs special
> > operation timing to reset i2c manually, otherwise the interrupt
> > will not be triggered, i2c transmission will be timeout.
> >
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>
> Applied to for-current, thanks!
Any Fixes:-Tag we could add?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-04 18:32 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-04 18:32 UTC (permalink / raw)
To: qii.wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 515 bytes --]
On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> >
> > With the apdma remove hand-shake signal, it requirs special
> > operation timing to reset i2c manually, otherwise the interrupt
> > will not be triggered, i2c transmission will be timeout.
> >
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>
> Applied to for-current, thanks!
Any Fixes:-Tag we could add?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
2021-01-04 18:32 ` Wolfram Sang
(?)
@ 2021-01-05 7:24 ` Qii Wang
-1 siblings, 0 replies; 15+ messages in thread
From: Qii Wang @ 2021-01-05 7:24 UTC (permalink / raw)
To: Wolfram Sang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
On Mon, 2021-01-04 at 19:32 +0100, Wolfram Sang wrote:
> On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> > On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > > From: Qii Wang <qii.wang@mediatek.com>
> > >
> > > With the apdma remove hand-shake signal, it requirs special
> > > operation timing to reset i2c manually, otherwise the interrupt
> > > will not be triggered, i2c transmission will be timeout.
> > >
> > > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> >
> > Applied to for-current, thanks!
>
> Any Fixes:-Tag we could add?
>
Could you help me add:
Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-05 7:24 ` Qii Wang
0 siblings, 0 replies; 15+ messages in thread
From: Qii Wang @ 2021-01-05 7:24 UTC (permalink / raw)
To: Wolfram Sang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
On Mon, 2021-01-04 at 19:32 +0100, Wolfram Sang wrote:
> On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> > On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > > From: Qii Wang <qii.wang@mediatek.com>
> > >
> > > With the apdma remove hand-shake signal, it requirs special
> > > operation timing to reset i2c manually, otherwise the interrupt
> > > will not be triggered, i2c transmission will be timeout.
> > >
> > > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> >
> > Applied to for-current, thanks!
>
> Any Fixes:-Tag we could add?
>
Could you help me add:
Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-05 7:24 ` Qii Wang
0 siblings, 0 replies; 15+ messages in thread
From: Qii Wang @ 2021-01-05 7:24 UTC (permalink / raw)
To: Wolfram Sang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
On Mon, 2021-01-04 at 19:32 +0100, Wolfram Sang wrote:
> On Mon, Jan 04, 2021 at 07:29:59PM +0100, Wolfram Sang wrote:
> > On Thu, Dec 24, 2020 at 08:26:07PM +0800, qii.wang@mediatek.com wrote:
> > > From: Qii Wang <qii.wang@mediatek.com>
> > >
> > > With the apdma remove hand-shake signal, it requirs special
> > > operation timing to reset i2c manually, otherwise the interrupt
> > > will not be triggered, i2c transmission will be timeout.
> > >
> > > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> >
> > Applied to for-current, thanks!
>
> Any Fixes:-Tag we could add?
>
Could you help me add:
Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
2021-01-05 7:24 ` Qii Wang
(?)
@ 2021-01-05 9:55 ` Wolfram Sang
-1 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-05 9:55 UTC (permalink / raw)
To: Qii Wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 113 bytes --]
> Could you help me add:
> Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks, added!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-05 9:55 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-05 9:55 UTC (permalink / raw)
To: Qii Wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 113 bytes --]
> Could you help me add:
> Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks, added!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: i2c: mediatek: Fix apdma and i2c hand-shake timeout
@ 2021-01-05 9:55 ` Wolfram Sang
0 siblings, 0 replies; 15+ messages in thread
From: Wolfram Sang @ 2021-01-05 9:55 UTC (permalink / raw)
To: Qii Wang
Cc: srv_heupstream, leilk.liu, linux-kernel, linux-mediatek,
linux-i2c, matthias.bgg, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 113 bytes --]
> Could you help me add:
> Fixes: 8426fe70cfa4("i2c: mediatek: Add apdma sync in i2c driver")
Thanks, added!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-01-05 9:57 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 12:26 i2c: mediatek: Fix apdma and i2c hand-shake timeout qii.wang
2020-12-24 12:26 ` qii.wang
2020-12-24 12:26 ` qii.wang
2021-01-04 18:29 ` Wolfram Sang
2021-01-04 18:29 ` Wolfram Sang
2021-01-04 18:29 ` Wolfram Sang
2021-01-04 18:32 ` Wolfram Sang
2021-01-04 18:32 ` Wolfram Sang
2021-01-04 18:32 ` Wolfram Sang
2021-01-05 7:24 ` Qii Wang
2021-01-05 7:24 ` Qii Wang
2021-01-05 7:24 ` Qii Wang
2021-01-05 9:55 ` Wolfram Sang
2021-01-05 9:55 ` Wolfram Sang
2021-01-05 9:55 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.