* [PATCH] rpmsg: glink: fix some kerneldoc comments
@ 2021-01-05 23:56 Alex Elder
2021-01-06 3:50 ` patchwork-bot+linux-remoteproc
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Alex Elder @ 2021-01-05 23:56 UTC (permalink / raw)
To: bjorn.andersson, agross, ohad
Cc: linux-arm-msm, linux-remoteproc, linux-kernel
The kerneldoc comments for the do_cleanup_msg and cleanup_done_msg
structures describe the fields, but don't prefix the field names
with "@". Add those, to get rid of some W=1 build warnings on
an x86_64 architecture build.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/rpmsg/qcom_glink_ssr.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dcd1ce6169747..1fc2bf5354f50 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -12,11 +12,11 @@
/**
* struct do_cleanup_msg - The data structure for an SSR do_cleanup message
- * version: The G-Link SSR protocol version
- * command: The G-Link SSR command - do_cleanup
- * seq_num: Sequence number
- * name_len: Length of the name of the subsystem being restarted
- * name: G-Link edge name of the subsystem being restarted
+ * @version: The G-Link SSR protocol version
+ * @command: The G-Link SSR command - do_cleanup
+ * @seq_num: Sequence number
+ * @name_len: Length of the name of the subsystem being restarted
+ * @name: G-Link edge name of the subsystem being restarted
*/
struct do_cleanup_msg {
__le32 version;
@@ -28,9 +28,9 @@ struct do_cleanup_msg {
/**
* struct cleanup_done_msg - The data structure for an SSR cleanup_done message
- * version: The G-Link SSR protocol version
- * response: The G-Link SSR response to a do_cleanup command, cleanup_done
- * seq_num: Sequence number
+ * @version: The G-Link SSR protocol version
+ * @response: The G-Link SSR response to a do_cleanup command, cleanup_done
+ * @seq_num: Sequence number
*/
struct cleanup_done_msg {
__le32 version;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rpmsg: glink: fix some kerneldoc comments
2021-01-05 23:56 [PATCH] rpmsg: glink: fix some kerneldoc comments Alex Elder
@ 2021-01-06 3:50 ` patchwork-bot+linux-remoteproc
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-01-06 3:50 UTC (permalink / raw)
To: Alex Elder; +Cc: linux-remoteproc
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
On Tue, 5 Jan 2021 17:56:03 -0600 you wrote:
> The kerneldoc comments for the do_cleanup_msg and cleanup_done_msg
> structures describe the fields, but don't prefix the field names
> with "@". Add those, to get rid of some W=1 build warnings on
> an x86_64 architecture build.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
>
> [...]
Here is the summary with links:
- rpmsg: glink: fix some kerneldoc comments
https://git.kernel.org/andersson/remoteproc/c/df2f392c61b6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rpmsg: glink: fix some kerneldoc comments
2021-01-05 23:56 [PATCH] rpmsg: glink: fix some kerneldoc comments Alex Elder
2021-01-06 3:50 ` patchwork-bot+linux-remoteproc
@ 2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2021-03-01 19:59 UTC (permalink / raw)
To: Alex Elder; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Tue, 5 Jan 2021 17:56:03 -0600 you wrote:
> The kerneldoc comments for the do_cleanup_msg and cleanup_done_msg
> structures describe the fields, but don't prefix the field names
> with "@". Add those, to get rid of some W=1 build warnings on
> an x86_64 architecture build.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
>
> [...]
Here is the summary with links:
- rpmsg: glink: fix some kerneldoc comments
https://git.kernel.org/qcom/c/df2f392c61b6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-01 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 23:56 [PATCH] rpmsg: glink: fix some kerneldoc comments Alex Elder
2021-01-06 3:50 ` patchwork-bot+linux-remoteproc
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.