* [PATCH] net: dsa: fix led_classdev build errors
@ 2021-01-06 2:18 Randy Dunlap
2021-01-07 0:20 ` patchwork-bot+netdevbpf
2021-01-07 7:20 ` Kurt Kanzenbach
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-01-06 2:18 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Kurt Kanzenbach, netdev,
David S. Miller, Jakub Kicinski
Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
This limits the latter to =m when LEDS_CLASS=m.
microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup':
(.text+0xf80): undefined reference to `led_classdev_register_ext'
microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext'
microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free':
(.text+0x1018): undefined reference to `led_classdev_unregister'
microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202101060655.iUvMJqS2-lkp@intel.com
Cc: Kurt Kanzenbach <kurt@linutronix.de>
Cc: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/dsa/hirschmann/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-511-rc2.orig/drivers/net/dsa/hirschmann/Kconfig
+++ lnx-511-rc2/drivers/net/dsa/hirschmann/Kconfig
@@ -4,6 +4,7 @@ config NET_DSA_HIRSCHMANN_HELLCREEK
depends on HAS_IOMEM
depends on NET_DSA
depends on PTP_1588_CLOCK
+ depends on LEDS_CLASS
select NET_DSA_TAG_HELLCREEK
help
This driver adds support for Hirschmann Hellcreek TSN switches.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: fix led_classdev build errors
2021-01-06 2:18 [PATCH] net: dsa: fix led_classdev build errors Randy Dunlap
@ 2021-01-07 0:20 ` patchwork-bot+netdevbpf
2021-01-07 7:20 ` Kurt Kanzenbach
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-07 0:20 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, lkp, kurt, netdev, davem, kuba
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 5 Jan 2021 18:18:15 -0800 you wrote:
> Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
> This limits the latter to =m when LEDS_CLASS=m.
>
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup':
> (.text+0xf80): undefined reference to `led_classdev_register_ext'
> microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext'
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free':
> (.text+0x1018): undefined reference to `led_classdev_unregister'
> microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister'
>
> [...]
Here is the summary with links:
- net: dsa: fix led_classdev build errors
https://git.kernel.org/netdev/net/c/7f847db30408
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: fix led_classdev build errors
2021-01-06 2:18 [PATCH] net: dsa: fix led_classdev build errors Randy Dunlap
2021-01-07 0:20 ` patchwork-bot+netdevbpf
@ 2021-01-07 7:20 ` Kurt Kanzenbach
1 sibling, 0 replies; 3+ messages in thread
From: Kurt Kanzenbach @ 2021-01-07 7:20 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Randy Dunlap, kernel test robot, netdev, David S. Miller, Jakub Kicinski
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Tue Jan 05 2021, Randy Dunlap wrote:
> Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y.
> This limits the latter to =m when LEDS_CLASS=m.
>
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_setup':
> (.text+0xf80): undefined reference to `led_classdev_register_ext'
> microblaze-linux-ld: (.text+0xf94): undefined reference to `led_classdev_register_ext'
> microblaze-linux-ld: drivers/net/dsa/hirschmann/hellcreek_ptp.o: in function `hellcreek_ptp_free':
> (.text+0x1018): undefined reference to `led_classdev_unregister'
> microblaze-linux-ld: (.text+0x1024): undefined reference to `led_classdev_unregister'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202101060655.iUvMJqS2-lkp@intel.com
> Cc: Kurt Kanzenbach <kurt@linutronix.de>
> Cc: netdev@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-07 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06 2:18 [PATCH] net: dsa: fix led_classdev build errors Randy Dunlap
2021-01-07 0:20 ` patchwork-bot+netdevbpf
2021-01-07 7:20 ` Kurt Kanzenbach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.