[PATCH] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM

[PATCH] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM

[Randy Dunlap]

Building ufshcd-pltfrm.c on arch/s390/ has a linker error since
S390 does not support IOMEM, so add a dependency on HAS_IOMEM.

s390-linux-ld: drivers/scsi/ufs/ufshcd-pltfrm.o: in function `ufshcd_pltfrm_init':
ufshcd-pltfrm.c:(.text+0x38e): undefined reference to `devm_platform_ioremap_resource'

where that devm_ function is inside an #ifdef CONFIG_HAS_IOMEM/#endif block.

Fixes: 03b1781aa978 ("[SCSI] ufs: Add Platform glue driver for ufshcd")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202101031125.ZEFCUiKi-lkp@intel.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: linux-scsi@vger.kernel.org
---
This not a COMPILE_TEST build. The 0day bot was reporting tons of
S390 build errors for iomem-related function usage, so now S390 does
not allow COMPILE_TEST, and any iomem-related build errors on S390
should be fixed AFAIK.

 drivers/scsi/ufs/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- lnx-511-rc2.orig/drivers/scsi/ufs/Kconfig
+++ lnx-511-rc2/drivers/scsi/ufs/Kconfig
@@ -72,6 +72,7 @@ config SCSI_UFS_DWC_TC_PCI
 config SCSI_UFSHCD_PLATFORM
 	tristate "Platform bus based UFS Controller support"
 	depends on SCSI_UFSHCD
+	depends on HAS_IOMEM
 	help
 	This selects the UFS host controller support. Select this if
 	you have an UFS controller on Platform bus.

Re: [PATCH] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM

[Martin K. Petersen]

On Tue, 5 Jan 2021 20:08:22 -0800, Randy Dunlap wrote:

> Building ufshcd-pltfrm.c on arch/s390/ has a linker error since
> S390 does not support IOMEM, so add a dependency on HAS_IOMEM.
> 
> s390-linux-ld: drivers/scsi/ufs/ufshcd-pltfrm.o: in function `ufshcd_pltfrm_init':
> ufshcd-pltfrm.c:(.text+0x38e): undefined reference to `devm_platform_ioremap_resource'
> 
> where that devm_ function is inside an #ifdef CONFIG_HAS_IOMEM/#endif block.

Applied to 5.11/scsi-fixes, thanks!

[1/1] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM
      https://git.kernel.org/mkp/scsi/c/5e6ddadf7637

-- 
Martin K. Petersen	Oracle Linux Engineering