* [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
@ 2020-09-30 18:56 ` Simon South
0 siblings, 0 replies; 6+ messages in thread
From: Simon South @ 2020-09-30 18:56 UTC (permalink / raw)
To: robh+dt, heiko, smoch, t.schramm, jbx6244, katsuhiro, sigmaris,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Simon South
On Pinebook Pro laptops with an NVMe SSD installed, prevent random
crashes in the NVMe driver by not attempting to use a PCIe link speed
higher than that supported by the RK3399 SoC.
See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
rk3399").
Fixes: 5a65505a6988 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
Signed-off-by: Simon South <simon@simonsouth.net>
---
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..219b7507a10f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -790,7 +790,6 @@ &pcie_phy {
&pcie0 {
bus-scan-delay-ms = <1000>;
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
- max-link-speed = <2>;
num-lanes = <4>;
pinctrl-names = "default";
pinctrl-0 = <&pcie_clkreqn_cpm>;
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
@ 2020-09-30 18:56 ` Simon South
0 siblings, 0 replies; 6+ messages in thread
From: Simon South @ 2020-09-30 18:56 UTC (permalink / raw)
To: robh+dt, heiko, smoch, t.schramm, jbx6244, katsuhiro, sigmaris,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Simon South
On Pinebook Pro laptops with an NVMe SSD installed, prevent random
crashes in the NVMe driver by not attempting to use a PCIe link speed
higher than that supported by the RK3399 SoC.
See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
rk3399").
Fixes: 5a65505a6988 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
Signed-off-by: Simon South <simon@simonsouth.net>
---
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..219b7507a10f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -790,7 +790,6 @@ &pcie_phy {
&pcie0 {
bus-scan-delay-ms = <1000>;
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
- max-link-speed = <2>;
num-lanes = <4>;
pinctrl-names = "default";
pinctrl-0 = <&pcie_clkreqn_cpm>;
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
@ 2020-09-30 18:56 ` Simon South
0 siblings, 0 replies; 6+ messages in thread
From: Simon South @ 2020-09-30 18:56 UTC (permalink / raw)
To: robh+dt, heiko, smoch, t.schramm, jbx6244, katsuhiro, sigmaris,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Simon South
On Pinebook Pro laptops with an NVMe SSD installed, prevent random
crashes in the NVMe driver by not attempting to use a PCIe link speed
higher than that supported by the RK3399 SoC.
See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
rk3399").
Fixes: 5a65505a6988 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")
Signed-off-by: Simon South <simon@simonsouth.net>
---
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..219b7507a10f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -790,7 +790,6 @@ &pcie_phy {
&pcie0 {
bus-scan-delay-ms = <1000>;
ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
- max-link-speed = <2>;
num-lanes = <4>;
pinctrl-names = "default";
pinctrl-0 = <&pcie_clkreqn_cpm>;
--
2.28.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
2020-09-30 18:56 ` Simon South
(?)
@ 2021-01-09 15:39 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-09 15:39 UTC (permalink / raw)
To: sigmaris, jbx6244, t.schramm, linux-kernel, linux-arm-kernel,
devicetree, smoch, linux-rockchip, Simon South, katsuhiro,
robh+dt
Cc: Heiko Stuebner
On Wed, 30 Sep 2020 14:56:27 -0400, Simon South wrote:
> On Pinebook Pro laptops with an NVMe SSD installed, prevent random
> crashes in the NVMe driver by not attempting to use a PCIe link speed
> higher than that supported by the RK3399 SoC.
>
> See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
> rk3399").
Applied, thanks!
[1/1] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
commit: 642fb2795290c4abe629ca34fb8ff6d78baa9fd3
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
@ 2021-01-09 15:39 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-09 15:39 UTC (permalink / raw)
To: sigmaris, jbx6244, t.schramm, linux-kernel, linux-arm-kernel,
devicetree, smoch, linux-rockchip, Simon South, katsuhiro,
robh+dt
Cc: Heiko Stuebner
On Wed, 30 Sep 2020 14:56:27 -0400, Simon South wrote:
> On Pinebook Pro laptops with an NVMe SSD installed, prevent random
> crashes in the NVMe driver by not attempting to use a PCIe link speed
> higher than that supported by the RK3399 SoC.
>
> See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
> rk3399").
Applied, thanks!
[1/1] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
commit: 642fb2795290c4abe629ca34fb8ff6d78baa9fd3
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
@ 2021-01-09 15:39 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-09 15:39 UTC (permalink / raw)
To: sigmaris, jbx6244, t.schramm, linux-kernel, linux-arm-kernel,
devicetree, smoch, linux-rockchip, Simon South, katsuhiro,
robh+dt
Cc: Heiko Stuebner
On Wed, 30 Sep 2020 14:56:27 -0400, Simon South wrote:
> On Pinebook Pro laptops with an NVMe SSD installed, prevent random
> crashes in the NVMe driver by not attempting to use a PCIe link speed
> higher than that supported by the RK3399 SoC.
>
> See commit 712fa1777207 ("arm64: dts: rockchip: add max-link-speed for
> rk3399").
Applied, thanks!
[1/1] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed
commit: 642fb2795290c4abe629ca34fb8ff6d78baa9fd3
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-09 15:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 18:56 [PATCH] arm64: dts: rockchip: Pinebook Pro: Use supported PCIe link speed Simon South
2020-09-30 18:56 ` Simon South
2020-09-30 18:56 ` Simon South
2021-01-09 15:39 ` Heiko Stuebner
2021-01-09 15:39 ` Heiko Stuebner
2021-01-09 15:39 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.