* [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
@ 2021-01-11 16:41 Ville Syrjala
2021-01-11 17:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Ville Syrjala @ 2021-01-11 16:41 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Let's not enable the 4:4:4->4:2:0 conversion bit in the DFP unless we're
actually outputting YCbCr 4:4:4. It would appear some protocol
converters blindy consult this bit even when the source is outputting
RGB, resulting in a visual mess.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2914
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4f190a82d4ad..aa30ef9f6906 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4368,8 +4368,8 @@ void intel_dp_configure_protocol_converter(struct intel_dp *intel_dp,
drm_dbg_kms(&i915->drm, "Failed to set protocol converter HDMI mode to %s\n",
enableddisabled(intel_dp->has_hdmi_sink));
- tmp = intel_dp->dfp.ycbcr_444_to_420 ?
- DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
+ tmp = crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR444 &&
+ intel_dp->dfp.ycbcr_444_to_420 ? DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
if (drm_dp_dpcd_writeb(&intel_dp->aux,
DP_PROTOCOL_CONVERTER_CONTROL_1, tmp) != 1)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
2021-01-11 16:41 [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Ville Syrjala
@ 2021-01-11 17:59 ` Patchwork
2021-01-12 1:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2) Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-11 17:59 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5878 bytes --]
== Series Details ==
Series: drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
URL : https://patchwork.freedesktop.org/series/85715/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9580 -> Patchwork_19316
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19316 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19316, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19316:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hugepages:
- fi-kbl-soraka: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-kbl-soraka/igt@i915_selftest@live@hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-kbl-soraka/igt@i915_selftest@live@hugepages.html
Known issues
------------
Here are the changes found in Patchwork_19316 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-byt-j1900: NOTRUN -> [SKIP][3] ([fdo#109271]) +27 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-byt-j1900/igt@gem_huc_copy@huc-copy.html
* igt@gem_ringfill@basic-all:
- fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-tgl-y/igt@gem_ringfill@basic-all.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-tgl-y/igt@gem_ringfill@basic-all.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][6] -> [SKIP][7] ([fdo#109271])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-kbl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@blt:
- fi-snb-2600: [PASS][8] -> [DMESG-FAIL][9] ([i915#1409])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-snb-2600/igt@i915_selftest@live@blt.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-snb-2600/igt@i915_selftest@live@blt.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-y: [PASS][10] -> [DMESG-FAIL][11] ([i915#2601])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- fi-kbl-soraka: [PASS][12] -> [SKIP][13] ([fdo#109271]) +10 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-kbl-soraka/igt@i915_selftest@live@reset.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-kbl-soraka/igt@i915_selftest@live@reset.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][14] -> [FAIL][15] ([i915#1161] / [i915#262])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-byt-j1900: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-byt-j1900/igt@kms_chamelium@hdmi-crc-fast.html
* igt@runner@aborted:
- fi-kbl-soraka: NOTRUN -> [FAIL][17] ([i915#1436] / [i915#2295])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-kbl-soraka/igt@runner@aborted.html
#### Possible fixes ####
* igt@vgem_basic@dmabuf-fence-before:
- fi-tgl-y: [DMESG-WARN][18] ([i915#402]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9580/fi-tgl-y/igt@vgem_basic@dmabuf-fence-before.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/fi-tgl-y/igt@vgem_basic@dmabuf-fence-before.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (43 -> 38)
------------------------------
Additional (1): fi-byt-j1900
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-cml-drallion fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9580 -> Patchwork_19316
CI-20190529: 20190529
CI_DRM_9580: 117f9c9bca0ebb0e22ce282eab531575f5154055 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5953: 65c5eea699141e6f942ce0a8fc85db76ce53cd19 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19316: 9efd9fad4683dc8699e4be0bec8eb390fc6bdd6f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9efd9fad4683 drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19316/index.html
[-- Attachment #1.2: Type: text/html, Size: 7026 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2)
2021-01-11 16:41 [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Ville Syrjala
2021-01-11 17:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2021-01-12 1:53 ` Patchwork
2021-01-12 4:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-14 7:27 ` [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Jani Nikula
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-12 1:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4626 bytes --]
== Series Details ==
Series: drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2)
URL : https://patchwork.freedesktop.org/series/85715/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9585 -> Patchwork_19319
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/index.html
Known issues
------------
Here are the changes found in Patchwork_19319 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@nop-compute0:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +9 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-tgl-y/igt@amdgpu/amd_cs_nop@nop-compute0.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][4] ([i915#2029])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-bdw-5557u/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][5] ([i915#1888]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@gem_render_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-tgl-y/igt@gem_render_tiled_blits@basic.html
* igt@i915_selftest@live@active:
- fi-kbl-soraka: [DMESG-FAIL][9] ([i915#2291] / [i915#666]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-kbl-soraka/igt@i915_selftest@live@active.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-kbl-soraka/igt@i915_selftest@live@active.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [DMESG-FAIL][11] ([i915#2291] / [i915#541]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [SKIP][13] ([fdo#109271]) -> [FAIL][14] ([i915#704])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
[i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704
Participating hosts (44 -> 38)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-cml-drallion fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9585 -> Patchwork_19319
CI-20190529: 20190529
CI_DRM_9585: ce8ee6513f0f9d00ea44e1c4b7aff8b4883cda13 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5954: 2763c0977004bed596ee876c755b0768187ea9ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19319: c54c72aa7d1b4f7908782a467c29e3d022092159 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c54c72aa7d1b drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/index.html
[-- Attachment #1.2: Type: text/html, Size: 5552 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2)
2021-01-11 16:41 [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Ville Syrjala
2021-01-11 17:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-01-12 1:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2) Patchwork
@ 2021-01-12 4:23 ` Patchwork
2021-01-14 7:27 ` [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Jani Nikula
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-01-12 4:23 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18243 bytes --]
== Series Details ==
Series: drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2)
URL : https://patchwork.freedesktop.org/series/85715/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9585_full -> Patchwork_19319_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19319_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19319_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19319_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_schedule@u-fairslice@vecs0}:
- shard-skl: [DMESG-WARN][3] ([i915#1610] / [i915#2803]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl9/igt@gem_exec_schedule@u-fairslice@vecs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl2/igt@gem_exec_schedule@u-fairslice@vecs0.html
* {igt@gem_softpin@32b-excludes-last-page}:
- shard-glk: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-glk7/igt@gem_softpin@32b-excludes-last-page.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-glk8/igt@gem_softpin@32b-excludes-last-page.html
Known issues
------------
Here are the changes found in Patchwork_19319_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_mm@all@replace:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#2485] / [i915#2813])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl7/igt@drm_mm@all@replace.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl3/igt@drm_mm@all@replace.html
* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][9] ([i915#2389])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-iclb1/igt@gem_exec_reloc@basic-many-active@vcs1.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][10] ([i915#2658])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl8/igt@gem_pwrite@basic-exhaustion.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#2521])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_big_joiner@basic:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2705])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl8/igt@kms_big_joiner@basic.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][14] -> [DMESG-WARN][15] ([i915#1982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl1/igt@kms_color@pipe-b-ctm-0-75.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl5/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_color@pipe-d-ctm-0-5:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271]) +87 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl8/igt@kms_color@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl3/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl6/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][19] ([i915#1319])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl6/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#54]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_flip@2x-flip-vs-panning:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271]) +14 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl6/igt@kms_flip@2x-flip-vs-panning.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#79])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#49])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#533])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][28] ([i915#265])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][29] ([fdo#108145] / [i915#265])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][30] -> [SKIP][31] ([fdo#109441]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-iclb4/igt@kms_psr@psr2_primary_blt.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][32] ([IGT#2])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl3/igt@kms_sysfs_edid_timing.html
* igt@perf@polling-small-buf:
- shard-skl: NOTRUN -> [FAIL][33] ([i915#1722])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl3/igt@perf@polling-small-buf.html
#### Possible fixes ####
* {igt@gem_exec_fair@basic-none-solo@rcs0}:
- shard-kbl: [FAIL][34] ([i915#2842]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-kbl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-kbl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-glk: [DMESG-WARN][36] ([i915#118] / [i915#95]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-glk1/igt@gem_exec_whisper@basic-queues-priority-all.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-glk3/igt@gem_exec_whisper@basic-queues-priority-all.html
* igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
- shard-skl: [FAIL][38] ([i915#54]) -> [PASS][39] +6 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-skl: [FAIL][40] ([i915#52] / [i915#54]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl10/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl1/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][42] ([i915#2122]) -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][44] ([i915#1188]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl1/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- shard-skl: [FAIL][46] ([i915#53]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl10/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl1/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][48] ([fdo#108145] / [i915#265]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_cursor@pipe-b-primary-size-64:
- shard-skl: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl2/igt@kms_plane_cursor@pipe-b-primary-size-64.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl4/igt@kms_plane_cursor@pipe-b-primary-size-64.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][52] ([fdo#109441]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf@polling:
- shard-skl: [FAIL][54] ([i915#1542]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl3/igt@perf@polling.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl7/igt@perf@polling.html
* igt@prime_vgem@sync@rcs0:
- shard-apl: [INCOMPLETE][56] ([i915#409]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-apl3/igt@prime_vgem@sync@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl6/igt@prime_vgem@sync@rcs0.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [FAIL][58] -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-skl5/igt@sysfs_timeslice_duration@timeout@vecs0.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-skl10/igt@sysfs_timeslice_duration@timeout@vecs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][60] ([i915#2684]) -> [WARN][61] ([i915#1804] / [i915#2684]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_content_protection@legacy:
- shard-apl: [FAIL][62] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][63] ([i915#1319])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-apl1/igt@kms_content_protection@legacy.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl4/igt@kms_content_protection@legacy.html
* igt@runner@aborted:
- shard-apl: ([FAIL][64], [FAIL][65], [FAIL][66]) ([i915#2295] / [i915#2426] / [i915#409]) -> ([FAIL][67], [FAIL][68]) ([i915#2295])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-apl3/igt@runner@aborted.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-apl1/igt@runner@aborted.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-apl1/igt@runner@aborted.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl4/igt@runner@aborted.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-apl1/igt@runner@aborted.html
- shard-tglb: ([FAIL][69], [FAIL][70]) ([i915#1602] / [i915#2295] / [i915#2667]) -> ([FAIL][71], [FAIL][72]) ([i915#2295] / [i915#2426] / [i915#2667] / [i915#2803])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-tglb5/igt@runner@aborted.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9585/shard-tglb8/igt@runner@aborted.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-tglb1/igt@runner@aborted.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/shard-tglb2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2485]: https://gitlab.freedesktop.org/drm/intel/issues/2485
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2813]: https://gitlab.freedesktop.org/drm/intel/issues/2813
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9585 -> Patchwork_19319
CI-20190529: 20190529
CI_DRM_9585: ce8ee6513f0f9d00ea44e1c4b7aff8b4883cda13 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5954: 2763c0977004bed596ee876c755b0768187ea9ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19319: c54c72aa7d1b4f7908782a467c29e3d022092159 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19319/index.html
[-- Attachment #1.2: Type: text/html, Size: 21481 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
2021-01-11 16:41 [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Ville Syrjala
` (2 preceding siblings ...)
2021-01-12 4:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-01-14 7:27 ` Jani Nikula
2021-01-14 15:06 ` Ville Syrjälä
3 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2021-01-14 7:27 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx
On Mon, 11 Jan 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's not enable the 4:4:4->4:2:0 conversion bit in the DFP unless we're
> actually outputting YCbCr 4:4:4. It would appear some protocol
> converters blindy consult this bit even when the source is outputting
> RGB, resulting in a visual mess.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2914
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: 181567aa9f0d ("drm/i915: Do YCbCr 444->420 conversion via DP protocol converters")
Cc: <stable@vger.kernel.org> # v5.10+
Right?
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4f190a82d4ad..aa30ef9f6906 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4368,8 +4368,8 @@ void intel_dp_configure_protocol_converter(struct intel_dp *intel_dp,
> drm_dbg_kms(&i915->drm, "Failed to set protocol converter HDMI mode to %s\n",
> enableddisabled(intel_dp->has_hdmi_sink));
>
> - tmp = intel_dp->dfp.ycbcr_444_to_420 ?
> - DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
> + tmp = crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR444 &&
> + intel_dp->dfp.ycbcr_444_to_420 ? DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
>
> if (drm_dp_dpcd_writeb(&intel_dp->aux,
> DP_PROTOCOL_CONVERTER_CONTROL_1, tmp) != 1)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4
2021-01-14 7:27 ` [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Jani Nikula
@ 2021-01-14 15:06 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2021-01-14 15:06 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Jan 14, 2021 at 09:27:35AM +0200, Jani Nikula wrote:
> On Mon, 11 Jan 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Let's not enable the 4:4:4->4:2:0 conversion bit in the DFP unless we're
> > actually outputting YCbCr 4:4:4. It would appear some protocol
> > converters blindy consult this bit even when the source is outputting
> > RGB, resulting in a visual mess.
> >
> > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2914
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fixes: 181567aa9f0d ("drm/i915: Do YCbCr 444->420 conversion via DP protocol converters")
> Cc: <stable@vger.kernel.org> # v5.10+
>
> Right?
Not sure I should to add the stable tag directly since it apparently
applies cleanly but does not build. So needs a custom backport.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Ta.
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 4f190a82d4ad..aa30ef9f6906 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -4368,8 +4368,8 @@ void intel_dp_configure_protocol_converter(struct intel_dp *intel_dp,
> > drm_dbg_kms(&i915->drm, "Failed to set protocol converter HDMI mode to %s\n",
> > enableddisabled(intel_dp->has_hdmi_sink));
> >
> > - tmp = intel_dp->dfp.ycbcr_444_to_420 ?
> > - DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
> > + tmp = crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR444 &&
> > + intel_dp->dfp.ycbcr_444_to_420 ? DP_CONVERSION_TO_YCBCR420_ENABLE : 0;
> >
> > if (drm_dp_dpcd_writeb(&intel_dp->aux,
> > DP_PROTOCOL_CONVERTER_CONTROL_1, tmp) != 1)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-14 15:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 16:41 [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Ville Syrjala
2021-01-11 17:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-01-12 1:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 (rev2) Patchwork
2021-01-12 4:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-14 7:27 ` [Intel-gfx] [PATCH] drm/i915: Only enable DFP 4:4:4->4:2:0 conversion when outputting YCbCr 4:4:4 Jani Nikula
2021-01-14 15:06 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.