From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: Kuogee Hsieh <khsieh@codeaurora.org>, tanmay@codeaurora.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state Date: Mon, 11 Jan 2021 11:55:18 -0800 [thread overview] Message-ID: <161039491877.3661239.1387205899512360969@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1610051425-20632-2-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-01-07 12:30:24) > irq_hpd event can only be executed at connected state. Therefore > irq_hpd event should be postponed if it happened at connection > pending state. This patch also make sure both link rate and lane Why does it happen at connection pending state? > are valid before start link training. Can this part about link rate and lane being valid be split off into another patch? > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > --- Any fixes tag? > drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ > drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++++++++--- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 6e971d5..3bc7ed2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -693,6 +693,13 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) > return 0; > } > > + if (state == ST_CONNECT_PENDING) { > + /* wait until ST_CONNECTED */ > + dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay = 1 */ > + mutex_unlock(&dp->event_mutex); > + return 0; > + } > + > ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); > if (ret == -ECONNRESET) { /* cable unplugged */ > dp->core_initialized = false;
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, Kuogee Hsieh <khsieh@codeaurora.org>, tanmay@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state Date: Mon, 11 Jan 2021 11:55:18 -0800 [thread overview] Message-ID: <161039491877.3661239.1387205899512360969@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1610051425-20632-2-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-01-07 12:30:24) > irq_hpd event can only be executed at connected state. Therefore > irq_hpd event should be postponed if it happened at connection > pending state. This patch also make sure both link rate and lane Why does it happen at connection pending state? > are valid before start link training. Can this part about link rate and lane being valid be split off into another patch? > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org> > --- Any fixes tag? > drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++ > drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++++++++--- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 6e971d5..3bc7ed2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -693,6 +693,13 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data) > return 0; > } > > + if (state == ST_CONNECT_PENDING) { > + /* wait until ST_CONNECTED */ > + dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay = 1 */ > + mutex_unlock(&dp->event_mutex); > + return 0; > + } > + > ret = dp_display_usbpd_attention_cb(&dp->pdev->dev); > if (ret == -ECONNRESET) { /* cable unplugged */ > dp->core_initialized = false; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-11 19:56 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-07 20:30 [PATCH 0/2] *** fix missing unplug interrupt problem *** Kuogee Hsieh 2021-01-07 20:30 ` Kuogee Hsieh 2021-01-07 20:30 ` [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state Kuogee Hsieh 2021-01-07 20:30 ` Kuogee Hsieh 2021-01-11 19:55 ` Stephen Boyd [this message] 2021-01-11 19:55 ` Stephen Boyd 2021-01-13 17:44 ` khsieh 2021-01-13 17:44 ` khsieh 2021-01-13 20:21 ` Stephen Boyd 2021-01-13 20:21 ` Stephen Boyd 2021-01-13 20:22 ` Stephen Boyd 2021-01-13 20:22 ` Stephen Boyd 2021-01-13 23:44 ` khsieh 2021-01-13 23:44 ` khsieh 2021-01-14 0:00 ` Stephen Boyd 2021-01-14 0:00 ` Stephen Boyd 2021-01-14 17:13 ` khsieh 2021-01-14 17:13 ` khsieh 2021-01-07 20:30 ` [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler Kuogee Hsieh 2021-01-07 20:30 ` Kuogee Hsieh 2021-01-11 19:54 ` Stephen Boyd 2021-01-11 19:54 ` Stephen Boyd 2021-01-13 17:48 ` khsieh 2021-01-13 17:48 ` khsieh 2021-01-13 20:23 ` Stephen Boyd 2021-01-13 20:23 ` Stephen Boyd 2021-01-13 23:46 ` khsieh 2021-01-13 23:46 ` khsieh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161039491877.3661239.1387205899512360969@swboyd.mtv.corp.google.com \ --to=swboyd@chromium.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=aravindh@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=khsieh@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=tanmay@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.