From: Stephen Boyd <swboyd@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>,
Philip Chen <philipchen@chromium.org>,
dmitry.torokhov@gmail.com
Cc: dianders@chromium.org, Philip Chen <philipchen@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Simon Glass <sjg@chromium.org>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
Date: Thu, 14 Jan 2021 18:38:04 -0800 [thread overview]
Message-ID: <161067828422.3661239.16933057782247961610@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210114183010.v6.1.I025fb861cd5fa0ef5286b7dce514728e9df7ae74@changeid>
Quoting Philip Chen (2021-01-14 18:30:30)
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
One nit below.
> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index 8e50c14a9d778..a742b0777ee6d 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -43,6 +54,18 @@ examples:
> keypad,num-rows = <8>;
> keypad,num-columns = <13>;
> google,needs-ghost-filter;
> + function-row-physmap = <
> + 0x00020000 /* T1 */
> + 0x03020000 /* T2 */
> + 0x02020000 /* T3 */
> + 0x01020000 /* T4 */
> + 0x03040000 /* T5 */
> + 0x02040000 /* T6 */
> + 0x01040000 /* T7 */
> + 0x02090000 /* T8 */
> + 0x01090000 /* T9 */
> + 0x00040000 /* T10 */
Can we include the header file for MATRIX_KEY so we can use the macro
here?
next prev parent reply other threads:[~2021-01-15 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 2:30 [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 2:30 ` [PATCH v6 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2021-01-15 2:39 ` Stephen Boyd
2021-01-15 2:38 ` Stephen Boyd [this message]
2021-01-15 20:23 ` [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161067828422.3661239.16933057782247961610@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.