From: Stephen Boyd <swboyd@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>,
Philip Chen <philipchen@chromium.org>,
dmitry.torokhov@gmail.com
Cc: dianders@chromium.org, Philip Chen <philipchen@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v6 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace
Date: Thu, 14 Jan 2021 18:39:03 -0800 [thread overview]
Message-ID: <161067834304.3661239.10444715775164261177@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210114183010.v6.2.I2c219435b0d06a84411ae35c3154e123c52fcd7d@changeid>
Quoting Philip Chen (2021-01-14 18:30:31)
> The top-row keys in a keyboard usually have dual functionalities.
> E.g. A function key "F1" is also an action key "Browser back".
>
> Therefore, when an application receives an action key code from
> a top-row key press, the application needs to know how to correlate
> the action key code with the function key code and do the conversion
> whenever necessary.
>
> Since the userpace already knows the key scanlines (row/column)
> associated with a received key code. Essentially, the userspace only
> needs a mapping between the key row/column and the matching physical
> location in the top row.
>
> So, enhance the cros-ec-keyb driver to create such a mapping
> and expose it to userspace in the form of a function_row_physmap
> attribute. The attribute would be a space separated ordered list of
> row/column codes, for the keys in the function row, in a left-to-right
> order.
>
> The attribute will only be present when the device has a custom design
> for the top-row keys.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2021-01-15 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 2:30 [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 2:30 ` [PATCH v6 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2021-01-15 2:39 ` Stephen Boyd [this message]
2021-01-15 2:38 ` [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Stephen Boyd
2021-01-15 20:23 ` Philip Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161067834304.3661239.10444715775164261177@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.