* [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland.
@ 2020-12-23 5:10 John Millikin
2021-01-20 13:01 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: John Millikin @ 2020-12-23 5:10 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon, linux-arm-kernel
BSD sed ignores whitespace character escape sequences such as '\t' in
the replacement string, causing this script to produce the following
incorrect output:
#define vdso_offset_sigtrampt0x089c
Changing the hard tab to ' ' causes both BSD and GNU dialects of sed
to produce equivalent output.
Signed-off-by: John Millikin <john@john-millikin.com>
---
Re-sending because I bungled the original email enough to get it rejected by the list software.
arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
index 8b806eacd0a6..0387209d65b1 100755
--- a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
+++ b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
@@ -13,4 +13,4 @@
LC_ALL=C
sed -n -e 's/^00*/0/' -e \
-'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2\t0x\1/p'
+'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2 0x\1/p'
--
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland.
2020-12-23 5:10 [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland John Millikin
@ 2021-01-20 13:01 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2021-01-20 13:01 UTC (permalink / raw)
To: Catalin Marinas, John Millikin, linux-arm-kernel; +Cc: Will Deacon, kernel-team
On Wed, 23 Dec 2020 14:10:56 +0900, John Millikin wrote:
> BSD sed ignores whitespace character escape sequences such as '\t' in
> the replacement string, causing this script to produce the following
> incorrect output:
>
> #define vdso_offset_sigtrampt0x089c
>
> Changing the hard tab to ' ' causes both BSD and GNU dialects of sed
> to produce equivalent output.
Unfortunately, the patch you sent was still reported as 'corrupt' by git,
so I ended up having to fix it by hand. Please check that the result is
correct.
Applied to arm64 (for-next/vdso), thanks!
[1/1] arm64: Support running gen_vdso_offsets.sh with BSD userland.
https://git.kernel.org/arm64/c/f3cb097ad888
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland.
[not found] <CAL1ky9ptQT6G_Y37WWOkNohy50otWnc4dGAeGO_Gs6BTLX4Gag@mail.gmail.com>
@ 2020-12-15 12:41 ` Catalin Marinas
0 siblings, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2020-12-15 12:41 UTC (permalink / raw)
To: John Millikin; +Cc: Will Deacon, linux-arm-kernel
On Mon, Dec 14, 2020 at 05:03:52PM +0900, John Millikin wrote:
> BSD sed ignores whitespace character escape sequences such as '\t' in
> the replacement string, causing this script to produce the following
> incorrect output:
>
> #define vdso_offset_sigtrampt0x089c
>
> Changing the hard tab to ' ' causes both BSD and GNU dialects of sed
> to produce equivalent output.
>
> Signed-off-by: John Millikin <john@john-millikin.com>
> ---
> arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh b/arch/arm64/kernel/
> vdso/gen_vdso_offsets.sh
> index 8b806eacd0a6..0387209d65b1 100755
> --- a/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
> +++ b/arch/arm64/kernel/vdso/gen_vdso_offsets.sh
> @@ -13,4 +13,4 @@
>
> LC_ALL=C
> sed -n -e 's/^00*/0/' -e \
> -'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2\t0x\1/
> p'
> +'s/^\([0-9a-fA-F]*\) . VDSO_\([a-zA-Z0-9_]*\)$/\#define vdso_offset_\2 0x\1/p'
> --
> 2.24.3 (Apple Git-128)
I'm ok with the patch but could you please send it with git send-email?
More importantly, as text/plain as it arrived as html in my inbox and
the mailing list blocked it.
Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-20 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 5:10 [PATCH] arm64: Support running gen_vdso_offsets.sh with BSD userland John Millikin
2021-01-20 13:01 ` Will Deacon
[not found] <CAL1ky9ptQT6G_Y37WWOkNohy50otWnc4dGAeGO_Gs6BTLX4Gag@mail.gmail.com>
2020-12-15 12:41 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.