All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible
@ 2021-01-20 16:32 ` Jorgen Hansen
  0 siblings, 0 replies; 3+ messages in thread
From: Jorgen Hansen @ 2021-01-20 16:32 UTC (permalink / raw)
  To: linux-kernel, virtualization; +Cc: gregkh, pv-drivers, Jorgen Hansen

VMCI queue pair allocation is disabled, if a VM is in FT mode. In
these cases, VMware Tools may still once in a while attempt to
create a vSocket stream connection, resulting in multiple
warnings in the kernel logs. Therefore downgrade the error log to
a debug log.

Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
---
 drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index c490658..a3691c1 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
 	} else {
 		result = qp_alloc_hypercall(queue_pair_entry);
 		if (result < VMCI_SUCCESS) {
-			pr_warn("qp_alloc_hypercall result = %d\n", result);
+			pr_devel("qp_alloc_hypercall result = %d\n", result);
 			goto error;
 		}
 	}
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible
@ 2021-01-20 16:32 ` Jorgen Hansen
  0 siblings, 0 replies; 3+ messages in thread
From: Jorgen Hansen @ 2021-01-20 16:32 UTC (permalink / raw)
  To: linux-kernel, virtualization; +Cc: pv-drivers, gregkh, Jorgen Hansen

VMCI queue pair allocation is disabled, if a VM is in FT mode. In
these cases, VMware Tools may still once in a while attempt to
create a vSocket stream connection, resulting in multiple
warnings in the kernel logs. Therefore downgrade the error log to
a debug log.

Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
---
 drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
index c490658..a3691c1 100644
--- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
+++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
@@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
 	} else {
 		result = qp_alloc_hypercall(queue_pair_entry);
 		if (result < VMCI_SUCCESS) {
-			pr_warn("qp_alloc_hypercall result = %d\n", result);
+			pr_devel("qp_alloc_hypercall result = %d\n", result);
 			goto error;
 		}
 	}
-- 
2.6.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible
  2021-01-20 16:32 ` Jorgen Hansen
  (?)
@ 2021-02-02  9:57 ` Firo Yang
  -1 siblings, 0 replies; 3+ messages in thread
From: Firo Yang @ 2021-02-02  9:57 UTC (permalink / raw)
  To: Jorgen Hansen; +Cc: linux-kernel, virtualization, pv-drivers, gregkh

The 01/20/2021 08:32, Jorgen Hansen wrote:
> VMCI queue pair allocation is disabled, if a VM is in FT mode. In
> these cases, VMware Tools may still once in a while attempt to
> create a vSocket stream connection, resulting in multiple
> warnings in the kernel logs. Therefore downgrade the error log to
> a debug log.
> 
> Reviewed-by: Vishnu Dasa <vdasa@vmware.com>
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>
> ---
>  drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index c490658..a3691c1 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
>  	} else {
>  		result = qp_alloc_hypercall(queue_pair_entry);
>  		if (result < VMCI_SUCCESS) {
> -			pr_warn("qp_alloc_hypercall result = %d\n", result);
> +			pr_devel("qp_alloc_hypercall result = %d\n", result);

Hi Jorgen, recently, our customer reported that their dmesg was also
swamped by the following message along with the message above. 

  "Could not attach to queue pair with -20"

This message was printed by vmci_transport_queue_pair_alloc(). Could
we also eliminate it?

Thanks,
Firo


>  			goto error;
>  		}
>  	}
> -- 
> 2.6.2
> 
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 16:32 [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible Jorgen Hansen
2021-01-20 16:32 ` Jorgen Hansen
2021-02-02  9:57 ` Firo Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.