* [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits
@ 2021-01-21 13:54 Tvrtko Ursulin
2021-01-21 13:59 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2021-01-21 13:54 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Commit 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML") removed the
only platform which used bit 2 so could also decrease the
INTEL_SUBPLATFORM_BITS definition.
This is not a fixes material but still lets make it precise.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
References: 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML")
---
drivers/gpu/drm/i915/intel_device_info.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 79dab5a6f272..1d39a0f706d1 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -93,7 +93,7 @@ enum intel_platform {
* it is fine for the same bit to be used on multiple parent platforms.
*/
-#define INTEL_SUBPLATFORM_BITS (3)
+#define INTEL_SUBPLATFORM_BITS (2)
/* HSW/BDW/SKL/KBL/CFL */
#define INTEL_SUBPLATFORM_ULT (0)
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits
2021-01-21 13:54 [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits Tvrtko Ursulin
@ 2021-01-21 13:59 ` Chris Wilson
2021-01-21 15:43 ` Chris Wilson
2021-01-21 23:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-21 13:59 UTC (permalink / raw)
To: Intel-gfx, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2021-01-21 13:54:30)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Commit 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML") removed the
> only platform which used bit 2 so could also decrease the
> INTEL_SUBPLATFORM_BITS definition.
>
> This is not a fixes material but still lets make it precise.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> References: 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML")
> ---
> drivers/gpu/drm/i915/intel_device_info.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 79dab5a6f272..1d39a0f706d1 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -93,7 +93,7 @@ enum intel_platform {
> * it is fine for the same bit to be used on multiple parent platforms.
> */
>
> -#define INTEL_SUBPLATFORM_BITS (3)
> +#define INTEL_SUBPLATFORM_BITS (2)
No define SUBPLATFORM use that bit indeed. Our check that we don't
accidentally use that bit is however:
GEM_BUG_ON(mask & ~INTEL_SUBPLATFORM_BITS);
accidentally treating 3 as the right mask.
I don't think you can avoid the SUBPLATFORM_MASK bikeshedding :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits
2021-01-21 13:54 [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits Tvrtko Ursulin
2021-01-21 13:59 ` Chris Wilson
@ 2021-01-21 15:43 ` Chris Wilson
2021-01-21 23:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2021-01-21 15:43 UTC (permalink / raw)
To: Intel-gfx, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2021-01-21 13:54:30)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Commit 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML") removed the
> only platform which used bit 2 so could also decrease the
> INTEL_SUBPLATFORM_BITS definition.
>
> This is not a fixes material but still lets make it precise.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> References: 6ce1c33d6c36 ("drm/i915: Kill INTEL_SUBPLATFORM_AML")
With the usage of BITS corrected elsewhere,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Decrease number of subplatform bits
2021-01-21 13:54 [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits Tvrtko Ursulin
2021-01-21 13:59 ` Chris Wilson
2021-01-21 15:43 ` Chris Wilson
@ 2021-01-21 23:12 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2021-01-21 23:12 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4739 bytes --]
== Series Details ==
Series: drm/i915: Decrease number of subplatform bits
URL : https://patchwork.freedesktop.org/series/86139/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9664 -> Patchwork_19443
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19443 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19443, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19443:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-icl-u2: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-icl-u2/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-icl-u2/boot.html
- fi-cfl-8109u: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-cfl-8109u/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-cfl-8109u/boot.html
- fi-skl-6600u: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-skl-6600u/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-skl-6600u/boot.html
- fi-cml-u2: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-cml-u2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-cml-u2/boot.html
- fi-tgl-u2: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-tgl-u2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-tgl-u2/boot.html
- fi-bdw-gvtdvm: [PASS][11] -> [FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-bdw-gvtdvm/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-bdw-gvtdvm/boot.html
- fi-kbl-7500u: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-kbl-7500u/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-kbl-7500u/boot.html
- fi-bdw-5557u: [PASS][15] -> [FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-bdw-5557u/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-bdw-5557u/boot.html
Known issues
------------
Here are the changes found in Patchwork_19443 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [PASS][17] -> [DMESG-WARN][18] ([i915#402]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
#### Possible fixes ####
* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][19] ([i915#402]) -> [PASS][20] +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-tgl-y/igt@fbdev@read.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-tgl-y/igt@fbdev@read.html
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9664/fi-byt-j1900/igt@i915_module_load@reload.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/fi-byt-j1900/igt@i915_module_load@reload.html
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9664 -> Patchwork_19443
CI-20190529: 20190529
CI_DRM_9664: dd119a66c9fc3706c93efa10a7631a4c499d94f3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19443: 24f5fd07ff73791a68ce94a52bbef7b564386c24 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
24f5fd07ff73 drm/i915: Decrease number of subplatform bits
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19443/index.html
[-- Attachment #1.2: Type: text/html, Size: 5615 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-21 23:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 13:54 [Intel-gfx] [PATCH] drm/i915: Decrease number of subplatform bits Tvrtko Ursulin
2021-01-21 13:59 ` Chris Wilson
2021-01-21 15:43 ` Chris Wilson
2021-01-21 23:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.