* [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
@ 2021-01-21 6:03 ` Lokesh Vutla
0 siblings, 0 replies; 6+ messages in thread
From: Lokesh Vutla @ 2021-01-21 6:03 UTC (permalink / raw)
To: Nishanth Menon, Sekhar Nori, Rob Herring
Cc: Linux ARM Mailing List, Device Tree Mailing List,
Grygorii Strashko, Lokesh Vutla
From: Sekhar Nori <nsekhar@ti.com>
With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
like below for all interrupt controllers.
/bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
Fix these by adding #address-cells = <0>; for all interrupt controllers in
TI device-tree files. Any other #address-cells value is really only needed
if interrupt-map property is being used (which is not the case for existing
TI device-tree files)
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Changes since v3:
- Dropped adding address-cells for pca9554 as it is introducing a new
warning.
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++++
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 ++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 +
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 11 +++++++++++
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +++
6 files changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 12591a854020..85ae169ab0bb 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -439,6 +439,7 @@ intr_main_gpio: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <100>;
ti,interrupt-ranges = <0 392 32>;
@@ -460,6 +461,7 @@ intr_main_navss: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <182>;
ti,interrupt-ranges = <0 64 64>,
@@ -473,6 +475,7 @@ inta_main_udmass: interrupt-controller@33d00000 {
interrupt-parent = <&intr_main_navss>;
msi-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <179>;
ti,interrupt-ranges = <0 0 256>;
@@ -669,6 +672,7 @@ main_gpio0: gpio@600000 {
interrupts = <192>, <193>, <194>, <195>, <196>, <197>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <96>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 57 0>;
@@ -684,6 +688,7 @@ main_gpio1: gpio@601000 {
interrupts = <200>, <201>, <202>, <203>, <204>, <205>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <90>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 58 0>;
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index ed42f13e7663..7fe5782a1f79 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -75,6 +75,7 @@ intr_wkup_gpio: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <156>;
ti,interrupt-ranges = <0 712 16>;
@@ -89,6 +90,7 @@ wkup_gpio0: gpio@42110000 {
interrupts = <60>, <61>, <62>, <63>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <56>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 59 0>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 4cc2e9094d0e..421e2fa3e78f 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -74,6 +74,7 @@ main_gpio_intr: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <131>;
ti,interrupt-ranges = <8 392 56>;
@@ -92,6 +93,7 @@ main_navss_intr: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <213>;
ti,interrupt-ranges = <0 64 64>,
@@ -104,6 +106,7 @@ main_udmass_inta: msi-controller@33d00000 {
reg = <0x00 0x33d00000 0x00 0x100000>;
interrupt-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
interrupt-parent = <&main_navss_intr>;
msi-controller;
ti,sci = <&dmsc>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index 359e3e8a8cd0..0a8df7e4739c 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -102,6 +102,7 @@ wkup_gpio_intr: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <137>;
ti,interrupt-ranges = <16 960 16>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 2d526ea44a85..b527874929a2 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -82,6 +82,7 @@ main_gpio_intr: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <131>;
ti,interrupt-ranges = <8 392 56>;
@@ -103,6 +104,7 @@ main_navss_intr: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <213>;
ti,interrupt-ranges = <0 64 64>,
@@ -117,6 +119,7 @@ main_udmass_inta: interrupt-controller@33d00000 {
interrupt-parent = <&main_navss_intr>;
msi-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <209>;
ti,interrupt-ranges = <0 0 256>;
@@ -910,6 +913,7 @@ main_gpio0: gpio@600000 {
<260>, <261>, <262>, <263>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>;
@@ -926,6 +930,7 @@ main_gpio1: gpio@601000 {
interrupts = <288>, <289>, <290>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 106 TI_SCI_PD_EXCLUSIVE>;
@@ -943,6 +948,7 @@ main_gpio2: gpio@610000 {
<268>, <269>, <270>, <271>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 107 TI_SCI_PD_EXCLUSIVE>;
@@ -959,6 +965,7 @@ main_gpio3: gpio@611000 {
interrupts = <292>, <293>, <294>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 108 TI_SCI_PD_EXCLUSIVE>;
@@ -976,6 +983,7 @@ main_gpio4: gpio@620000 {
<276>, <277>, <278>, <279>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 109 TI_SCI_PD_EXCLUSIVE>;
@@ -992,6 +1000,7 @@ main_gpio5: gpio@621000 {
interrupts = <296>, <297>, <298>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 110 TI_SCI_PD_EXCLUSIVE>;
@@ -1009,6 +1018,7 @@ main_gpio6: gpio@630000 {
<284>, <285>, <286>, <287>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 111 TI_SCI_PD_EXCLUSIVE>;
@@ -1025,6 +1035,7 @@ main_gpio7: gpio@631000 {
interrupts = <300>, <301>, <302>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 112 TI_SCI_PD_EXCLUSIVE>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index 6c44afae9187..59820c4290c5 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -102,6 +102,7 @@ wkup_gpio_intr: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <137>;
ti,interrupt-ranges = <16 960 16>;
@@ -116,6 +117,7 @@ wkup_gpio0: gpio@42110000 {
interrupts = <103>, <104>, <105>, <106>, <107>, <108>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <84>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 113 TI_SCI_PD_EXCLUSIVE>;
@@ -132,6 +134,7 @@ wkup_gpio1: gpio@42100000 {
interrupts = <112>, <113>, <114>, <115>, <116>, <117>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <84>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 114 TI_SCI_PD_EXCLUSIVE>;
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
@ 2021-01-21 6:03 ` Lokesh Vutla
0 siblings, 0 replies; 6+ messages in thread
From: Lokesh Vutla @ 2021-01-21 6:03 UTC (permalink / raw)
To: Nishanth Menon, Sekhar Nori, Rob Herring
Cc: Lokesh Vutla, Device Tree Mailing List, Grygorii Strashko,
Linux ARM Mailing List
From: Sekhar Nori <nsekhar@ti.com>
With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
like below for all interrupt controllers.
/bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
Fix these by adding #address-cells = <0>; for all interrupt controllers in
TI device-tree files. Any other #address-cells value is really only needed
if interrupt-map property is being used (which is not the case for existing
TI device-tree files)
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Changes since v3:
- Dropped adding address-cells for pca9554 as it is introducing a new
warning.
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 5 +++++
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 ++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 1 +
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 11 +++++++++++
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +++
6 files changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 12591a854020..85ae169ab0bb 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -439,6 +439,7 @@ intr_main_gpio: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <100>;
ti,interrupt-ranges = <0 392 32>;
@@ -460,6 +461,7 @@ intr_main_navss: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <182>;
ti,interrupt-ranges = <0 64 64>,
@@ -473,6 +475,7 @@ inta_main_udmass: interrupt-controller@33d00000 {
interrupt-parent = <&intr_main_navss>;
msi-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <179>;
ti,interrupt-ranges = <0 0 256>;
@@ -669,6 +672,7 @@ main_gpio0: gpio@600000 {
interrupts = <192>, <193>, <194>, <195>, <196>, <197>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <96>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 57 0>;
@@ -684,6 +688,7 @@ main_gpio1: gpio@601000 {
interrupts = <200>, <201>, <202>, <203>, <204>, <205>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <90>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 58 0>;
diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
index ed42f13e7663..7fe5782a1f79 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
@@ -75,6 +75,7 @@ intr_wkup_gpio: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <156>;
ti,interrupt-ranges = <0 712 16>;
@@ -89,6 +90,7 @@ wkup_gpio0: gpio@42110000 {
interrupts = <60>, <61>, <62>, <63>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <56>;
ti,davinci-gpio-unbanked = <0>;
clocks = <&k3_clks 59 0>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 4cc2e9094d0e..421e2fa3e78f 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -74,6 +74,7 @@ main_gpio_intr: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <131>;
ti,interrupt-ranges = <8 392 56>;
@@ -92,6 +93,7 @@ main_navss_intr: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <213>;
ti,interrupt-ranges = <0 64 64>,
@@ -104,6 +106,7 @@ main_udmass_inta: msi-controller@33d00000 {
reg = <0x00 0x33d00000 0x00 0x100000>;
interrupt-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
interrupt-parent = <&main_navss_intr>;
msi-controller;
ti,sci = <&dmsc>;
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
index 359e3e8a8cd0..0a8df7e4739c 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
@@ -102,6 +102,7 @@ wkup_gpio_intr: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <137>;
ti,interrupt-ranges = <16 960 16>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 2d526ea44a85..b527874929a2 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -82,6 +82,7 @@ main_gpio_intr: interrupt-controller0 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <131>;
ti,interrupt-ranges = <8 392 56>;
@@ -103,6 +104,7 @@ main_navss_intr: interrupt-controller1 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <213>;
ti,interrupt-ranges = <0 64 64>,
@@ -117,6 +119,7 @@ main_udmass_inta: interrupt-controller@33d00000 {
interrupt-parent = <&main_navss_intr>;
msi-controller;
#interrupt-cells = <0>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <209>;
ti,interrupt-ranges = <0 0 256>;
@@ -910,6 +913,7 @@ main_gpio0: gpio@600000 {
<260>, <261>, <262>, <263>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 105 TI_SCI_PD_EXCLUSIVE>;
@@ -926,6 +930,7 @@ main_gpio1: gpio@601000 {
interrupts = <288>, <289>, <290>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 106 TI_SCI_PD_EXCLUSIVE>;
@@ -943,6 +948,7 @@ main_gpio2: gpio@610000 {
<268>, <269>, <270>, <271>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 107 TI_SCI_PD_EXCLUSIVE>;
@@ -959,6 +965,7 @@ main_gpio3: gpio@611000 {
interrupts = <292>, <293>, <294>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 108 TI_SCI_PD_EXCLUSIVE>;
@@ -976,6 +983,7 @@ main_gpio4: gpio@620000 {
<276>, <277>, <278>, <279>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 109 TI_SCI_PD_EXCLUSIVE>;
@@ -992,6 +1000,7 @@ main_gpio5: gpio@621000 {
interrupts = <296>, <297>, <298>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 110 TI_SCI_PD_EXCLUSIVE>;
@@ -1009,6 +1018,7 @@ main_gpio6: gpio@630000 {
<284>, <285>, <286>, <287>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <128>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 111 TI_SCI_PD_EXCLUSIVE>;
@@ -1025,6 +1035,7 @@ main_gpio7: gpio@631000 {
interrupts = <300>, <301>, <302>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <36>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 112 TI_SCI_PD_EXCLUSIVE>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index 6c44afae9187..59820c4290c5 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -102,6 +102,7 @@ wkup_gpio_intr: interrupt-controller2 {
interrupt-controller;
interrupt-parent = <&gic500>;
#interrupt-cells = <1>;
+ #address-cells = <0>;
ti,sci = <&dmsc>;
ti,sci-dev-id = <137>;
ti,interrupt-ranges = <16 960 16>;
@@ -116,6 +117,7 @@ wkup_gpio0: gpio@42110000 {
interrupts = <103>, <104>, <105>, <106>, <107>, <108>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <84>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 113 TI_SCI_PD_EXCLUSIVE>;
@@ -132,6 +134,7 @@ wkup_gpio1: gpio@42100000 {
interrupts = <112>, <113>, <114>, <115>, <116>, <117>;
interrupt-controller;
#interrupt-cells = <2>;
+ #address-cells = <0>;
ti,ngpio = <84>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 114 TI_SCI_PD_EXCLUSIVE>;
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
2021-01-21 6:03 ` Lokesh Vutla
@ 2021-01-22 12:49 ` Nishanth Menon
-1 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-01-22 12:49 UTC (permalink / raw)
To: Lokesh Vutla, Sekhar Nori, Rob Herring
Cc: Nishanth Menon, Grygorii Strashko, Device Tree Mailing List,
Linux ARM Mailing List
On Thu, 21 Jan 2021 11:33:05 +0530, Lokesh Vutla wrote:
> With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> like below for all interrupt controllers.
>
> /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
>
> Fix these by adding #address-cells = <0>; for all interrupt controllers in
> TI device-tree files. Any other #address-cells value is really only needed
> if interrupt-map property is being used (which is not the case for existing
> TI device-tree files)
Hi Lokesh Vutla,
I have applied the following to branch ti-k3-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
commit: 73d0af633c4bed02f8e71658c9e25ac8250b08c4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
@ 2021-01-22 12:49 ` Nishanth Menon
0 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-01-22 12:49 UTC (permalink / raw)
To: Lokesh Vutla, Sekhar Nori, Rob Herring
Cc: Nishanth Menon, Device Tree Mailing List, Grygorii Strashko,
Linux ARM Mailing List
On Thu, 21 Jan 2021 11:33:05 +0530, Lokesh Vutla wrote:
> With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> like below for all interrupt controllers.
>
> /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
>
> Fix these by adding #address-cells = <0>; for all interrupt controllers in
> TI device-tree files. Any other #address-cells value is really only needed
> if interrupt-map property is being used (which is not the case for existing
> TI device-tree files)
Hi Lokesh Vutla,
I have applied the following to branch ti-k3-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
commit: 73d0af633c4bed02f8e71658c9e25ac8250b08c4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
2021-01-22 12:49 ` Nishanth Menon
@ 2021-01-27 16:00 ` Nishanth Menon
-1 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-01-27 16:00 UTC (permalink / raw)
To: Lokesh Vutla, Sekhar Nori, Rob Herring, Andre Przywara, Rob Herring
Cc: Grygorii Strashko, Device Tree Mailing List, Linux ARM Mailing List
On 06:49-20210122, Nishanth Menon wrote:
> On Thu, 21 Jan 2021 11:33:05 +0530, Lokesh Vutla wrote:
> > With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> > like below for all interrupt controllers.
> >
> > /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
> >
> > Fix these by adding #address-cells = <0>; for all interrupt controllers in
> > TI device-tree files. Any other #address-cells value is really only needed
> > if interrupt-map property is being used (which is not the case for existing
> > TI device-tree files)
>
> Hi Lokesh Vutla,
>
> I have applied the following to branch ti-k3-next on [1].
> Thank you!
>
> [1/1] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
> commit: 73d0af633c4bed02f8e71658c9e25ac8250b08c4
>
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent up the chain during
> the next merge window (or sooner if it is a relevant bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
[...]
Lokesh,
Based on discussion on [1] - looks like #address-cells = 0 usage
is still to be resolved and needs some alignment between Andre and
Rob on where to take this (dtc fixups to handle this Vs explicit
#address-cells = 0 and increase in dtb size).
I propose we drop this patch rather than having to revert this at a
later point after I send a PR. Anyone has any objections?
[1] https://lore.kernel.org/linux-arm-kernel/20210126163839.57491132@slackpad.fritz.box/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
@ 2021-01-27 16:00 ` Nishanth Menon
0 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-01-27 16:00 UTC (permalink / raw)
To: Lokesh Vutla, Sekhar Nori, Rob Herring, Andre Przywara, Rob Herring
Cc: Device Tree Mailing List, Grygorii Strashko, Linux ARM Mailing List
On 06:49-20210122, Nishanth Menon wrote:
> On Thu, 21 Jan 2021 11:33:05 +0530, Lokesh Vutla wrote:
> > With dtc 1.6.0, building TI device-tree files with W=2 results in warnings
> > like below for all interrupt controllers.
> >
> > /bus@100000/bus@30000000/interrupt-controller1: Missing #address-cells in interrupt provider
> >
> > Fix these by adding #address-cells = <0>; for all interrupt controllers in
> > TI device-tree files. Any other #address-cells value is really only needed
> > if interrupt-map property is being used (which is not the case for existing
> > TI device-tree files)
>
> Hi Lokesh Vutla,
>
> I have applied the following to branch ti-k3-next on [1].
> Thank you!
>
> [1/1] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller
> commit: 73d0af633c4bed02f8e71658c9e25ac8250b08c4
>
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent up the chain during
> the next merge window (or sooner if it is a relevant bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
[...]
Lokesh,
Based on discussion on [1] - looks like #address-cells = 0 usage
is still to be resolved and needs some alignment between Andre and
Rob on where to take this (dtc fixups to handle this Vs explicit
#address-cells = 0 and increase in dtb size).
I propose we drop this patch rather than having to revert this at a
later point after I send a PR. Anyone has any objections?
[1] https://lore.kernel.org/linux-arm-kernel/20210126163839.57491132@slackpad.fritz.box/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-27 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 6:03 [PATCH v4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller Lokesh Vutla
2021-01-21 6:03 ` Lokesh Vutla
2021-01-22 12:49 ` Nishanth Menon
2021-01-22 12:49 ` Nishanth Menon
2021-01-27 16:00 ` Nishanth Menon
2021-01-27 16:00 ` Nishanth Menon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.