[PATCH v2 1/2] rtc: tps65910: Support wakeup-source property

* [PATCH v2 1/2] rtc: tps65910: Support wakeup-source property
@ 2021-01-20 21:16 Dmitry Osipenko
  2021-01-20 21:16 ` [PATCH v2 2/2] ARM: tegra: Specify tps65911 as wakeup source Dmitry Osipenko
  2021-01-25 23:21 ` (subset) [PATCH v2 1/2] rtc: tps65910: Support wakeup-source property Alexandre Belloni
  0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2021-01-20 21:16 UTC (permalink / raw)
  To: Alessandro Zummo, Alexandre Belloni, Thierry Reding,
	Jonathan Hunter, Peter Geis, Matt Merhar
  Cc: linux-rtc, linux-tegra, linux-kernel

TPS65910 is a PMIC MFD device and RTC is one of its functions. The
wakeup-source DT property is specified for the parent MFD device and we
need to use this property for the RTC in order to allow to use RTC alarm
for waking up system from suspend by default, instead of requiring user
to enable wakeup manually via sysfs.

Tested-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Matt Merhar <mattmerhar@protonmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---

Changelog:

v2: - Rebased on a recent linux-next, fixed merge conflict.

 drivers/rtc/rtc-tps65910.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-tps65910.c b/drivers/rtc/rtc-tps65910.c
index e1415a49f4ee..288abb1abdb8 100644
--- a/drivers/rtc/rtc-tps65910.c
+++ b/drivers/rtc/rtc-tps65910.c
@@ -418,10 +418,14 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
 		irq = -1;
 
 	tps_rtc->irq = irq;
-	if (irq != -1)
-		device_set_wakeup_capable(&pdev->dev, 1);
-	else
+	if (irq != -1) {
+		if (device_property_present(tps65910->dev, "wakeup-source"))
+			device_init_wakeup(&pdev->dev, 1);
+		else
+			device_set_wakeup_capable(&pdev->dev, 1);
+	} else {
 		clear_bit(RTC_FEATURE_ALARM, tps_rtc->rtc->features);
+	}
 
 	tps_rtc->rtc->ops = &tps65910_rtc_ops;
 	tps_rtc->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread