From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Nilesh Javali <njavali@marvell.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
Date: Wed, 27 Jan 2021 04:54:22 +0000 [thread overview]
Message-ID: <161172309263.28139.7036192153186894654.b4-ty@oracle.com> (raw)
In-Reply-To: <YAkaaSrhn1mFqyHy@mwanda>
On Thu, 21 Jan 2021 09:08:41 +0300, Dan Carpenter wrote:
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/c750a9c9c59a
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Nilesh Javali <njavali@marvell.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove unnecessary NULL check
Date: Tue, 26 Jan 2021 23:54:22 -0500 [thread overview]
Message-ID: <161172309263.28139.7036192153186894654.b4-ty@oracle.com> (raw)
In-Reply-To: <YAkaaSrhn1mFqyHy@mwanda>
On Thu, 21 Jan 2021 09:08:41 +0300, Dan Carpenter wrote:
> The list iterator can't be NULL so this check is not required. Removing
> the check silences a Smatch warning about inconsistent NULL checking.
>
> drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
> error: we previously assumed 'fcport' could be null (see line 372)
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: remove unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/c750a9c9c59a
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-01-27 4:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:08 [PATCH] scsi: qla2xxx: remove unnecessary NULL check Dan Carpenter
2021-01-21 6:08 ` Dan Carpenter
2021-01-21 6:20 ` Saurav Kashyap
2021-01-23 3:04 ` Martin K. Petersen
2021-01-23 3:04 ` Martin K. Petersen
2021-01-27 4:54 ` Martin K. Petersen [this message]
2021-01-27 4:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161172309263.28139.7036192153186894654.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.