[PATCH] fix qla1280 printk regression

[PATCH] fix qla1280 printk regression

[Rene Rebe]

Since Linus Torvalds reinstated KERN_CONT in commit 4bcc595 in 2015,
the qla1280 scsi driver printed a rather ugly and screen real estate
wasting multi-line per device status glibberish during boot.
Fix this by adding KERN_CONT as needed.

Tested on my Sgi Octane: https://youtu.be/Lfqe1SYR2jk

Signed-off-by: René Rebe <rene@exactcode.de>

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 545936cb3980..46de2541af25 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -3906,18 +3906,18 @@ qla1280_get_target_parameters(struct scsi_qla_host *ha,
 	printk(KERN_INFO "scsi(%li:%d:%d:%d):", ha->host_no, bus, target, lun);
 
 	if (mb[3] != 0) {
-		printk(" Sync: period %d, offset %d",
+		printk(KERN_CONT " Sync: period %d, offset %d",
 		       (mb[3] & 0xff), (mb[3] >> 8));
 		if (mb[2] & BIT_13)
-			printk(", Wide");
+			printk(KERN_CONT ", Wide");
 		if ((mb[2] & BIT_5) && ((mb[6] >> 8) & 0xff) >= 2)
-			printk(", DT");
+			printk(KERN_CONT ", DT");
 	} else
-		printk(" Async");
+		printk(KERN_CONT " Async");
 
 	if (device->simple_tags)
-		printk(", Tagged queuing: depth %d", device->queue_depth);
-	printk("\n");
+		printk(KERN_CONT ", Tagged queuing: depth %d", device->queue_depth);
+	printk(KERN_CONT "\n");
 }
 
 
 
-- 
  René Rebe, ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
  https://exactcode.com | https://t2sde.org | https://rene.rebe.de

Re: [PATCH] fix qla1280 printk regression

[Martin K. Petersen]

Rene,

> Since Linus Torvalds reinstated KERN_CONT in commit 4bcc595 in 2015,
> the qla1280 scsi driver printed a rather ugly and screen real estate
> wasting multi-line per device status glibberish during boot.
> Fix this by adding KERN_CONT as needed.

Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] fix qla1280 printk regression

[Martin K. Petersen]

On Thu, 10 Dec 2020 22:39:44 +0100 (CET), Rene Rebe wrote:

> Since Linus Torvalds reinstated KERN_CONT in commit 4bcc595 in 2015,
> the qla1280 scsi driver printed a rather ugly and screen real estate
> wasting multi-line per device status glibberish during boot.
> Fix this by adding KERN_CONT as needed.
> 
> Tested on my Sgi Octane: https://youtu.be/Lfqe1SYR2jk

Applied to 5.12/scsi-queue, thanks!

[1/1] fix qla1280 printk regression
      https://git.kernel.org/mkp/scsi/c/cd9df0c21636

-- 
Martin K. Petersen	Oracle Linux Engineering