* [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set
@ 2021-01-29 12:46 Chris Wilson
2021-01-29 13:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-01-30 12:42 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2021-01-29 12:46 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
Since userspace cannot run without any subslices, it seems remarkable
that any system would be configured with all fused off. Ignore the fuse
register if it says 0.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3022
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
index 0d9f74aec8fe..99c992db2ce7 100644
--- a/drivers/gpu/drm/i915/gt/intel_sseu.c
+++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
@@ -341,9 +341,10 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
* The subslice disable field is global, i.e. it applies
* to each of the enabled slices.
*/
- subslice_mask = (1 << sseu->max_subslices) - 1;
- subslice_mask &= ~((fuse2 & GEN9_F2_SS_DIS_MASK) >>
- GEN9_F2_SS_DIS_SHIFT);
+ subslice_mask = (fuse2 & GEN9_F2_SS_DIS_MASK) >> GEN9_F2_SS_DIS_SHIFT;
+ if (!subslice_mask) /* Ignore the fuse if it says there is no HW */
+ subslice_mask = ~0u;
+ subslice_mask &= GENMASK(sseu->max_subslices - 1, 0);
/*
* Iterate through enabled slices and subslices to
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Only trust sseu subslice fuse if it is set
2021-01-29 12:46 [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set Chris Wilson
@ 2021-01-29 13:59 ` Patchwork
2021-01-30 12:42 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2021-01-29 13:59 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4695 bytes --]
== Series Details ==
Series: drm/i915/gt: Only trust sseu subslice fuse if it is set
URL : https://patchwork.freedesktop.org/series/86451/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9699 -> Patchwork_19542
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19542 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19542, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19542:
### IGT changes ###
#### Possible regressions ####
* igt@i915_getparams_basic@basic-eu-total:
- fi-bxt-dsi: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-bxt-dsi/igt@i915_getparams_basic@basic-eu-total.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-bxt-dsi/igt@i915_getparams_basic@basic-eu-total.html
- fi-apl-guc: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-apl-guc/igt@i915_getparams_basic@basic-eu-total.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-apl-guc/igt@i915_getparams_basic@basic-eu-total.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-glk-dsi: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-glk-dsi/igt@i915_getparams_basic@basic-subslice-total.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-glk-dsi/igt@i915_getparams_basic@basic-subslice-total.html
Known issues
------------
Here are the changes found in Patchwork_19542 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#402]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- {fi-cml-drallion}: [INCOMPLETE][9] ([i915#1614]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-cml-drallion/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-cml-drallion/igt@gem_exec_suspend@basic-s0.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9699/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1614]: https://gitlab.freedesktop.org/drm/intel/issues/1614
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2331]: https://gitlab.freedesktop.org/drm/intel/issues/2331
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (45 -> 40)
------------------------------
Missing (5): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9699 -> Patchwork_19542
CI-20190529: 20190529
CI_DRM_9699: 227f6526730330c19bbf781bc59e684ccf373de8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5978: e1e5b3fea2baafdae0160940ecb8bf0242703840 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19542: b04632391b009f67d1d98596ec2434a693b2baf8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b04632391b00 drm/i915/gt: Only trust sseu subslice fuse if it is set
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19542/index.html
[-- Attachment #1.2: Type: text/html, Size: 5055 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set
2021-01-29 12:46 [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set Chris Wilson
2021-01-29 13:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2021-01-30 12:42 ` Lionel Landwerlin
1 sibling, 0 replies; 3+ messages in thread
From: Lionel Landwerlin @ 2021-01-30 12:42 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 29/01/2021 14:46, Chris Wilson wrote:
> Since userspace cannot run without any subslices, it seems remarkable
> that any system would be configured with all fused off. Ignore the fuse
> register if it says 0.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/3022
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_sseu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
> index 0d9f74aec8fe..99c992db2ce7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_sseu.c
> +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
> @@ -341,9 +341,10 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
> * The subslice disable field is global, i.e. it applies
> * to each of the enabled slices.
> */
> - subslice_mask = (1 << sseu->max_subslices) - 1;
> - subslice_mask &= ~((fuse2 & GEN9_F2_SS_DIS_MASK) >>
> - GEN9_F2_SS_DIS_SHIFT);
> + subslice_mask = (fuse2 & GEN9_F2_SS_DIS_MASK) >> GEN9_F2_SS_DIS_SHIFT;
> + if (!subslice_mask) /* Ignore the fuse if it says there is no HW */
> + subslice_mask = ~0u;
> + subslice_mask &= GENMASK(sseu->max_subslices - 1, 0);
>
> /*
> * Iterate through enabled slices and subslices to
I'm afraid it's not enough, as far as I can tell even the slice_mask is
wrong (user device is GT2, can't have 3 slices).
Time to reach out to HW folks.
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-30 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 12:46 [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set Chris Wilson
2021-01-29 13:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-01-30 12:42 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.