All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
@ 2021-02-01 10:24 ` John Garry
  0 siblings, 0 replies; 6+ messages in thread
From: John Garry @ 2021-02-01 10:24 UTC (permalink / raw)
  To: will, mark.rutland
  Cc: linux-arm-kernel, linux-kernel, robin.murphy, jean-philippe,
	thunder.leizhen, shameerali.kolothum.thodi, John Garry

The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.

However it is not the job of Kconfig to make these sorts of decisions (even
if it were true), so remove the dependency.

Signed-off-by: John Garry <john.garry@huawei.com>

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 3075cf171f78..77522e5efe11 100644
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -62,7 +62,7 @@ config ARM_PMU_ACPI
 
 config ARM_SMMU_V3_PMU
 	 tristate "ARM SMMUv3 Performance Monitors Extension"
-	 depends on ARM64 && ACPI && ARM_SMMU_V3
+	 depends on ARM64 && ACPI
 	   help
 	   Provides support for the ARM SMMUv3 Performance Monitor Counter
 	   Groups (PMCG), which provide monitoring of transactions passing
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
@ 2021-02-01 10:24 ` John Garry
  0 siblings, 0 replies; 6+ messages in thread
From: John Garry @ 2021-02-01 10:24 UTC (permalink / raw)
  To: will, mark.rutland
  Cc: jean-philippe, John Garry, linux-kernel,
	shameerali.kolothum.thodi, thunder.leizhen, robin.murphy,
	linux-arm-kernel

The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.

However it is not the job of Kconfig to make these sorts of decisions (even
if it were true), so remove the dependency.

Signed-off-by: John Garry <john.garry@huawei.com>

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 3075cf171f78..77522e5efe11 100644
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -62,7 +62,7 @@ config ARM_PMU_ACPI
 
 config ARM_SMMU_V3_PMU
 	 tristate "ARM SMMUv3 Performance Monitors Extension"
-	 depends on ARM64 && ACPI && ARM_SMMU_V3
+	 depends on ARM64 && ACPI
 	   help
 	   Provides support for the ARM SMMUv3 Performance Monitor Counter
 	   Groups (PMCG), which provide monitoring of transactions passing
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
  2021-02-01 10:24 ` John Garry
@ 2021-02-01 11:48   ` Robin Murphy
  -1 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2021-02-01 11:48 UTC (permalink / raw)
  To: John Garry, will, mark.rutland
  Cc: linux-arm-kernel, linux-kernel, jean-philippe, thunder.leizhen,
	shameerali.kolothum.thodi

On 2021-02-01 10:24, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
> 
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: John Garry <john.garry@huawei.com>
> 
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 3075cf171f78..77522e5efe11 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -62,7 +62,7 @@ config ARM_PMU_ACPI
>   
>   config ARM_SMMU_V3_PMU
>   	 tristate "ARM SMMUv3 Performance Monitors Extension"
> -	 depends on ARM64 && ACPI && ARM_SMMU_V3
> +	 depends on ARM64 && ACPI
>   	   help
>   	   Provides support for the ARM SMMUv3 Performance Monitor Counter
>   	   Groups (PMCG), which provide monitoring of transactions passing
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
@ 2021-02-01 11:48   ` Robin Murphy
  0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2021-02-01 11:48 UTC (permalink / raw)
  To: John Garry, will, mark.rutland
  Cc: jean-philippe, shameerali.kolothum.thodi, linux-kernel,
	linux-arm-kernel, thunder.leizhen

On 2021-02-01 10:24, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
> 
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: John Garry <john.garry@huawei.com>
> 
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 3075cf171f78..77522e5efe11 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -62,7 +62,7 @@ config ARM_PMU_ACPI
>   
>   config ARM_SMMU_V3_PMU
>   	 tristate "ARM SMMUv3 Performance Monitors Extension"
> -	 depends on ARM64 && ACPI && ARM_SMMU_V3
> +	 depends on ARM64 && ACPI
>   	   help
>   	   Provides support for the ARM SMMUv3 Performance Monitor Counter
>   	   Groups (PMCG), which provide monitoring of transactions passing
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
  2021-02-01 10:24 ` John Garry
@ 2021-02-01 13:05   ` Will Deacon
  -1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2021-02-01 13:05 UTC (permalink / raw)
  To: mark.rutland, John Garry
  Cc: catalin.marinas, kernel-team, Will Deacon, thunder.leizhen,
	shameerali.kolothum.thodi, jean-philippe, robin.murphy,
	linux-kernel, linux-arm-kernel

On Mon, 1 Feb 2021 18:24:02 +0800, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
> 
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
      https://git.kernel.org/will/c/34eb9359c111

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
@ 2021-02-01 13:05   ` Will Deacon
  0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2021-02-01 13:05 UTC (permalink / raw)
  To: mark.rutland, John Garry
  Cc: jean-philippe, Will Deacon, catalin.marinas, robin.murphy,
	shameerali.kolothum.thodi, linux-kernel, thunder.leizhen,
	kernel-team, linux-arm-kernel

On Mon, 1 Feb 2021 18:24:02 +0800, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
> 
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3
      https://git.kernel.org/will/c/34eb9359c111

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-01 13:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 10:24 [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3 John Garry
2021-02-01 10:24 ` John Garry
2021-02-01 11:48 ` Robin Murphy
2021-02-01 11:48   ` Robin Murphy
2021-02-01 13:05 ` Will Deacon
2021-02-01 13:05   ` Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.