* [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305
@ 2021-02-03 20:37 Vadim Fedorenko
2021-02-04 2:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Vadim Fedorenko @ 2021-02-03 20:37 UTC (permalink / raw)
To: Jakub Kicinski, Boris Pismenny, Rong Chen; +Cc: Vadim Fedorenko, netdev
TLS selftests were broken also because of use of structure that
was not exported to UAPI. Fix by defining the union in tests.
Fixes: 3502bd9b5762 (selftests/tls: fix selftests after adding ChaCha20-Poly1305)
Fixes: 4f336e88a870 (selftests/tls: add CHACHA20-POLY1305 to tls selftests)
Reported-by: Rong Chen <rong.a.chen@intel.com>
Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
---
tools/testing/selftests/net/tls.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c
index e0088c2..426d078 100644
--- a/tools/testing/selftests/net/tls.c
+++ b/tools/testing/selftests/net/tls.c
@@ -133,7 +133,10 @@
FIXTURE_SETUP(tls)
{
- union tls_crypto_context tls12;
+ union {
+ struct tls12_crypto_info_aes_gcm_128 aes128;
+ struct tls12_crypto_info_chacha20_poly1305 chacha20;
+ } tls12;
struct sockaddr_in addr;
socklen_t len;
int sfd, ret;
@@ -143,14 +146,16 @@
len = sizeof(addr);
memset(&tls12, 0, sizeof(tls12));
- tls12.info.version = variant->tls_version;
- tls12.info.cipher_type = variant->cipher_type;
switch (variant->cipher_type) {
case TLS_CIPHER_CHACHA20_POLY1305:
- tls12_sz = sizeof(tls12_crypto_info_chacha20_poly1305);
+ tls12_sz = sizeof(struct tls12_crypto_info_chacha20_poly1305);
+ tls12.chacha20.info.version = variant->tls_version;
+ tls12.chacha20.info.cipher_type = variant->cipher_type;
break;
case TLS_CIPHER_AES_GCM_128:
- tls12_sz = sizeof(tls12_crypto_info_aes_gcm_128);
+ tls12_sz = sizeof(struct tls12_crypto_info_aes_gcm_128);
+ tls12.aes128.info.version = variant->tls_version;
+ tls12.aes128.info.cipher_type = variant->cipher_type;
break;
default:
tls12_sz = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305
2021-02-03 20:37 [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305 Vadim Fedorenko
@ 2021-02-04 2:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-04 2:50 UTC (permalink / raw)
To: Vadim Fedorenko; +Cc: kuba, borisp, rong.a.chen, netdev
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 3 Feb 2021 23:37:14 +0300 you wrote:
> TLS selftests were broken also because of use of structure that
> was not exported to UAPI. Fix by defining the union in tests.
>
> Fixes: 3502bd9b5762 (selftests/tls: fix selftests after adding ChaCha20-Poly1305)
> Fixes: 4f336e88a870 (selftests/tls: add CHACHA20-POLY1305 to tls selftests)
> Reported-by: Rong Chen <rong.a.chen@intel.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
>
> [...]
Here is the summary with links:
- [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305
https://git.kernel.org/netdev/net/c/d795cc02a297
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 20:37 [net-next] selftests/tls: fix selftest with CHACHA20-POLY1305 Vadim Fedorenko
2021-02-04 2:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.