All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	loic.poulain@linaro.org, Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v6 2/8] bus: mhi: core: Clear context for stopped channels from remove()
Date: Thu,  4 Feb 2021 12:28:00 -0800	[thread overview]
Message-ID: <1612470486-10440-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1612470486-10440-1-git-send-email-bbhatt@codeaurora.org>

If a channel was explicitly stopped but not reset and a driver
remove is issued, clean up the channel context such that it is
reflected on the device. This move is useful if a client driver
module is unloaded or a device crash occurs with the host having
placed the channel in a stopped state.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index aa575d3..03c5786 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -1293,7 +1293,8 @@ static int mhi_driver_remove(struct device *dev)
 
 		mutex_lock(&mhi_chan->mutex);
 
-		if (ch_state[dir] == MHI_CH_STATE_ENABLED &&
+		if ((ch_state[dir] == MHI_CH_STATE_ENABLED ||
+		     ch_state[dir] == MHI_CH_STATE_STOP) &&
 		    !mhi_chan->offload_ch)
 			mhi_deinit_chan_ctxt(mhi_cntrl, mhi_chan);
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2021-02-04 20:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 20:27 [PATCH v6 0/8] Updates to MHI channel handling Bhaumik Bhatt
2021-02-04 20:27 ` [PATCH v6 1/8] bus: mhi: core: Allow sending the STOP channel command Bhaumik Bhatt
2021-02-04 20:28 ` Bhaumik Bhatt [this message]
2021-02-04 20:28 ` [PATCH v6 3/8] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2021-02-24 10:03   ` Manivannan Sadhasivam
2021-02-25  1:39     ` Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 4/8] bus: mhi: core: Clear configuration from channel context during reset Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 5/8] bus: mhi: core: Check channel execution environment before issuing reset Bhaumik Bhatt
2021-02-24 10:07   ` Manivannan Sadhasivam
2021-02-04 20:28 ` [PATCH v6 6/8] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 7/8] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2021-02-24 10:08   ` Manivannan Sadhasivam
2021-02-04 20:28 ` [PATCH v6 8/8] bus: mhi: core: Do not clear channel context more than once Bhaumik Bhatt
2021-02-05 22:46   ` Hemant Kumar
2021-02-24 10:10   ` Manivannan Sadhasivam
2021-02-24 18:55     ` Bhaumik Bhatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1612470486-10440-3-git-send-email-bbhatt@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.