All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hemant Kumar <hemantk@codeaurora.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org,
	linux-kernel@vger.kernel.org, loic.poulain@linaro.org
Subject: Re: [PATCH v6 8/8] bus: mhi: core: Do not clear channel context more than once
Date: Fri, 5 Feb 2021 14:46:39 -0800	[thread overview]
Message-ID: <3d1171bd-407b-f644-bbd1-bd6cb8769c18@codeaurora.org> (raw)
In-Reply-To: <1612470486-10440-9-git-send-email-bbhatt@codeaurora.org>



On 2/4/21 12:28 PM, Bhaumik Bhatt wrote:
> Clearing a channel context can happen twice if the client driver
> unprepares and reset the channels from the remove() callback from
> a controller requested MHI power down sequence. If there are
> multiple attempts at calling the mhi_free_coherent() API, we see
> kernel warnings such as "trying to free invalid coherent area".
> Example for one such client is the QRTR MHI driver. Avoid these
> warnings by skipping mhi_deinit_chan_ctxt() API call and prevent
> extra work from MHI as the channels are already disabled.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2021-02-06  2:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 20:27 [PATCH v6 0/8] Updates to MHI channel handling Bhaumik Bhatt
2021-02-04 20:27 ` [PATCH v6 1/8] bus: mhi: core: Allow sending the STOP channel command Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 2/8] bus: mhi: core: Clear context for stopped channels from remove() Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 3/8] bus: mhi: core: Improvements to the channel handling state machine Bhaumik Bhatt
2021-02-24 10:03   ` Manivannan Sadhasivam
2021-02-25  1:39     ` Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 4/8] bus: mhi: core: Clear configuration from channel context during reset Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 5/8] bus: mhi: core: Check channel execution environment before issuing reset Bhaumik Bhatt
2021-02-24 10:07   ` Manivannan Sadhasivam
2021-02-04 20:28 ` [PATCH v6 6/8] bus: mhi: core: Remove __ prefix for MHI channel unprepare function Bhaumik Bhatt
2021-02-04 20:28 ` [PATCH v6 7/8] bus: mhi: Improve documentation on channel transfer setup APIs Bhaumik Bhatt
2021-02-24 10:08   ` Manivannan Sadhasivam
2021-02-04 20:28 ` [PATCH v6 8/8] bus: mhi: core: Do not clear channel context more than once Bhaumik Bhatt
2021-02-05 22:46   ` Hemant Kumar [this message]
2021-02-24 10:10   ` Manivannan Sadhasivam
2021-02-24 18:55     ` Bhaumik Bhatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d1171bd-407b-f644-bbd1-bd6cb8769c18@codeaurora.org \
    --to=hemantk@codeaurora.org \
    --cc=bbhatt@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.