* [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c
@ 2021-02-05 6:33 Tiezhu Yang
2021-02-09 0:05 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2021-02-05 6:33 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel
When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
index ad41ea6..e704181 100644
--- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
+++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
@@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
ksft_print_msg(
- "ptrace(PTRACE_SINGLESTEP) failed: %s\n",
+ "ptrace(PTRACE_CONT) failed: %s\n",
strerror(errno));
return false;
}
@@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
}
alarm(0);
if (WIFEXITED(status)) {
- ksft_print_msg("child did not single-step\n");
+ ksft_print_msg("child exited prematurely\n");
return false;
}
if (!WIFSTOPPED(status)) {
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c
2021-02-05 6:33 [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c Tiezhu Yang
@ 2021-02-09 0:05 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2021-02-09 0:05 UTC (permalink / raw)
To: Tiezhu Yang, Shuah Khan; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 2/4/21 11:33 PM, Tiezhu Yang wrote:
> When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index ad41ea6..e704181 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>
> if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
> ksft_print_msg(
> - "ptrace(PTRACE_SINGLESTEP) failed: %s\n",
> + "ptrace(PTRACE_CONT) failed: %s\n",
> strerror(errno));
> return false;
> }
> @@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
> }
> alarm(0);
> if (WIFEXITED(status)) {
> - ksft_print_msg("child did not single-step\n");
> + ksft_print_msg("child exited prematurely\n");
> return false;
> }
> if (!WIFSTOPPED(status)) {
>
Thank you. Applied to linux-kselftest next for 5.12-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-09 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 6:33 [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c Tiezhu Yang
2021-02-09 0:05 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.