All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dave Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Lucas Stach <l.stach@pengutronix.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2] kernel: Expose SYS_kcmp by default
Date: Fri, 05 Feb 2021 21:28:52 +0000	[thread overview]
Message-ID: <161256053234.12021.17815864250035077266@build.alporthouse.com> (raw)
In-Reply-To: <202102051319.E5D8B4528D@keescook>

Quoting Kees Cook (2021-02-05 21:20:33)
> On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote:
> > The subject should of course be changed, as it is no longer being
> > enabled by default.
> 
> "default n" is redundant.

I thought being explicit would be preferred. There are a few other
default n, so at least it's not the odd-one-out!

> I thought Daniel said CONFIG_DRM needed to
> "select" it too, though?

Yes. We will need to select it for any DRM driver so that the Vulkan/GL
stacks can rely on having SYS_kcmp. That deserves to be handled and
explain within drm/Kconfig, and as they are already shipping with calls
to SYS_kcmp we may have to ask for a stable backport.

> Otherwise, yeah, this looks good. Was the
> export due to the 0-day bot failure reports?

Yes.
-Chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Will Drewry <wad@chromium.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] kernel: Expose SYS_kcmp by default
Date: Fri, 05 Feb 2021 21:28:52 +0000	[thread overview]
Message-ID: <161256053234.12021.17815864250035077266@build.alporthouse.com> (raw)
In-Reply-To: <202102051319.E5D8B4528D@keescook>

Quoting Kees Cook (2021-02-05 21:20:33)
> On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote:
> > The subject should of course be changed, as it is no longer being
> > enabled by default.
> 
> "default n" is redundant.

I thought being explicit would be preferred. There are a few other
default n, so at least it's not the odd-one-out!

> I thought Daniel said CONFIG_DRM needed to
> "select" it too, though?

Yes. We will need to select it for any DRM driver so that the Vulkan/GL
stacks can rely on having SYS_kcmp. That deserves to be handled and
explain within drm/Kconfig, and as they are already shipping with calls
to SYS_kcmp we may have to ask for a stable backport.

> Otherwise, yeah, this looks good. Was the
> export due to the 0-day bot failure reports?

Yes.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Will Drewry <wad@chromium.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default
Date: Fri, 05 Feb 2021 21:28:52 +0000	[thread overview]
Message-ID: <161256053234.12021.17815864250035077266@build.alporthouse.com> (raw)
In-Reply-To: <202102051319.E5D8B4528D@keescook>

Quoting Kees Cook (2021-02-05 21:20:33)
> On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote:
> > The subject should of course be changed, as it is no longer being
> > enabled by default.
> 
> "default n" is redundant.

I thought being explicit would be preferred. There are a few other
default n, so at least it's not the odd-one-out!

> I thought Daniel said CONFIG_DRM needed to
> "select" it too, though?

Yes. We will need to select it for any DRM driver so that the Vulkan/GL
stacks can rely on having SYS_kcmp. That deserves to be handled and
explain within drm/Kconfig, and as they are already shipping with calls
to SYS_kcmp we may have to ask for a stable backport.

> Otherwise, yeah, this looks good. Was the
> export due to the 0-day bot failure reports?

Yes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-05 21:49 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 16:37 [PATCH] kernel: Expose SYS_kcmp by default Chris Wilson
2021-02-05 16:37 ` [Intel-gfx] " Chris Wilson
2021-02-05 16:37 ` Chris Wilson
2021-02-05 17:02 ` Lucas Stach
2021-02-05 17:02   ` [Intel-gfx] " Lucas Stach
2021-02-05 17:02   ` Lucas Stach
2021-02-05 18:37 ` Kees Cook
2021-02-05 18:37   ` [Intel-gfx] " Kees Cook
2021-02-05 18:37   ` Kees Cook
2021-02-05 20:53   ` Daniel Vetter
2021-02-05 20:53     ` [Intel-gfx] " Daniel Vetter
2021-02-05 20:53     ` Daniel Vetter
2021-02-08 11:49     ` Michel Dänzer
2021-02-08 11:49       ` [Intel-gfx] " Michel Dänzer
2021-02-08 11:49       ` Michel Dänzer
2021-02-08 13:11       ` Michel Dänzer
2021-02-08 13:11         ` [Intel-gfx] " Michel Dänzer
2021-02-08 13:11         ` Michel Dänzer
2021-02-08 13:34       ` Daniel Vetter
2021-02-08 13:34         ` [Intel-gfx] " Daniel Vetter
2021-02-08 13:34         ` Daniel Vetter
2021-02-08 13:49         ` Michel Dänzer
2021-02-08 13:49           ` [Intel-gfx] " Michel Dänzer
2021-02-08 13:49           ` Michel Dänzer
2021-02-05 19:25 ` kernel test robot
2021-02-05 19:25   ` kernel test robot
2021-02-05 19:25   ` [Intel-gfx] " kernel test robot
2021-02-05 19:25   ` kernel test robot
2021-02-05 19:46 ` kernel test robot
2021-02-05 19:46   ` kernel test robot
2021-02-05 19:46   ` [Intel-gfx] " kernel test robot
2021-02-05 19:46   ` kernel test robot
2021-02-05 21:06 ` [PATCH v2] " Chris Wilson
2021-02-05 21:06   ` [Intel-gfx] " Chris Wilson
2021-02-05 21:06   ` Chris Wilson
2021-02-05 21:16   ` Chris Wilson
2021-02-05 21:16     ` [Intel-gfx] " Chris Wilson
2021-02-05 21:16     ` Chris Wilson
2021-02-05 21:20     ` Kees Cook
2021-02-05 21:20       ` [Intel-gfx] " Kees Cook
2021-02-05 21:20       ` Kees Cook
2021-02-05 21:28       ` Chris Wilson [this message]
2021-02-05 21:28         ` [Intel-gfx] " Chris Wilson
2021-02-05 21:28         ` Chris Wilson
2021-02-05 21:48         ` Daniel Vetter
2021-02-05 21:48           ` [Intel-gfx] " Daniel Vetter
2021-02-05 21:48           ` Daniel Vetter
2021-02-05 21:47   ` Rasmus Villemoes
2021-02-05 21:47     ` [Intel-gfx] " Rasmus Villemoes
2021-02-05 21:47     ` Rasmus Villemoes
2021-02-05 22:00 ` [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE Chris Wilson
2021-02-05 22:00   ` [Intel-gfx] " Chris Wilson
2021-02-05 22:00   ` Chris Wilson
2021-02-06 12:47   ` Cyrill Gorcunov
2021-02-06 12:47     ` [Intel-gfx] " Cyrill Gorcunov
2021-02-06 12:47     ` Cyrill Gorcunov
2021-02-08 22:12   ` Kees Cook
2021-02-08 22:12     ` [Intel-gfx] " Kees Cook
2021-02-08 22:12     ` Kees Cook
2021-02-16  9:02     ` Daniel Vetter
2021-02-16  9:02       ` [Intel-gfx] " Daniel Vetter
2021-02-16  9:02       ` Daniel Vetter
2021-02-12 12:57   ` Emil Velikov
2021-02-12 12:57     ` [Intel-gfx] " Emil Velikov
2021-02-12 12:57     ` Emil Velikov
2021-02-12 13:14     ` Simon Ser
2021-02-12 13:14       ` [Intel-gfx] " Simon Ser
2021-02-12 13:14       ` Simon Ser
2021-02-12 14:07       ` Emil Velikov
2021-02-12 14:07         ` [Intel-gfx] " Emil Velikov
2021-02-12 14:07         ` Emil Velikov
2021-02-12 14:01     ` Michel Dänzer
2021-02-12 14:01       ` [Intel-gfx] " Michel Dänzer
2021-02-12 14:01       ` Michel Dänzer
2021-02-12 14:09       ` Emil Velikov
2021-02-12 14:09         ` [Intel-gfx] " Emil Velikov
2021-02-12 14:09         ` Emil Velikov
2021-02-15  8:56   ` Thomas Zimmermann
2021-02-15  8:56     ` [Intel-gfx] " Thomas Zimmermann
2021-02-15  8:56     ` Thomas Zimmermann
2021-02-06  2:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for kernel: Expose SYS_kcmp by default (rev3) Patchwork
2021-02-06 14:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-02-13 17:40 ` [PATCH] kernel: Expose SYS_kcmp by default Pavel Machek
2021-02-13 17:40   ` [Intel-gfx] " Pavel Machek
2021-02-13 17:40   ` Pavel Machek
2021-02-15 10:23   ` Lucas Stach
2021-02-15 10:23     ` [Intel-gfx] " Lucas Stach
2021-02-15 10:23     ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161256053234.12021.17815864250035077266@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keescook@chromium.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.