From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Rob Clark <robdclark@gmail.com>
Cc: linux-kernel@vger.kernel.org, Sean Paul <sean@poorly.run>,
Kuogee Hsieh <khsieh@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] drm/msm/dp: Add a missing semi-colon
Date: Mon, 08 Feb 2021 10:57:07 -0800 [thread overview]
Message-ID: <161281062730.76967.14597290603195200219@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <8943f0acd2944144b21b5796c07e79ff5e707aaf.camel@perches.com>
Quoting Joe Perches (2021-02-06 21:06:54)
> On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote:
> > A missing semicolon here causes my external display to stop working.
> > Indeed, missing the semicolon on the return statement leads to
> > dp_panel_update_tu_timings() not existing because the compiler thinks
> > it's part of the return statement of a void function, so it must not be
> > important.
> >
> > $ ./scripts/bloat-o-meter before.o after.o
> > add/remove: 1/1 grow/shrink: 0/1 up/down: 7400/-7540 (-140)
> > Function old new delta
> > dp_panel_update_tu_timings - 7400 +7400
> > _dp_ctrl_calc_tu.constprop 18024 17900 -124
> > dp_panel_update_tu_timings.constprop 7416 - -7416
> > Total: Before=54440, After=54300, chg -0.26%
> >
> > Add a semicolon so this function works like it used to.
> []
> > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> []
> > @@ -631,7 +631,7 @@ static void _dp_ctrl_calc_tu(struct dp_tu_calc_input *in,
> >
> >
> > tu = kzalloc(sizeof(*tu), GFP_KERNEL);
> > if (!tu)
> > - return
> > + return;
> >
> >
> > dp_panel_update_tu_timings(in, tu);
>
> Wow, that's really unfortunate that dp_panel_update_tu_timings
> is also void.
>
> Perhaps this as YA checkpatch warning:
>
> ---
Acked-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Kuogee Hsieh <khsieh@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH] drm/msm/dp: Add a missing semi-colon
Date: Mon, 08 Feb 2021 10:57:07 -0800 [thread overview]
Message-ID: <161281062730.76967.14597290603195200219@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <8943f0acd2944144b21b5796c07e79ff5e707aaf.camel@perches.com>
Quoting Joe Perches (2021-02-06 21:06:54)
> On Sat, 2021-02-06 at 20:18 -0800, Stephen Boyd wrote:
> > A missing semicolon here causes my external display to stop working.
> > Indeed, missing the semicolon on the return statement leads to
> > dp_panel_update_tu_timings() not existing because the compiler thinks
> > it's part of the return statement of a void function, so it must not be
> > important.
> >
> > $ ./scripts/bloat-o-meter before.o after.o
> > add/remove: 1/1 grow/shrink: 0/1 up/down: 7400/-7540 (-140)
> > Function old new delta
> > dp_panel_update_tu_timings - 7400 +7400
> > _dp_ctrl_calc_tu.constprop 18024 17900 -124
> > dp_panel_update_tu_timings.constprop 7416 - -7416
> > Total: Before=54440, After=54300, chg -0.26%
> >
> > Add a semicolon so this function works like it used to.
> []
> > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> []
> > @@ -631,7 +631,7 @@ static void _dp_ctrl_calc_tu(struct dp_tu_calc_input *in,
> >
> >
> > tu = kzalloc(sizeof(*tu), GFP_KERNEL);
> > if (!tu)
> > - return
> > + return;
> >
> >
> > dp_panel_update_tu_timings(in, tu);
>
> Wow, that's really unfortunate that dp_panel_update_tu_timings
> is also void.
>
> Perhaps this as YA checkpatch warning:
>
> ---
Acked-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-08 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 4:18 [PATCH] drm/msm/dp: Add a missing semi-colon Stephen Boyd
2021-02-07 4:18 ` Stephen Boyd
2021-02-07 5:06 ` Joe Perches
2021-02-07 5:06 ` Joe Perches
2021-02-08 18:57 ` Stephen Boyd [this message]
2021-02-08 18:57 ` Stephen Boyd
2021-02-12 9:43 ` Joe Perches
2021-02-12 9:43 ` Joe Perches
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161281062730.76967.14597290603195200219@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=khsieh@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.