From: Stephen Boyd <sboyd@kernel.org>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
alexandre.belloni@bootlin.com, geert@linux-m68k.org,
gregkh@linuxfoundation.org, ludovic.desroches@microchip.com,
mturquette@baylibre.com, nicolas.ferre@microchip.com,
saravanak@google.com
Cc: mirq-linux@rere.qmqm.pl, claudiu.beznea@microchip.com,
a.fatoum@pengutronix.de, krzk@kernel.org,
codrin.ciubotariu@microchip.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks
Date: Tue, 09 Feb 2021 16:56:22 -0800 [thread overview]
Message-ID: <161291858241.418021.7620663458602138308@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210203154332.470587-1-tudor.ambarus@microchip.com>
Quoting Tudor Ambarus (2021-02-03 07:43:32)
> These are all "early clocks" that require initialization just at
> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
>
> This also fixes a problem that was spotted when fw_devlink was
> set to 'on' by default: the boards failed to boot. The reason is
> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
> the consumers of the clock to be postponed by fw_devlink until
> the second initialization routine of the clock has been completed.
> One of the consumers of the clock is the timer, which is used as a
> clocksource, and needs the clock initialized early. Postponing the
> timers caused the fail at boot.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
Applied to clk-next
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
alexandre.belloni@bootlin.com, geert@linux-m68k.org,
gregkh@linuxfoundation.org, ludovic.desroches@microchip.com,
mturquette@baylibre.com, nicolas.ferre@microchip.com,
saravanak@google.com
Cc: a.fatoum@pengutronix.de,
Tudor Ambarus <tudor.ambarus@microchip.com>,
linux-kernel@vger.kernel.org, krzk@kernel.org,
claudiu.beznea@microchip.com, codrin.ciubotariu@microchip.com,
mirq-linux@rere.qmqm.pl, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks
Date: Tue, 09 Feb 2021 16:56:22 -0800 [thread overview]
Message-ID: <161291858241.418021.7620663458602138308@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210203154332.470587-1-tudor.ambarus@microchip.com>
Quoting Tudor Ambarus (2021-02-03 07:43:32)
> These are all "early clocks" that require initialization just at
> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
>
> This also fixes a problem that was spotted when fw_devlink was
> set to 'on' by default: the boards failed to boot. The reason is
> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
> the consumers of the clock to be postponed by fw_devlink until
> the second initialization routine of the clock has been completed.
> One of the consumers of the clock is the timer, which is used as a
> clocksource, and needs the clock initialized early. Postponing the
> timers caused the fail at boot.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-10 2:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:43 [PATCH] clk: at91: Fix the declaration of the clocks Tudor Ambarus
2021-02-03 15:43 ` Tudor Ambarus
2021-02-03 18:15 ` Saravana Kannan
2021-02-03 18:15 ` Saravana Kannan
2021-02-04 12:46 ` Eugen.Hristev
2021-02-04 12:46 ` Eugen.Hristev
2021-02-04 13:54 ` Nicolas Ferre
2021-02-04 13:54 ` Nicolas Ferre
2021-02-08 9:49 ` Tudor.Ambarus
2021-02-08 9:49 ` Tudor.Ambarus
2021-02-10 0:54 ` Stephen Boyd
2021-02-10 0:54 ` Stephen Boyd
2021-02-10 0:56 ` Saravana Kannan
2021-02-10 0:56 ` Saravana Kannan
2021-02-10 8:51 ` Geert Uytterhoeven
2021-02-10 8:51 ` Geert Uytterhoeven
2021-02-10 8:57 ` Saravana Kannan
2021-02-10 8:57 ` Saravana Kannan
2021-02-10 9:10 ` Geert Uytterhoeven
2021-02-10 9:10 ` Geert Uytterhoeven
2021-02-10 9:00 ` Greg Kroah-Hartman
2021-02-10 9:00 ` Greg Kroah-Hartman
2021-02-10 16:22 ` Rob Herring
2021-02-10 16:22 ` Rob Herring
2021-02-10 0:56 ` Stephen Boyd [this message]
2021-02-10 0:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161291858241.418021.7620663458602138308@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=saravanak@google.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.