From: Stephen Boyd <sboyd@kernel.org>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Pali Rohár" <pali@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Marek Behún" <kabel@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Tomasz Maciej Nowak" <tmn505@gmail.com>,
"Luka Perkov" <luka.perkov@sartura.hr>,
"Andre Heider" <a.heider@gmail.com>,
"Vladimir Vid" <vladimir.vid@sartura.hr>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Gérald Kerma" <gerald@gk2.net>,
"Konstantin Porotchkin" <kostap@marvell.com>
Subject: Re: [PATCH mvebu v2 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz
Date: Tue, 09 Feb 2021 17:58:24 -0800 [thread overview]
Message-ID: <161292230417.418021.9609462768507058743@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210114124032.12765-6-pali@kernel.org>
Quoting Pali Rohár (2021-01-14 04:40:27)
> It was observed that the workaround introduced by commit 61c40f35f5cd
> ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to
> 1.2GHz") when base CPU frequency is 1.2 GHz is also required when base
> CPU frequency is 1 GHz. Otherwise switching CPU frequency directly from
> L2 (250 MHz) to L0 (1 GHz) causes a crash.
>
> When base CPU frequency is just 800 MHz no crashed were observed during
> switch from L2 to L0.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks")
> Cc: stable@vger.kernel.org # 61c40f35f5cd ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to 1.2GHz")
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Pali Rohár" <pali@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Marek Behún" <kabel@kernel.org>,
"Tomasz Maciej Nowak" <tmn505@gmail.com>,
"Luka Perkov" <luka.perkov@sartura.hr>,
"Andre Heider" <a.heider@gmail.com>,
"Vladimir Vid" <vladimir.vid@sartura.hr>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Gérald Kerma" <gerald@gk2.net>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Konstantin Porotchkin" <kostap@marvell.com>
Subject: Re: [PATCH mvebu v2 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz
Date: Tue, 09 Feb 2021 17:58:24 -0800 [thread overview]
Message-ID: <161292230417.418021.9609462768507058743@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210114124032.12765-6-pali@kernel.org>
Quoting Pali Rohár (2021-01-14 04:40:27)
> It was observed that the workaround introduced by commit 61c40f35f5cd
> ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to
> 1.2GHz") when base CPU frequency is 1.2 GHz is also required when base
> CPU frequency is 1 GHz. Otherwise switching CPU frequency directly from
> L2 (250 MHz) to L0 (1 GHz) causes a crash.
>
> When base CPU frequency is just 800 MHz no crashed were observed during
> switch from L2 to L0.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks")
> Cc: stable@vger.kernel.org # 61c40f35f5cd ("clk: mvebu: armada-37xx-periph: Fix switching CPU rate from 300Mhz to 1.2GHz")
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-10 2:30 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 12:40 [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-01-14 12:40 ` [PATCH mvebu v2 01/10] arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-04-02 19:50 ` Gregory CLEMENT
2021-04-02 19:50 ` Gregory CLEMENT
2021-01-14 12:40 ` [PATCH mvebu v2 02/10] cpufreq: armada-37xx: Fix setting TBG parent for load levels Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-01-14 12:40 ` [PATCH mvebu v2 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-02-10 1:58 ` Stephen Boyd
2021-02-10 1:58 ` Stephen Boyd
2021-01-14 12:40 ` [PATCH mvebu v2 04/10] cpufreq: armada-37xx: Fix the AVS value for loads L0 and L1 Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-01-14 12:40 ` [PATCH mvebu v2 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-02-10 1:58 ` Stephen Boyd [this message]
2021-02-10 1:58 ` Stephen Boyd
2021-01-14 12:40 ` [PATCH mvebu v2 06/10] clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0 Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-02-10 1:58 ` Stephen Boyd
2021-02-10 1:58 ` Stephen Boyd
2021-01-14 12:40 ` [PATCH mvebu v2 07/10] cpufreq: armada-37xx: Fix driver cleanup when registration failed Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-01-14 12:40 ` [PATCH mvebu v2 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-01-14 12:40 ` [PATCH mvebu v2 09/10] cpufreq: armada-37xx: Remove cur_frequency variable Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-03-29 15:00 ` Gregory CLEMENT
2021-03-29 15:00 ` Gregory CLEMENT
2021-03-29 21:44 ` Marek Behún
2021-03-29 21:44 ` Marek Behún
2021-01-14 12:40 ` [PATCH mvebu v2 10/10] cpufreq: armada-37xx: Fix module unloading Pali Rohár
2021-01-14 12:40 ` Pali Rohár
2021-02-01 14:35 ` [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz Tomasz Maciej Nowak
2021-02-01 14:35 ` Tomasz Maciej Nowak
2021-02-03 19:29 ` Anders Trier Olesen
2021-02-03 19:29 ` Anders Trier Olesen
2021-02-22 19:41 ` [PATCH mvebu v3 " Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-02-22 19:41 ` [PATCH mvebu v3 01/10] arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-02-22 19:41 ` [PATCH mvebu v3 02/10] cpufreq: armada-37xx: Fix setting TBG parent for load levels Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:45 ` Gregory CLEMENT
2021-03-29 14:45 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:46 ` Gregory CLEMENT
2021-03-29 14:46 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 04/10] cpufreq: armada-37xx: Fix the AVS value for load L1 Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:47 ` Gregory CLEMENT
2021-03-29 14:47 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:48 ` Gregory CLEMENT
2021-03-29 14:48 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 06/10] clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0 Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:49 ` Gregory CLEMENT
2021-03-29 14:49 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 07/10] cpufreq: armada-37xx: Fix driver cleanup when registration failed Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:58 ` Gregory CLEMENT
2021-03-29 14:58 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-29 14:59 ` Gregory CLEMENT
2021-03-29 14:59 ` Gregory CLEMENT
2021-02-22 19:41 ` [PATCH mvebu v3 09/10] cpufreq: armada-37xx: Remove cur_frequency variable Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-02-22 19:41 ` [PATCH mvebu v3 10/10] cpufreq: armada-37xx: Fix module unloading Pali Rohár
2021-02-22 19:41 ` Pali Rohár
2021-03-01 19:20 ` [PATCH mvebu v3 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz Pali Rohár
2021-03-01 19:20 ` Pali Rohár
2021-03-12 9:12 ` Gregory CLEMENT
2021-03-12 9:12 ` Gregory CLEMENT
2021-03-12 9:27 ` Marek Behún
2021-03-12 9:27 ` Marek Behún
2021-03-28 11:31 ` Pali Rohár
2021-03-28 11:31 ` Pali Rohár
2021-04-08 0:38 ` Stephen Boyd
2021-04-08 0:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161292230417.418021.9609462768507058743@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=a.heider@gmail.com \
--cc=andrew@lunn.ch \
--cc=gerald@gk2.net \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=pali@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tmn505@gmail.com \
--cc=vladimir.vid@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.