From: Chris Wilson <chris@chris-wilson.co.uk> To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] intel_gpu_top: Aggregate clients by PID by default Date: Wed, 10 Feb 2021 10:35:59 +0000 [thread overview] Message-ID: <161295335978.6673.9313077497176923458@build.alporthouse.com> (raw) In-Reply-To: <20210210093756.61424-2-tvrtko.ursulin@linux.intel.com> Quoting Tvrtko Ursulin (2021-02-10 09:37:55) > +static struct clients *aggregated_clients(struct clients *clients) > +{ > + struct client *ac, *c, *cp = NULL; > + struct clients *aggregated; > + int tmp, num = 0; > + > + /* Sort by pid first to make it easy to aggregate while walking. */ > + sort_clients(clients, client_pid_cmp); You could eliminate this tiny bit of duplication by always calling aggregated_clients() and returning here for !aggregate_pids. > + aggregated = calloc(1, sizeof(*clients)); > + assert(aggregated); > + > + ac = calloc(clients->num_clients, sizeof(*c)); > + assert(ac); > + > + aggregated->num_classes = clients->num_classes; > + aggregated->class = clients->class; > + aggregated->client = ac; > + > + for_each_client(clients, c, tmp) { > + unsigned int i; > + > + if (c->status == FREE) > + break; > + > + assert(c->status == ALIVE); > + > + if ((cp && c->pid != cp->pid) || !cp) { > + ac = &aggregated->client[num]; > + > + /* New pid. */ > + ac->clients = aggregated; > + ac->status = ALIVE; > + ac->id = ++num; > + ac->pid = c->pid; > + strcpy(ac->name, c->name); > + strcpy(ac->print_name, c->print_name); > + ac->engines = c->engines; > + ac->val = calloc(clients->num_classes, > + sizeof(ac->val[0])); > + assert(ac->val); > + ac->samples = 1; > + } > + > + cp = c; > + > + if (c->samples < 2) > + continue; > + > + ac->samples = 2; /* All what matters for display. */ > + ac->total_runtime += c->total_runtime; > + ac->last_runtime += c->last_runtime; > + > + for (i = 0; i < clients->num_classes; i++) > + ac->val[i] += c->val[i]; > + } > + > + aggregated->num_clients = num; > + aggregated->active_clients = num; > + > + return sort_clients(aggregated, client_cmp); > } Ok, that works very well. Hmm. The sort order does seem a little jumpy though. May I suggest ac->id = -c->pid; instead of num; -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk> To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 2/3] intel_gpu_top: Aggregate clients by PID by default Date: Wed, 10 Feb 2021 10:35:59 +0000 [thread overview] Message-ID: <161295335978.6673.9313077497176923458@build.alporthouse.com> (raw) In-Reply-To: <20210210093756.61424-2-tvrtko.ursulin@linux.intel.com> Quoting Tvrtko Ursulin (2021-02-10 09:37:55) > +static struct clients *aggregated_clients(struct clients *clients) > +{ > + struct client *ac, *c, *cp = NULL; > + struct clients *aggregated; > + int tmp, num = 0; > + > + /* Sort by pid first to make it easy to aggregate while walking. */ > + sort_clients(clients, client_pid_cmp); You could eliminate this tiny bit of duplication by always calling aggregated_clients() and returning here for !aggregate_pids. > + aggregated = calloc(1, sizeof(*clients)); > + assert(aggregated); > + > + ac = calloc(clients->num_clients, sizeof(*c)); > + assert(ac); > + > + aggregated->num_classes = clients->num_classes; > + aggregated->class = clients->class; > + aggregated->client = ac; > + > + for_each_client(clients, c, tmp) { > + unsigned int i; > + > + if (c->status == FREE) > + break; > + > + assert(c->status == ALIVE); > + > + if ((cp && c->pid != cp->pid) || !cp) { > + ac = &aggregated->client[num]; > + > + /* New pid. */ > + ac->clients = aggregated; > + ac->status = ALIVE; > + ac->id = ++num; > + ac->pid = c->pid; > + strcpy(ac->name, c->name); > + strcpy(ac->print_name, c->print_name); > + ac->engines = c->engines; > + ac->val = calloc(clients->num_classes, > + sizeof(ac->val[0])); > + assert(ac->val); > + ac->samples = 1; > + } > + > + cp = c; > + > + if (c->samples < 2) > + continue; > + > + ac->samples = 2; /* All what matters for display. */ > + ac->total_runtime += c->total_runtime; > + ac->last_runtime += c->last_runtime; > + > + for (i = 0; i < clients->num_classes; i++) > + ac->val[i] += c->val[i]; > + } > + > + aggregated->num_clients = num; > + aggregated->active_clients = num; > + > + return sort_clients(aggregated, client_cmp); > } Ok, that works very well. Hmm. The sort order does seem a little jumpy though. May I suggest ac->id = -c->pid; instead of num; -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-02-10 10:36 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-10 9:37 [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Wrap interactive header Tvrtko Ursulin 2021-02-10 9:37 ` [igt-dev] " Tvrtko Ursulin 2021-02-10 9:37 ` [Intel-gfx] [PATCH i-g-t 2/3] intel_gpu_top: Aggregate clients by PID by default Tvrtko Ursulin 2021-02-10 9:44 ` Tvrtko Ursulin 2021-02-10 10:35 ` Chris Wilson [this message] 2021-02-10 10:35 ` [igt-dev] " Chris Wilson 2021-02-10 10:55 ` [Intel-gfx] " Tvrtko Ursulin 2021-02-10 10:55 ` Tvrtko Ursulin 2021-02-10 11:03 ` [Intel-gfx] " Chris Wilson 2021-02-10 10:53 ` [Intel-gfx] " Tvrtko Ursulin 2021-02-10 11:06 ` Chris Wilson 2021-02-10 11:06 ` [igt-dev] " Chris Wilson 2021-02-10 11:12 ` Tvrtko Ursulin 2021-02-10 11:12 ` [igt-dev] " Tvrtko Ursulin 2021-02-10 9:37 ` [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Interactive help screen Tvrtko Ursulin 2021-02-10 9:37 ` [igt-dev] " Tvrtko Ursulin 2021-02-10 10:36 ` [Intel-gfx] " Chris Wilson 2021-02-10 10:36 ` Chris Wilson 2021-02-10 10:37 ` [Intel-gfx] [PATCH i-g-t 1/3] intel_gpu_top: Wrap interactive header Chris Wilson 2021-02-10 11:35 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] intel_gpu_top: Wrap interactive header (rev4) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=161295335978.6673.9313077497176923458@build.alporthouse.com \ --to=chris@chris-wilson.co.uk \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=igt-dev@lists.freedesktop.org \ --cc=tvrtko.ursulin@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.