From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, akpm@linux-foundation.org,
will@kernel.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Christoph Hellwig <hch@lst.de>,
David Hildenbrand <david@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
Date: Thu, 11 Feb 2021 11:52:09 +0530 [thread overview]
Message-ID: <1613024531-19040-2-git-send-email-anshuman.khandual@arm.com> (raw)
In-Reply-To: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com>
With HUGETLB_PAGE_SIZE_VARIABLE enabled, pageblock_order cannot be assigned
as HUGETLB_PAGE_ORDER when it is greater than or equal to MAX_ORDER during
set_pageblock_order(). Otherwise the following warning is triggered during
boot as detected on an arm64 platform.
WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0
Modules linked in:
CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-00004-ga0ea7d62002 #159
Hardware name: linux,dummy-virt (DT)
[ 8.810673] pstate: 20400005 (nzCv daif +PAN -UAO -TCO BTYPE=--)
[ 8.811732] pc : __fragmentation_index+0xa4/0xc0
[ 8.812555] lr : fragmentation_index+0xf8/0x138
[ 8.813360] sp : ffff0000864079b0
[ 8.813958] x29: ffff0000864079b0 x28: 0000000000000372
[ 8.814901] x27: 0000000000007682 x26: ffff8000135b3948
[ 8.815847] x25: 1fffe00010c80f48 x24: 0000000000000000
[ 8.816805] x23: 0000000000000000 x22: 000000000000000d
[ 8.817764] x21: 0000000000000030 x20: ffff0005ffcb4d58
[ 8.818712] x19: 000000000000000b x18: 0000000000000000
[ 8.819656] x17: 0000000000000000 x16: 0000000000000000
[ 8.820613] x15: 0000000000000000 x14: ffff8000114c6258
[ 8.821560] x13: ffff6000bff969ba x12: 1fffe000bff969b9
[ 8.822514] x11: 1fffe000bff969b9 x10: ffff6000bff969b9
[ 8.823461] x9 : dfff800000000000 x8 : ffff0005ffcb4dcf
[ 8.824415] x7 : 0000000000000001 x6 : 0000000041b58ab3
[ 8.825359] x5 : ffff600010c80f48 x4 : dfff800000000000
[ 8.826313] x3 : ffff8000102be670 x2 : 0000000000000007
[ 8.827259] x1 : ffff000086407a60 x0 : 000000000000000d
[ 8.828218] Call trace:
[ 8.828667] __fragmentation_index+0xa4/0xc0
[ 8.829436] fragmentation_index+0xf8/0x138
[ 8.830194] compaction_suitable+0x98/0xb8
[ 8.830934] wakeup_kcompactd+0xdc/0x128
[ 8.831640] balance_pgdat+0x71c/0x7a0
[ 8.832327] kswapd+0x31c/0x520
[ 8.832902] kthread+0x224/0x230
[ 8.833491] ret_from_fork+0x10/0x30
[ 8.834150] ---[ end trace 472836f79c15516b ]---
The above warning happens because pageblock_order exceeds MAX_ORDER, caused
by large HUGETLB_PAGE_ORDER on certain platforms like arm64. Lets prevent
the scenario by first checking HUGETLB_PAGE_ORDER against MAX_ORDER, before
its assignment as pageblock_order.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 519a60d5b6f7..36473f2fa683 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6798,7 +6798,7 @@ void __init set_pageblock_order(void)
if (pageblock_order)
return;
- if (HPAGE_SHIFT > PAGE_SHIFT)
+ if ((HPAGE_SHIFT > PAGE_SHIFT) && (HUGETLB_PAGE_ORDER < MAX_ORDER))
order = HUGETLB_PAGE_ORDER;
else
order = MAX_ORDER - 1;
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, akpm@linux-foundation.org,
will@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
Date: Thu, 11 Feb 2021 11:52:09 +0530 [thread overview]
Message-ID: <1613024531-19040-2-git-send-email-anshuman.khandual@arm.com> (raw)
In-Reply-To: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com>
With HUGETLB_PAGE_SIZE_VARIABLE enabled, pageblock_order cannot be assigned
as HUGETLB_PAGE_ORDER when it is greater than or equal to MAX_ORDER during
set_pageblock_order(). Otherwise the following warning is triggered during
boot as detected on an arm64 platform.
WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0
Modules linked in:
CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-00004-ga0ea7d62002 #159
Hardware name: linux,dummy-virt (DT)
[ 8.810673] pstate: 20400005 (nzCv daif +PAN -UAO -TCO BTYPE=--)
[ 8.811732] pc : __fragmentation_index+0xa4/0xc0
[ 8.812555] lr : fragmentation_index+0xf8/0x138
[ 8.813360] sp : ffff0000864079b0
[ 8.813958] x29: ffff0000864079b0 x28: 0000000000000372
[ 8.814901] x27: 0000000000007682 x26: ffff8000135b3948
[ 8.815847] x25: 1fffe00010c80f48 x24: 0000000000000000
[ 8.816805] x23: 0000000000000000 x22: 000000000000000d
[ 8.817764] x21: 0000000000000030 x20: ffff0005ffcb4d58
[ 8.818712] x19: 000000000000000b x18: 0000000000000000
[ 8.819656] x17: 0000000000000000 x16: 0000000000000000
[ 8.820613] x15: 0000000000000000 x14: ffff8000114c6258
[ 8.821560] x13: ffff6000bff969ba x12: 1fffe000bff969b9
[ 8.822514] x11: 1fffe000bff969b9 x10: ffff6000bff969b9
[ 8.823461] x9 : dfff800000000000 x8 : ffff0005ffcb4dcf
[ 8.824415] x7 : 0000000000000001 x6 : 0000000041b58ab3
[ 8.825359] x5 : ffff600010c80f48 x4 : dfff800000000000
[ 8.826313] x3 : ffff8000102be670 x2 : 0000000000000007
[ 8.827259] x1 : ffff000086407a60 x0 : 000000000000000d
[ 8.828218] Call trace:
[ 8.828667] __fragmentation_index+0xa4/0xc0
[ 8.829436] fragmentation_index+0xf8/0x138
[ 8.830194] compaction_suitable+0x98/0xb8
[ 8.830934] wakeup_kcompactd+0xdc/0x128
[ 8.831640] balance_pgdat+0x71c/0x7a0
[ 8.832327] kswapd+0x31c/0x520
[ 8.832902] kthread+0x224/0x230
[ 8.833491] ret_from_fork+0x10/0x30
[ 8.834150] ---[ end trace 472836f79c15516b ]---
The above warning happens because pageblock_order exceeds MAX_ORDER, caused
by large HUGETLB_PAGE_ORDER on certain platforms like arm64. Lets prevent
the scenario by first checking HUGETLB_PAGE_ORDER against MAX_ORDER, before
its assignment as pageblock_order.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 519a60d5b6f7..36473f2fa683 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6798,7 +6798,7 @@ void __init set_pageblock_order(void)
if (pageblock_order)
return;
- if (HPAGE_SHIFT > PAGE_SHIFT)
+ if ((HPAGE_SHIFT > PAGE_SHIFT) && (HUGETLB_PAGE_ORDER < MAX_ORDER))
order = HUGETLB_PAGE_ORDER;
else
order = MAX_ORDER - 1;
--
2.20.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, akpm@linux-foundation.org,
will@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER
Date: Thu, 11 Feb 2021 11:52:09 +0530 [thread overview]
Message-ID: <1613024531-19040-2-git-send-email-anshuman.khandual@arm.com> (raw)
In-Reply-To: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com>
With HUGETLB_PAGE_SIZE_VARIABLE enabled, pageblock_order cannot be assigned
as HUGETLB_PAGE_ORDER when it is greater than or equal to MAX_ORDER during
set_pageblock_order(). Otherwise the following warning is triggered during
boot as detected on an arm64 platform.
WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0
Modules linked in:
CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-00004-ga0ea7d62002 #159
Hardware name: linux,dummy-virt (DT)
[ 8.810673] pstate: 20400005 (nzCv daif +PAN -UAO -TCO BTYPE=--)
[ 8.811732] pc : __fragmentation_index+0xa4/0xc0
[ 8.812555] lr : fragmentation_index+0xf8/0x138
[ 8.813360] sp : ffff0000864079b0
[ 8.813958] x29: ffff0000864079b0 x28: 0000000000000372
[ 8.814901] x27: 0000000000007682 x26: ffff8000135b3948
[ 8.815847] x25: 1fffe00010c80f48 x24: 0000000000000000
[ 8.816805] x23: 0000000000000000 x22: 000000000000000d
[ 8.817764] x21: 0000000000000030 x20: ffff0005ffcb4d58
[ 8.818712] x19: 000000000000000b x18: 0000000000000000
[ 8.819656] x17: 0000000000000000 x16: 0000000000000000
[ 8.820613] x15: 0000000000000000 x14: ffff8000114c6258
[ 8.821560] x13: ffff6000bff969ba x12: 1fffe000bff969b9
[ 8.822514] x11: 1fffe000bff969b9 x10: ffff6000bff969b9
[ 8.823461] x9 : dfff800000000000 x8 : ffff0005ffcb4dcf
[ 8.824415] x7 : 0000000000000001 x6 : 0000000041b58ab3
[ 8.825359] x5 : ffff600010c80f48 x4 : dfff800000000000
[ 8.826313] x3 : ffff8000102be670 x2 : 0000000000000007
[ 8.827259] x1 : ffff000086407a60 x0 : 000000000000000d
[ 8.828218] Call trace:
[ 8.828667] __fragmentation_index+0xa4/0xc0
[ 8.829436] fragmentation_index+0xf8/0x138
[ 8.830194] compaction_suitable+0x98/0xb8
[ 8.830934] wakeup_kcompactd+0xdc/0x128
[ 8.831640] balance_pgdat+0x71c/0x7a0
[ 8.832327] kswapd+0x31c/0x520
[ 8.832902] kthread+0x224/0x230
[ 8.833491] ret_from_fork+0x10/0x30
[ 8.834150] ---[ end trace 472836f79c15516b ]---
The above warning happens because pageblock_order exceeds MAX_ORDER, caused
by large HUGETLB_PAGE_ORDER on certain platforms like arm64. Lets prevent
the scenario by first checking HUGETLB_PAGE_ORDER against MAX_ORDER, before
its assignment as pageblock_order.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 519a60d5b6f7..36473f2fa683 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6798,7 +6798,7 @@ void __init set_pageblock_order(void)
if (pageblock_order)
return;
- if (HPAGE_SHIFT > PAGE_SHIFT)
+ if ((HPAGE_SHIFT > PAGE_SHIFT) && (HUGETLB_PAGE_ORDER < MAX_ORDER))
order = HUGETLB_PAGE_ORDER;
else
order = MAX_ORDER - 1;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-11 6:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 6:22 [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual [this message]
2021-02-11 6:22 ` [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 8:00 ` Christoph Hellwig
2021-02-11 8:00 ` Christoph Hellwig
2021-02-11 8:00 ` Christoph Hellwig
2021-02-12 7:12 ` Anshuman Khandual
2021-02-12 7:12 ` Anshuman Khandual
2021-02-12 7:12 ` Anshuman Khandual
2021-02-11 6:22 ` [PATCH 2/3] arm64/hugetlb: Enable HUGETLB_PAGE_SIZE_VARIABLE Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 8:01 ` Christoph Hellwig
2021-02-11 8:01 ` Christoph Hellwig
2021-02-11 8:01 ` Christoph Hellwig
2021-02-12 7:13 ` Anshuman Khandual
2021-02-12 7:13 ` Anshuman Khandual
2021-02-12 7:13 ` Anshuman Khandual
2021-02-11 6:22 ` [PATCH 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 6:22 ` Anshuman Khandual
2021-02-11 8:04 ` Christoph Hellwig
2021-02-11 8:04 ` Christoph Hellwig
2021-02-11 8:04 ` Christoph Hellwig
2021-02-12 7:19 ` Anshuman Khandual
2021-02-12 7:19 ` Anshuman Khandual
2021-02-12 7:19 ` Anshuman Khandual
2021-02-11 8:37 ` [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE David Hildenbrand
2021-02-11 8:37 ` David Hildenbrand
2021-02-11 8:37 ` David Hildenbrand
2021-02-12 7:02 ` Anshuman Khandual
2021-02-12 7:02 ` Anshuman Khandual
2021-02-12 7:02 ` Anshuman Khandual
2021-02-12 9:39 ` David Hildenbrand
2021-02-12 9:39 ` David Hildenbrand
2021-02-12 9:39 ` David Hildenbrand
2021-02-16 9:02 ` Anshuman Khandual
2021-02-16 9:02 ` Anshuman Khandual
2021-02-16 9:02 ` Anshuman Khandual
2021-02-16 9:04 ` David Hildenbrand
2021-02-16 9:04 ` David Hildenbrand
2021-02-16 9:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1613024531-19040-2-git-send-email-anshuman.khandual@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.